Re: svn commit: r1815799 - in /subversion/trunk/subversion: libsvn_ra_serf/commit.c tests/libsvn_ra/ra-test.c

2017-11-21 Thread Julian Foad
Evgeny Kotkov wrote: I think that I have missed that open_root() must open a directory and so it cannot be used when working with a file URL. This, in turn, means that the test example is indeed an undocumented/invalid usage of the delta editor API and that it works by a coincidence. I can prop

Re: svn commit: r1815799 - in /subversion/trunk/subversion: libsvn_ra_serf/commit.c tests/libsvn_ra/ra-test.c

2017-11-21 Thread Evgeny Kotkov
Bert Huijben writes: > I'm not sure if we should really allow this. > > The delta editor explicitly describes that you are opening a directory and > then edit the nodes inside. Only changing properties on the root is allowed > and other operations are all on nodes within. Allowing to open the nod

RE: svn commit: r1815799 - in /subversion/trunk/subversion: libsvn_ra_serf/commit.c tests/libsvn_ra/ra-test.c

2017-11-21 Thread Bert Huijben
> -Original Message- > From: kot...@apache.org [mailto:kot...@apache.org] > Sent: maandag 20 november 2017 13:44 > To: comm...@subversion.apache.org > Subject: svn commit: r1815799 - in /subversion/trunk/subversion: > libsvn_ra_serf/commit.c tests/libsvn_ra/ra-test.c > > Author: kotkov >