Re: svn commit: r1803722 - /subversion/branches/1.9.x/STATUS

2017-08-02 Thread Daniel Shahaf
James McCoy wrote on Wed, Aug 02, 2017 at 20:51:20 -0400: > On Wed, Aug 02, 2017 at 02:07:20PM +, Daniel Shahaf wrote: > > james...@apache.org wrote on Wed, Aug 02, 2017 at 01:35:31 -: > > > * r1802032 > > > Install 'fsfs-stats' as a wrapper to 'svnfsfs', to which it was > > > rename

Re: svn commit: r1803722 - /subversion/branches/1.9.x/STATUS

2017-08-02 Thread James McCoy
On Wed, Aug 02, 2017 at 02:07:20PM +, Daniel Shahaf wrote: > james...@apache.org wrote on Wed, Aug 02, 2017 at 01:35:31 -: > > * r1802032 > > Install 'fsfs-stats' as a wrapper to 'svnfsfs', to which it was renamed > > in > > r1618848. > > Justification: > > Backwards co

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Philip Martin
Ian Mordey writes: > Thanks very much for your assistance. If you require any further info/tests > running please let me know and I'll sort it out. configure attempts to detect the builtin atomics by building and running the following code: int main() { unsigned long long val = 1010, tmp,

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Philip Martin
Ian Mordey writes: > Thanks very much for your assistance. If you require any further info/tests > running please let me know and I'll sort it out. Subversion 1.8 has regression tests for the atomic code: make check TESTS=subversion/tests/libsvn_subr/named_atomic-test It would be good it yo

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Ian Mordey
> > > Looks like you need to unset SVN_HAS_ATOMIC_BUILTINS in > >subversion/svn_private_config.h > Awesome. It looks like it's compiling now. > Perhaps you used gcc rather than suncc? > Nope.. It's always been suncc but it was a much, much older version so maybe the detection worked on that

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Philip Martin
Ian Mordey writes: > Aha! Found it! > > nm subversion/libsvn_subr/named_atomic.o > subversion/libsvn_subr/named_atomic.o: > subversion/libsvn_subr/named_atomic.o doesn't exist in 1.9.6 which explains > why that built and 1.8 doesn't.. I'd forgotten about that one :-( Looks like you need to uns

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Ian Mordey
> > > You can run nm on the Subversion object files, e.g: > >nm subversion/libsvn_subr/*.o > Aha! Found it! nm subversion/libsvn_subr/named_atomic.o subversion/libsvn_subr/named_atomic.o: [Index] Value Size Type Bind Other Shndx Name [29]| 0| 0|SECT |LOCL

Re: svn commit: r1803639 - in /subversion/trunk: build/run_tests.py subversion/libsvn_fs_fs/fs.h subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_fs_fs/transaction.c subversion/tests/cmdline/svntest/

2017-08-02 Thread Daniel Shahaf
Evgeny Kotkov wrote on Wed, Aug 02, 2017 at 15:25:33 +0300: > Daniel Shahaf writes: > > > The documentation implies that CONFIG_OPTION_COMPRESSION can be used > > regardless of the filesystem format, … > > > … but the code only reads CONFIG_OPTION_COMPRESSION in f8 filesystems. > > > > Given the

Re: svn commit: r1803899 - in /subversion/trunk/subversion: libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/

2017-08-02 Thread Stefan Sperling
On Wed, Aug 02, 2017 at 06:49:55PM -, kot...@apache.org wrote: > +svn_boolean_t > +svn_ra_serf__is_local_network(svn_ra_serf__session_t *session) > +{ > + return session->conn_latency >= 0 && > + session->conn_latency < apr_time_from_msec(5); > +} "local network" is a rather blurry co

[RFC] Using LZ4 compression by default

2017-08-02 Thread Evgeny Kotkov
Hi all, With the recently added support for LZ4 compression (r1801940 et al), we now have an option of using it by default for the on-disk data and over the wire. For those who haven't been following this topic, here's a quick recap: - Currently, our default compression algorithm is zlib. - L

Fwd: svn commit: r1803899 - in /subversion/trunk/subversion: libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/

2017-08-02 Thread Evgeny Kotkov
Evgeny Kotkov writes: > Add 'http-compression=auto' mode on the client, now used by default. > > Following up on the recently added support for LZ4 compression, this patch > introduces the new possible 'auto' mode for our client 'http-compression' > configuration option, and starts using it by de

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Philip Martin
Ian Mordey writes: > So I don't see any __sync symbols anywhere.. Yes, that is what is expected for an APR_ATOMICS_GENERIC build. > Does this mean they're in another dependency somewhere? There are several options, including: - the __sync symbols are in one of the dependencies, zlib, openss

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Ian Mordey
> > > Lets look at the symbols in APR object files: > > atomic/unix/builtin.o > atomic/unix/mutex.o > atomic/unix/solaris.o > > You can run nm on those files to see which symbols they provide and > which are undefined. Only one of the files should have symbols, the > other two are effectivel

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Philip Martin
Ian Mordey writes: > I first added --disable-nonportable-atomics to the configure and rebuilt > APR. SVN fails in the same way. > > I tried running unsetting HAVE_ATOMIC_BUILTINS after configure but before > running make and still get the same error.. I think the __sync symbols were originally G

Re: svn commit: r1803722 - /subversion/branches/1.9.x/STATUS

2017-08-02 Thread Daniel Shahaf
james...@apache.org wrote on Wed, Aug 02, 2017 at 01:35:31 -: > * r1802032 > Install 'fsfs-stats' as a wrapper to 'svnfsfs', to which it was renamed in > r1618848. > Justification: > Backwards compatibility with 1.8.x tools/. > Votes: > + -0: jamessan ($(bindir) and

Re: Benchmarks for PUT for various fsfs config settings.

2017-08-02 Thread Paul Hammant
> > > Here it is - http://imgur.com/a/vBeKi - a more interesting graph. > Note that was 4 iterations, not 6 (as before). Server side Storage Used (MB): Default: 129 No_Compression_No_Deltification: 257 No_Deltification_No_Rep_Sharing: 513 No_Compression_No_Deltification_No_Rep_Sharing: 513 No_

Re: Benchmarks for PUT for various fsfs config settings.

2017-08-02 Thread Paul Hammant
> > Next up - larger files where the second has a mid-section that changes for > a few bytes, vs the first. > Here it is - http://imgur.com/a/vBeKi - a more interesting graph.

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Ian Mordey
On Wed, Aug 2, 2017 at 11:23 AM Philip Martin wrote: > Ian Mordey writes: > > > Undefined first referenced > > symbol in file > > __sync_add_and_fetch > > Modern compilers usually provide fast "atomics" and most code will try > to use compiler a

Re: svn commit: r1803639 - in /subversion/trunk: build/run_tests.py subversion/libsvn_fs_fs/fs.h subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_fs_fs/transaction.c subversion/tests/cmdline/svntest/

2017-08-02 Thread Evgeny Kotkov
Daniel Shahaf writes: > The documentation implies that CONFIG_OPTION_COMPRESSION can be used > regardless of the filesystem format, … > … but the code only reads CONFIG_OPTION_COMPRESSION in f8 filesystems. > > Given the docs as written, I would expect to be able to edit fsfs.conf > and replace

Re: Benchmarks for PUT for various fsfs config settings.

2017-08-02 Thread Paul Hammant
Alternate file sizes - still pretty much every byte different between the two alternately uploaded files: 24MB - http://imgur.com/a/kPyY8 4MB - http://imgur.com/a/uRaW8 Next up - larger files where the second has a mid-section that changes for a few bytes, vs the first.

Re: Subversion 1.8.x on Solaris 10 x86

2017-08-02 Thread Philip Martin
Ian Mordey writes: > Undefined first referenced > symbol in file > __sync_add_and_fetch Modern compilers usually provide fast "atomics" and most code will try to use compiler atomics if possible. Subversion itself relies on APR for atomics so w