[PATCH v4] Reject checkouts to existing directory

2016-11-24 Thread Patrick Steinhardt
Hi, this is version 4 of my patch which aims to reject checkouts to obstructed targets in order to protect the user from doing unintended things. I've attached an interdiff to version 3. There are no changes to the logic, version 4 only addresses comments by Daniel: - the listing callback now ret

Re: [PATCH] Recreate test data for Git mirrors

2016-11-24 Thread Patrick Steinhardt
On Thu, Nov 24, 2016 at 11:48:23AM +, Julian Foad wrote: > Julian Foad wrote: > > Daniel Shahaf wrote: > >> My one comment about your patch is that the import tree should be > >> created under svn-test-work/local_tmp/, rather than under > >> import_tests_data/; I believe the latter should be co

Re: 1.9.5 up for signing/testing

2016-11-24 Thread Branko Čibej
Summary: +1 to release (Windows) Platform Windows 10 Pro x64 Build tools: Microsoft Visual Studio Professional 2015 CMake 3.2.3 SCons 2.3.4 (patched for MSVC14) Source dependencies: APR 1.5.2 APR-Util 1.5.4 zlib 1.2.8 httpd 2.4.16 with

Re: 1.9.5 up for signing/testing

2016-11-24 Thread Stefan Sperling
On Mon, Nov 21, 2016 at 06:30:31PM +0300, Evgeny Kotkov wrote: > The 1.9.5 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on November 29th > so

Re: 1.8.17 up for signing/testing

2016-11-24 Thread Stefan Sperling
On Mon, Nov 21, 2016 at 06:30:09PM +0300, Evgeny Kotkov wrote: > The 1.8.17 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on November 29th > so

Re: Failed fs-test 65 (Was: Re: 1.9.5 up for signing/testing)

2016-11-24 Thread Branko Čibej
On 24.11.2016 12:06, Evgeny Kotkov wrote: > Evgeny Kotkov writes: > >>> The question is: what do we do about it? Complaining to Apple isn't >>> likely to help. We could add a special case in the testcase for that >>> version of SQLite on OSX, just to keep the test output in the green. But >>> ...

Re: [PATCH] Recreate test data for Git mirrors

2016-11-24 Thread Julian Foad
Julian Foad wrote: Daniel Shahaf wrote: My one comment about your patch is that the import tree should be created under svn-test-work/local_tmp/, rather than under import_tests_data/; I believe the latter should be considered read-only. Oh yes! I forgot to call that out. I'll re-work it. OK,

Re: Failed fs-test 65 (Was: Re: 1.9.5 up for signing/testing)

2016-11-24 Thread Evgeny Kotkov
Evgeny Kotkov writes: >> The question is: what do we do about it? Complaining to Apple isn't >> likely to help. We could add a special case in the testcase for that >> version of SQLite on OSX, just to keep the test output in the green. But >> ... that seems like just a bit overdone. > > To my mi

Re: [PATCH] Recreate test data for Git mirrors

2016-11-24 Thread Julian Foad
Daniel Shahaf wrote: Julian Foad wrote on Wed, Nov 23, 2016 at 21:03:52 +: Would anyone else care to comment, and review my patch if you think it looks good in principle, please? Thanks for the ping. Both your approach and Patrick's approach would solve the original problem, namely, would

Re: Failed fs-test 65 (Was: Re: 1.9.5 up for signing/testing)

2016-11-24 Thread Evgeny Kotkov
Julian Foad writes: > Just a drive-by thought: Should we report this to SQLite? Especially if by > distilling the Subversion test we could write a SQLite self-test. I recall > the SQLite team is big on thorough regression testing and so would likely > want to know about this. > > (They then might

Re: Failed fs-test 65 (Was: Re: 1.9.5 up for signing/testing)

2016-11-24 Thread Julian Foad
Branko Čibej wrote: To be quite candid, I'm not surprised ... this wouldn't be the first time that Apple messed up its patches of perfectly good upstream software. :( The question is: what do we do about it? Complaining to Apple isn't likely to help. We could add a special case in the testcase f

Re: Failed fs-test 65 (Was: Re: 1.9.5 up for signing/testing)

2016-11-24 Thread Branko Čibej
On 24.11.2016 00:05, Evgeny Kotkov wrote: > Branko Čibej writes: > >> It is reproducible whether run as a single test, all of fs-test or the >> whole test suite; but only with SQLite 3.8.10.2. I suspect it is a test >> bug, but haven't followed up; could be due to a bug in SQLite itself, >> e.g.,