Re: get-deps.sh: Serf Links Broken

2016-11-02 Thread Daniel Shahaf
John L. Poole wrote on Wed, Nov 02, 2016 at 13:22:45 -0700: > In Subversion 1.9.4, the get-deps.sh script points to serf.googlecode.com > which is no longer a valid URL for this project; serf moved to apache.org. This has been fixed in HEAD: % svn cat ^/subversion/branches/1.9.x/get-deps.sh | gre

get-deps.sh: Serf Links Broken

2016-11-02 Thread John L. Poole
In Subversion 1.9.4, the get-deps.sh script points to serf.googlecode.com which is no longer a valid URL for this project; serf moved to apache.org.Consequently, using get-deps.sh as instructed causes the build to fail. This is a bug, but I dare not open a bug because of the stated policy

Re: [PATCH] Perl bindings corrupt "{DATE}" revision variable

2016-11-02 Thread Roderich Schupp
On Wed, Nov 2, 2016 at 8:41 PM, Daniel Shahaf wrote: > Thanks, Roderich. Could you update the log message with an appropriate > "Verbed by"[1] clause, for contribulyzer? > Done. > I assume this should be backported, in which case, here is my +0 for > backport of the patch as committed. > > No

Re: [PATCH] Perl bindings corrupt "{DATE}" revision variable

2016-11-02 Thread Daniel Shahaf
roderich.sch...@gmail.com wrote on Wed, Nov 02, 2016 at 12:36:02 -0700: > Commited as 1767768, slightly modified to address the above concerns. Thanks, Roderich. Could you update the log message with an appropriate "Verbed by"[1] clause, for contribulyzer? I assume this should be backported, in

Re: [PATCH] Perl bindings corrupt "{DATE}" revision variable

2016-11-02 Thread roderich.sch...@gmail.com
On Wednesday, November 2, 2016 at 7:48:04 PM UTC+1, Daniel Shahaf wrote: > > Do the perl bindings use C89, like libsvn*? C89 forbids middle-of-block > declarations. > ... > The two maybe_croak() calls after this line (one of them in the patch > context, one just below it) would now print two r

Re: [PATCH] Perl bindings corrupt "{DATE}" revision variable

2016-11-02 Thread Daniel Shahaf
Rainer Müller wrote on Wed, Nov 02, 2016 at 18:29:04 +0100: > Index: subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c > === > --- subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c > (revision 1767623) > +++

[PATCH] Perl bindings corrupt "{DATE}" revision variable

2016-11-02 Thread Rainer Müller
Hello, when passing a revision string in the form of "{DATE}" to the Perl bindings, the passed string is unexpectedly modified during parsing and the closing brace will be removed. Here is a Perl script reproducing the issue with an example: ---8<--- use SVN::Client; my $ctx = SVN::Client->new(

Re: [PATCH] fix "svnadmin create" fail on x86

2016-11-02 Thread Daniel Shahaf
Bert Huijben wrote on Wed, Nov 02, 2016 at 11:57:29 +0100: > > > > -Original Message- > > From: Dengke Du [mailto:dengke...@windriver.com] > > Sent: woensdag 2 november 2016 10:22 > > To: dev@subversion.apache.org > > Subject: [PATCH] fix "svnadmin create" fail on x86 > > > > When run th

RE: [PATCH] fix "svnadmin create" fail on x86

2016-11-02 Thread Bert Huijben
> -Original Message- > From: Dengke Du [mailto:dengke...@windriver.com] > Sent: woensdag 2 november 2016 10:22 > To: dev@subversion.apache.org > Subject: [PATCH] fix "svnadmin create" fail on x86 > > When run the following command on x86: > > svnadmin create /var/test_repo > >

[PATCH] fix "svnadmin create" fail on x86

2016-11-02 Thread Dengke Du
When run the following command on x86: svnadmin create /var/test_repo It cause segmentation fault error like the following: [16499.751837] svnadmin[21117]: segfault at 83 ip f74bf7f6 sp ffdd9b34 error 4 in libc-2.24.so[f7441000+1af000] Segmentation fault