Re: svn commit: r1727621 - in /subversion/trunk/subversion: svn/svn.c svnadmin/svnadmin.c svnbench/svnbench.c svnfsfs/svnfsfs.c svnlook/svnlook.c svnrdump/svnrdump.c svnsync/svnsync.c

2016-02-08 Thread Daniel Shahaf
Philip Martin wrote on Mon, Feb 08, 2016 at 10:33:05 +: > When there are two different signals I don't think there is a 'correct' > signal with which to exit, all that matters is that we exit with one of > the signals. Agreed. > So how about: > > int saved_signum = signum_cancelled; >

Re: [RFE] Make 'svn patch' read from STDIN

2016-02-08 Thread Daniel Shahaf
Bert Huijben wrote on Sun, Feb 07, 2016 at 13:56:12 +0100: > Well.. Perhaps ^D works on your platform, but you will need other keys > on other platforms. If different platforms use different keys then the message can use #ifdef to print the right advice. I expected readers to assume that, at the

Re: [PATCH] Fix for access violation in svn_fs__path_valid()

2016-02-08 Thread Daniel Shahaf
Stefan wrote on Sun, Feb 07, 2016 at 20:51:08 +0100: > On 2/7/2016 01:22, Daniel Shahaf wrote: > >Stefan wrote on Mon, Feb 01, 2016 at 00:34:32 +0100: > >>+++ fs-loader.c (working copy) > >>@@ -461,7 +461,8 @@ > >>if (! svn_utf__cstring_is_valid(path)) > >> { > >>return svn_err

Re: Subversion FSFS logical addressing and packed shard

2016-02-08 Thread Philip Martin
Yves Martin writes: > I would like to better understand how logical addressing has impact on > packed shard. My objective is to provide a "unpack" feature with logical > addressing in my version of "fsfs-reshard.py" script: > https://github.com/ymartin59/svn-fsfs-reshard > > Do you have any hints

Re: [RFE] Make 'svn patch' read from STDIN

2016-02-08 Thread Andreas Scherer
Am Sonntag, 31. Januar 2016, 11:48:26 schrieb Andreas Scherer: > using 'svn patch' directly as a drop-in replacement for [patch] I found an example where 'svn patch' does _not_ behave as expected and differently than 'patch' (and other programmes). When I amend this line https://github.com/as

Re: svn commit: r1727621 - in /subversion/trunk/subversion: svn/svn.c svnadmin/svnadmin.c svnbench/svnbench.c svnfsfs/svnfsfs.c svnlook/svnlook.c svnrdump/svnrdump.c svnsync/svnsync.c

2016-02-08 Thread Philip Martin
Daniel Shahaf writes: > I think we have two options to fix this: either make signum_cancelled > a write-once variable (never write to it if it's nonzero), or have the > handler install SIG_IGN handlers for all signals we catch, not just for > one of them. Or perhaps both? The former approach se