Re: svn commit: r1685985 - in /subversion/branches/fsx-1.10/subversion: include/private/svn_mutex.h libsvn_fs_x/batch_fsync.c libsvn_fs_x/batch_fsync.h libsvn_fs_x/fs.c libsvn_subr/mutex.c tests/libsv

2015-06-18 Thread Stefan Fuhrmann
On Wed, Jun 17, 2015 at 3:46 PM, Bert Huijben wrote: > > > > -Original Message- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: woensdag 17 juni 2015 12:09 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1685985 - in > /subversion/branches/fsx-1.10/subve

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

2015-06-18 Thread Stefan Fuhrmann
On Thu, Jun 18, 2015 at 3:24 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > Sorry, my bad, I was wrong there. I only remembered that we had and still > > have the pack/hotcopy race condition in 1.8 and then I saw the recursive > > directory copy calls in the /trunk hotcopy code and had

Re: [Patch] apr_file_path_merge returns incorrect truepath on certain 'short paths' on Windows

2015-06-18 Thread William A Rowe Jr
Looks great, thanks Brane, and Bert for calling this out. On Thu, Jun 18, 2015 at 3:43 AM, Branko Čibej wrote: > On 17.06.2015 15:53, Branko Čibej wrote: > > Thanks for the reminder! Will do. > On 17 Jun 2015 12:37 pm, "Yann Ylavic" wrote: > >> On Wed, Jun 17, 2015 at 5:41 AM, Branko Čibej wr

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

2015-06-18 Thread Evgeny Kotkov
Stefan Fuhrmann writes: > Sorry, my bad, I was wrong there. I only remembered that we had and still > have the pack/hotcopy race condition in 1.8 and then I saw the recursive > directory copy calls in the /trunk hotcopy code and had my false positive. > > You are absolutely right. We already copy

Re: svn commit: r1686181 - in /subversion/trunk/subversion/mod_dav_svn:./ reports/

2015-06-18 Thread Philip Martin
Bert Huijben writes: > Could you please add some documentation to this function on when to > pass an error_id and when to pass an apr_status. I was expecting that > they were the same thing and most callers pass neither (just 0). > > Is it possible to fold the few cases where we use an error id i

Re: [Patch] apr_file_path_merge returns incorrect truepath on certain 'short paths' on Windows

2015-06-18 Thread Branko Čibej
On 17.06.2015 15:53, Branko Čibej wrote: > > Thanks for the reminder! Will do. > > On 17 Jun 2015 12:37 pm, "Yann Ylavic" > wrote: > > On Wed, Jun 17, 2015 at 5:41 AM, Branko Čibej > wrote: > > > > I went ahead and committed to