RE: Queries about rep cache: get_shared_rep()

2015-05-26 Thread Bert Huijben
On Windows opening the file is sensitive to outside interactions and may trigger a retry loop. E.g. A virusscanber that scans every file before opening by hooking the OS. A filestat is +- a constant time operation that doesn't have these problems. So this really depends on how common all cases

Queries about rep cache: get_shared_rep()

2015-05-26 Thread Julian Foad
Index: subversion/libsvn_fs_fs/transaction.c === --- subversion/libsvn_fs_fs/transaction.c(revision 1681856) +++ subversion/libsvn_fs_fs/transaction.c(working copy) @@ -2243,12 +2243,14 @@ (representation_t **old_re cons

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-26 Thread Julian Foad
I (Julian Foad) wrote: > Just a couple of comments, from a quick read of the patch. > > +/** Flushes all available internal buffers in a generic @a stream. If > + * @sync is non-zero, it causes any buffered data to be written to the > + * underlying device (for example, to the disk for a file stre

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-26 Thread Julian Foad
Philip Martin wrote: > Evgeny Kotkov writes: >> I sketched this option in the attached patch. With this patch applied, we >> could rework the r1680819 fix like below. What do you think? > > Yes, that looks good. Just a couple of comments, from a quick read of the patch. +/** Flushes all availab

Re: svn commit: r1680819 - /subversion/trunk/subversion/libsvn_fs_fs/revprops.c

2015-05-26 Thread Philip Martin
Evgeny Kotkov writes: > I sketched this option in the attached patch. With this patch applied, we > could rework the r1680819 fix like below. What do you think? Yes, that looks good. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*