Re: reversible fingerprint comment in membuffer code

2015-05-19 Thread Stefan Fuhrmann
On Tue, May 19, 2015 at 8:25 PM, Philip Martin wrote: > Philip Martin writes: > > > Is this comment in cache-membuffer.c:combine_key correct? > > > > /* scramble key DATA. All of this must be reversible to prevent > key > >* collisions. So, we limit ourselves to xor and permutati

Re: Segfault in Perl bindings when commit touches a large number of files

2015-05-19 Thread James McCoy
On Tue, Apr 07, 2015 at 12:01:28PM +0100, Philip Martin wrote: > Roderich Schupp writes: > > > On Monday, March 23, 2015 at 1:35:49 PM UTC+1, Philip Martin wrote: > >> > >> This makes svn_swig_pl_from_md5 follow the same pattern as > >> svn_swig_pl_from_stream. I've committed this to trunk as r1

Re: JavaHL: ClientNotifyCallback reports unexpected kind "file" for symlinks

2015-05-19 Thread Branko Čibej
On 19.05.2015 15:59, Marc Strapetz wrote: > When recursively adding a directory "test" which contains another > directory "sub" and a symlink "sub.link" pointing to "sub", "sub.link" > is reported with kind=file where I would expect to receive > kind=symlink. The problem can be reproduced by follow

Re: reversible fingerprint comment in membuffer code

2015-05-19 Thread Philip Martin
Philip Martin writes: > Is this comment in cache-membuffer.c:combine_key correct? > > /* scramble key DATA. All of this must be reversible to prevent key >* collisions. So, we limit ourselves to xor and permutations. */ > data[1] = (data[1] << 27) | (data[1] >> 37); >

Re: svn commit: r1679228 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2015-05-19 Thread Ivan Zhakov
On 18 May 2015 at 02:25, Daniel Shahaf wrote: > Ivan Zhakov wrote on Fri, May 15, 2015 at 14:31:13 +0300: >> On 14 May 2015 at 17:20, Daniel Shahaf wrote: >> > i...@apache.org wrote on Wed, May 13, 2015 at 15:37:18 -: >> >> * subversion/tests/libsvn_fs/fs-test.c >> >> (freeze_and_commit): U

RE: JavaHL: ClientNotifyCallback reports unexpected kind "file" for symlinks

2015-05-19 Thread Bert Huijben
> -Original Message- > From: Marc Strapetz [mailto:marc.strap...@syntevo.com] > Sent: dinsdag 19 mei 2015 15:59 > To: dev@subversion.apache.org > Subject: JavaHL: ClientNotifyCallback reports unexpected kind "file" for > symlinks > > When recursively adding a directory "test" which conta

JavaHL: ClientNotifyCallback reports unexpected kind "file" for symlinks

2015-05-19 Thread Marc Strapetz
When recursively adding a directory "test" which contains another directory "sub" and a symlink "sub.link" pointing to "sub", "sub.link" is reported with kind=file where I would expect to receive kind=symlink. The problem can be reproduced by following code snippet, using quite recent 1.9 binar

reversible fingerprint comment in membuffer code

2015-05-19 Thread Philip Martin
Is this comment in cache-membuffer.c:combine_key correct? /* scramble key DATA. All of this must be reversible to prevent key * collisions. So, we limit ourselves to xor and permutations. */ data[1] = (data[1] << 27) | (data[1] >> 37); data[1] ^= data[0] & 0x;