Re: 1.9-rc1: Javahl compilation issue in RHEL3

2015-04-24 Thread Branko Čibej
On 25.04.2015 08:17, Alexander Thomas wrote: > On 04/25/2015 03:48 AM, Branko Čibej wrote: >> On 24.04.2015 10:46, Alexander Thomas wrote: >>> On 04/24/2015 12:47 PM, Branko Čibej wrote: Can you try compiling with the following patch, please, and report the results? ndings/javah

Re: 1.9-rc1: Javahl compilation issue in RHEL3

2015-04-24 Thread Alexander Thomas
On 04/25/2015 03:48 AM, Branko Čibej wrote: On 24.04.2015 10:46, Alexander Thomas wrote: On 04/24/2015 12:47 PM, Branko Čibej wrote: Can you try compiling with the following patch, please, and report the results? ndings/javahl Here is result after patching ... [[[ subversion/bindings/javahl

Re: [PATCH] small INSTALL file corrections

2015-04-24 Thread Bert Huijben
[I accidentally replied this in the wring thread on my phone] I'm guessing VC6 still works as that was used in many httpd builds until recently, but 2002 and 2003 are as far as I know unmaintained for a few releases and most likely broken. A patch to INSTALL would be welcome, but I just tried

RE: JavaHL RFE: ISVNRemote should provide API to retrieve a contentsof aspecific file

2015-04-24 Thread Bert Huijben
I tried to reply this in the recent INSTALL patch thread. But somehow starting things mixed up on my phone. Bert -Original Message- From: "Branko Čibej" Sent: ‎24-‎4-‎2015 22:44 To: "dev@subversion.apache.org" Subject: Re: JavaHL RFE: ISVNRemote should provide API to retrieve a content

Re: 1.9-rc1: Javahl compilation issue in RHEL3

2015-04-24 Thread Branko Čibej
On 24.04.2015 10:46, Alexander Thomas wrote: > On 04/24/2015 12:47 PM, Branko Čibej wrote: >> >> Can you try compiling with the following patch, please, and report the >> results? >> > > Here is result after patching ... > > [[[ > subversion/bindings/javahl/native/jniwrapper/jni_io_stream.cpp: In >

Re: JavaHL RFE: ISVNRemote should provide API to retrieve a contents of aspecific file

2015-04-24 Thread Branko Čibej
On 24.04.2015 20:26, Bert Huijben wrote: > I'm guessing VC6 still works as that was used in many httpd builds > until recently, but 2002 and 2003 are as far as I know unmaintained > for a few releases and most likely broken. > > A patch would be welcome, but I just tried to improve the patch a bit

RE: JavaHL RFE: ISVNRemote should provide API to retrieve a contents of aspecific file

2015-04-24 Thread Bert Huijben
I'm guessing VC6 still works as that was used in many httpd builds until recently, but 2002 and 2003 are as far as I know unmaintained for a few releases and most likely broken. A patch would be welcome, but I just tried to improve the patch a bit further. It might be easier to rework the entir

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-24 Thread Branko Čibej
Hi Marc, Just a quick note: your last msg jogged my memory and I think I know the root cause of the leak: improper JNI frame management within a loop. If I'm right, I can both fix the leak and remove the close-stream requirement I just added. On 24 Apr 2015 11:00 am, "Marc Strapetz" wrote: > On

JavaHL RFE: ISVNRemote should provide API to retrieve a contents of a specific file

2015-04-24 Thread Marc Strapetz
To allow users to browse through all contents of a file (as part of an interactive blame), it's necessary to have an efficient API to retrieve these file contents. AFAIU, the low-level file_rev_handler already provides this information via svn_txdelta_window_handler_t. Unfortunately, in Remote

Re: [PATCH] small INSTALL file corrections

2015-04-24 Thread Stefan Hett
Hi Bert, do you want me to attempt to update the INSTALL document and remove references to VC6/VS.NET (2002/2003) and provide a new patch with the changes against trunk? Regards, Stefan -Original Message- From: Stefan Hett [mailto:ste...@egosoft.com] Sent: woensdag 22 april 2015 16

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-24 Thread Marc Strapetz
On 24.04.2015 06:34, Branko Čibej wrote: On 22.03.2015 05:06, Branko Čibej wrote: On 21.03.2015 16:23, Branko Čibej wrote: On 19.03.2015 11:43, Marc Strapetz wrote: Attached example performs an endless series of remote status against the Subversion repository. When invoked with -Xmx24M, the VM

Re: 1.9-rc1: Javahl compilation issue in RHEL3

2015-04-24 Thread Alexander Thomas
On 04/24/2015 12:47 PM, Branko Čibej wrote: Can you try compiling with the following patch, please, and report the results? Here is result after patching ... [[[ subversion/bindings/javahl/native/jniwrapper/jni_io_stream.cpp: In function `svn_error_t* Javaglobal_stream_close_input(voi

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-24 Thread Julian Foad
Branko Čibej wrote: > There were two options for a fix: > > dispose of the object from the native code when it goes out of scope; or, > close the stream (causing an implicit disposal) from Java code. > > Picking the former would mean that the Java code must not close the stream, > since doi

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-24 Thread Branko Čibej
On 24.04.2015 10:15, Branko Čibej wrote: > There were two options for a fix: > > * dispose of the object from the native code when it goes out of > scope; or, > * close the stream (causing an implicit disposal) from Java code. > > Picking the former would mean that the Java code must not cl

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-24 Thread Branko Čibej
On 24.04.2015 09:56, Julian Foad wrote: > Hi Brane. > > I'm sure you would have first looked for ways to make this happen > automatically or not be needed. Is there anything you can report on > that front, for future reference? You mean, apart from in the log message? The root of the "problem" li

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-24 Thread Julian Foad
Hi Brane. I'm sure you would have first looked for ways to make this happen automatically or not be needed. Is there anything you can report on that front, for future reference? - Julian Branko Čibej wrote: > I have to say this was one of the more "interesting" bug-hunts in my not > entirely bor

Re: 1.9-rc1: Javahl compilation issue in RHEL3

2015-04-24 Thread Alexander Thomas
On 04/24/2015 12:47 PM, Branko Čibej wrote: if (contents != NULL) { Java::Env env; SVN_JAVAHL_CATCH(Java::Env(), ...); } if (contents != NULL) { Java::Env env; SVN_JAVAHL_CATCH(env,...); } This I tried earlier even before I tried upgrading GCC

Re: 1.9-rc1: Javahl compilation issue in RHEL3

2015-04-24 Thread Branko Čibej
On 24.04.2015 08:43, Alexander Thomas wrote: > Compiling 1.9.0-rc1 JavaHL in RHEL3 32bit with GCC version 3.2.3-53 > and libstdc++ version 5.0.3 fails with multiple compilation error in > javahl/native/EditorProxy.cpp. In addition to line number 213, line > 360 also fails with same error. > > Howev