Re: Implement major FSFS performance related changes in the experimental FSX format

Stefan Sperling wrote on Tue, Sep 30, 2014 at 19:30:06 +0200: > And I hope I won't be left alone when having to fix FSFSv7 corruption > should it ever occur in the wild ;-) I see the wink, but I'll answer seriously: if that's a concern, we might want to review the 'structure' file and code comment

Re: No no-op changes

Julian Foad wrote on Fri, Sep 19, 2014 at 16:34:04 +0100: > Andreas Stieger wrote: > >> Julian Foad wrote: > >>  Summary: > >>    * A "no-op change" is not a change. > >>    * Subversion should not report a "no-op change" as a "change". > >>    * We should bear this in mind when designing and revie

Re: Implement major FSFS performance related changes in the experimental FSX format

On Tue, Sep 30, 2014 at 05:45:48PM +0100, Julian Foad wrote: >   *** >   Who has reviewed this or intends to do so? And for what aspects -- overall >   design, compatibility/upgrade issues, threading issues, style, ...? >   *** I am not planning to review the FSFSv7 changes because the changes ar

Re: FSFS7 repository corruption during commit with background upgrade

On Tue, Sep 30, 2014 at 08:40:00PM +0400, Ivan Zhakov wrote: > I think there are the following viable options: > 1) make the svnadmin upgrade work properly for hot repositories > 2) do not enable log-addressing during svnadmin upgrade. > > I think (1) is almost impossible to implement since Subver

Re: Implement major FSFS performance related changes in the experimental FSX format

On 26 September 2014 20:34, Stefan Fuhrmann wrote: > On Fri, Sep 26, 2014 at 5:07 PM, Ivan Zhakov wrote: >> >> Mike, >> >> > At a minimum, the community needs to establish that this feature and its >> > side-effects are understood by more than just the one smart guy that >> > wrote >> > it and th

Re: FSFS7 repository corruption during commit with background upgrade

On 28 September 2014 22:28, Stefan Fuhrmann wrote: > On Fri, Sep 26, 2014 at 4:38 PM, Ivan Zhakov wrote: >> >> I was looking how fsfs upgrade code works and found particular fsfs7 >> log-addressing repository corruption bug: >> 0. Repository has 999 revisions. >> 1. Client begins committing some

Re: Implement major FSFS performance related changes in the experimental FSX format

C. Michael Pilato wrote: > On 09/26/2014 12:34 PM, Stefan Fuhrmann wrote: >> Not being Mike, here is my opinion anyway: I'm +1 on your proposal. > > I'm late to the party, but this all sounds great. I need to decide for myself: should *I* volunteer to review it? As a member of our community of S

Re: svn commit: r1628392 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

On Tue, Sep 30, 2014 at 2:35 PM, Branko Čibej wrote: > On 30.09.2014 12:51, stef...@apache.org wrote: > > Author: stefan2 > > Date: Tue Sep 30 10:51:51 2014 > > New Revision: 1628392 > > > > URL: http://svn.apache.org/r1628392 > > Log: > > Some of our FSFS config settings will cause malfunction i

Re: svn commit: r1628393 - /subversion/trunk/subversion/libsvn_fs_fs/index.c

On 30.09.2014 15:39, Stefan Fuhrmann wrote: > On Tue, Sep 30, 2014 at 2:40 PM, Branko Čibej > wrote: > > On 30.09.2014 13:10, stef...@apache.org > wrote: > > Author: stefan2 > > Date: Tue Sep 30 11:10:02 2014 > > New Revisi

Re: svn commit: r1628393 - /subversion/trunk/subversion/libsvn_fs_fs/index.c

On Tue, Sep 30, 2014 at 2:40 PM, Branko Čibej wrote: > On 30.09.2014 13:10, stef...@apache.org wrote: > > Author: stefan2 > > Date: Tue Sep 30 11:10:02 2014 > > New Revision: 1628393 > > > > URL: http://svn.apache.org/r1628393 > > Log: > > Fix / silence some integer conversion warnings. > > > > *

Re: Implement major FSFS performance related changes in the experimental FSX format

On 09/26/2014 12:34 PM, Stefan Fuhrmann wrote: > On Fri, Sep 26, 2014 at 5:07 PM, Ivan Zhakov > wrote: > > I think it would be fair to call a 'Consensus Approval' vote [1,2] > for leaving > the log-addressing feature in the trunk. In other words, it will >

Re: svn commit: r1628393 - /subversion/trunk/subversion/libsvn_fs_fs/index.c

On 30.09.2014 13:10, stef...@apache.org wrote: > Author: stefan2 > Date: Tue Sep 30 11:10:02 2014 > New Revision: 1628393 > > URL: http://svn.apache.org/r1628393 > Log: > Fix / silence some integer conversion warnings. > > * subversion/libsvn_fs_fs/index.c > (packed_stream_read): We know those ar

Re: svn commit: r1628392 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

On 30.09.2014 12:51, stef...@apache.org wrote: > Author: stefan2 > Date: Tue Sep 30 10:51:51 2014 > New Revision: 1628392 > > URL: http://svn.apache.org/r1628392 > Log: > Some of our FSFS config settings will cause malfunction if invalid > values were given. Thus, sanitize them before using them.

Re: svn commit: r1628093 - in /subversion/trunk/subversion/libsvn_fs_fs: index.c structure-indexes

On Tue, Sep 30, 2014 at 11:15 AM, Stefan Sperling wrote: > On Mon, Sep 29, 2014 at 07:18:05PM +0200, Stefan Fuhrmann wrote: > > On Sun, Sep 28, 2014 at 11:17 PM, Stefan Sperling > wrote: > > > > > On Sun, Sep 28, 2014 at 05:56:01PM -, stef...@apache.org wrote: > > > > Author: stefan2 > > > >

Re: svn commit: r1628093 - in /subversion/trunk/subversion/libsvn_fs_fs: index.c structure-indexes

On 30.09.2014 11:15, Stefan Sperling wrote: > On Mon, Sep 29, 2014 at 07:18:05PM +0200, Stefan Fuhrmann wrote: >> On Sun, Sep 28, 2014 at 11:17 PM, Stefan Sperling wrote: >> >>> On Sun, Sep 28, 2014 at 05:56:01PM -, stef...@apache.org wrote: Author: stefan2 Date: Sun Sep 28 17:56:01

Re: svn commit: r1628093 - in /subversion/trunk/subversion/libsvn_fs_fs: index.c structure-indexes

On Mon, Sep 29, 2014 at 07:18:05PM +0200, Stefan Fuhrmann wrote: > On Sun, Sep 28, 2014 at 11:17 PM, Stefan Sperling wrote: > > > On Sun, Sep 28, 2014 at 05:56:01PM -, stef...@apache.org wrote: > > > Author: stefan2 > > > Date: Sun Sep 28 17:56:01 2014 > > > New Revision: 1628093 > > > > > >