Re: svn commit: r1622937 -/subversion/trunk/subversion/libsvn_fs_fs/low_level.c

2014-09-07 Thread Stefan Fuhrmann
On Sun, Sep 7, 2014 at 10:44 AM, Branko Čibej wrote: > On 06.09.2014 23:54, Bert Huijben wrote: > > The dirent is canonical test is not the right test for fspaths. Dirents > are platform specific, while fspaths aren't. E.g. this breaks fspaths > containing ':' on Windows. > > I think there shou

Re: svn commit: r1622937 -/subversion/trunk/subversion/libsvn_fs_fs/low_level.c

2014-09-07 Thread Branko Čibej
On 06.09.2014 23:54, Bert Huijben wrote: > The dirent is canonical test is not the right test for fspaths. > Dirents are platform specific, while fspaths aren't. E.g. this breaks > fspaths containing ':' on Windows. > > I think there should be a valid fspath API for this use case, and if > not we s

Re: svn commit: r1622946 - /subversion/trunk/subversion/libsvn_fs_fs/rev_file.c

2014-09-07 Thread Branko Čibej
On 07.09.2014 00:01, stef...@apache.org wrote: > --- subversion/trunk/subversion/libsvn_fs_fs/rev_file.c (original) > +++ subversion/trunk/subversion/libsvn_fs_fs/rev_file.c Sat Sep 6 22:01:09 > 2014 > @@ -176,6 +176,9 @@ open_pack_or_rev_file(svn_fs_fs__revisio > >/* We failed