Re: svn commit: r1619413 - in /subversion/trunk/subversion: include/ libsvn_fs_fs/ libsvn_ra_local/ svnadmin/ svnlook/ tests/libsvn_fs_fs/

2014-08-21 Thread Evgeny Kotkov
>> Author: stefan2 >> Date: Thu Aug 21 14:35:05 2014 >> New Revision: 1619413 >> >> URL: http://svn.apache.org/r1619413 >> Log: >> Enforce the "everybody or nobody" restriction on revprop caching, i.e. >> either all processes (usually servers) or non must use revprop caching. >> >> This patch makes

Re: [RFC] Revision property caching and named atomics

2014-08-21 Thread Evgeny Kotkov
> We (Sergey Raevskiy and I) had some time to > examine the revision property caching feature, and there are some conclusions > that we would like to share. In brief, there are certain conditions when this > feature can actually *wreak havoc* in terms of the repository consistency and > possible

Re: svn commit: r1619476 - /subversion/trunk/subversion/libsvn_client/diff.c

2014-08-21 Thread Julian Foad
Bert Huijben wrote: >>  URL: http://svn.apache.org/r1619476 >>  Log: >>  Fix missing diff header lines when diffing a file that has only property >>  changes. >> >>  * subversion/libsvn_client/diff.c >>    (diff_content_changed): If the text diff was empty, assume no header was >>      printed (un

Re: [serf-dev] Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-21 Thread Lieven Govaerts
On Thu, Aug 21, 2014 at 5:47 PM, Justin Erenkrantz wrote: > On Thu, Aug 21, 2014 at 5:30 PM, Lieven Govaerts wrote: >> Attached patch implements a slightly different approach but I think >> it's a valid workaround for the problem. > > It may be useful to note why we register apps_ssl_info_callbac

RE: svn commit: r1619452 - in /subversion/trunk/subversion: libsvn_client/diff.c tests/cmdline/diff_tests.py

2014-08-21 Thread Bert Huijben
> -Original Message- > From: julianf...@apache.org [mailto:julianf...@apache.org] > Sent: donderdag 21 augustus 2014 17:48 > To: comm...@subversion.apache.org > Subject: svn commit: r1619452 - in /subversion/trunk/subversion: > libsvn_client/diff.c tests/cmdline/diff_tests.py > > Author:

Re: [serf-dev] Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-21 Thread Justin Erenkrantz
On Thu, Aug 21, 2014 at 5:30 PM, Lieven Govaerts wrote: > Attached patch implements a slightly different approach but I think > it's a valid workaround for the problem. It may be useful to note why we register apps_ssl_info_callback in the re-negotiate info callback. (It's because there can only

RE: svn commit: r1619476 - /subversion/trunk/subversion/libsvn_client/diff.c

2014-08-21 Thread Bert Huijben
> -Original Message- > From: julianf...@apache.org [mailto:julianf...@apache.org] > Sent: donderdag 21 augustus 2014 18:27 > To: comm...@subversion.apache.org > Subject: svn commit: r1619476 - > /subversion/trunk/subversion/libsvn_client/diff.c > > Author: julianfoad > Date: Thu Aug 21 1

Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-21 Thread Lieven Govaerts
On Thu, Aug 21, 2014 at 1:04 PM, Justin Erenkrantz wrote: > On Tue, Aug 19, 2014 at 2:53 PM, Lieven Govaerts wrote: >> However, when the client certificate is requested for a resource >> deeper in the repository, it's likely that say during a large >> checkout, many (pipelined) requests will alre

Re: svn commit: r1619413 - in /subversion/trunk/subversion: include/ libsvn_fs_fs/ libsvn_ra_local/ svnadmin/ svnlook/ tests/libsvn_fs_fs/

2014-08-21 Thread Evgeny Kotkov
> Author: stefan2 > Date: Thu Aug 21 14:35:05 2014 > New Revision: 1619413 > > URL: http://svn.apache.org/r1619413 > Log: > Enforce the "everybody or nobody" restriction on revprop caching, i.e. > either all processes (usually servers) or non must use revprop caching. > > This patch makes sure that

Re: svn commit: r1618138 - in /subversion/trunk/subversion: libsvn_fs_fs/caching.c libsvn_fs_fs/fs.c libsvn_fs_fs/fs.h libsvn_fs_fs/fs_fs.c libsvn_fs_fs/fs_fs.h libsvn_fs_fs/hotcopy.c libsvn_fs_fs/str

2014-08-21 Thread Branko Čibej
On 21.08.2014 15:08, Evgeny Kotkov wrote: >> @@ -2922,6 +2985,7 @@ test_list = [ None, >>fsfs_hotcopy_progress, >>fsfs_hotcopy_progress_with_revprop_changes, >>fsfs_hotcopy_progress_old, >> + freeze_same_uuid, >> ] >> >> >>

Re: Local diff of copied dir shows all props added

2014-08-21 Thread Julian Foad
Julian Foad wrote: > Bert Huijben wrote: >>  Julian Foad wrote: >>>   OK, seems to be fixed by copy-n-paste in r1619380. >> >>  Patch looks good. >> >>  How hard would it be to tweak your test for inclusion in the testsuite? > > Done in r1619393. > >>  I'm wondering when we introduced this prob

Re: svn commit: r1618138 - in /subversion/trunk/subversion: libsvn_fs_fs/caching.c libsvn_fs_fs/fs.c libsvn_fs_fs/fs.h libsvn_fs_fs/fs_fs.c libsvn_fs_fs/fs_fs.h libsvn_fs_fs/hotcopy.c libsvn_fs_fs/str

2014-08-21 Thread Evgeny Kotkov
>> @@ -2922,6 +2985,7 @@ test_list = [ None, >>fsfs_hotcopy_progress, >>fsfs_hotcopy_progress_with_revprop_changes, >>fsfs_hotcopy_progress_old, >> + freeze_same_uuid, >> ] >> >> >> It turns out that this test hangs with --s

Re: svn commit: r1618138 - in /subversion/trunk/subversion: libsvn_fs_fs/caching.c libsvn_fs_fs/fs.c libsvn_fs_fs/fs.h libsvn_fs_fs/fs_fs.c libsvn_fs_fs/fs_fs.h libsvn_fs_fs/hotcopy.c libsvn_fs_fs/str

2014-08-21 Thread Evgeny Kotkov
> @@ -2922,6 +2985,7 @@ test_list = [ None, >fsfs_hotcopy_progress, >fsfs_hotcopy_progress_with_revprop_changes, >fsfs_hotcopy_progress_old, > + freeze_same_uuid, > ] > > > It turns out that this test hangs with --server-min

Re: Local diff of copied dir shows all props added

2014-08-21 Thread Julian Foad
Bert Huijben wrote: > Julian Foad wrote: >>  OK, seems to be fixed by copy-n-paste in r1619380. > > Patch looks good. > > How hard would it be to tweak your test for inclusion in the testsuite? Done in r1619393. > I'm wondering when we introduced this problem... 1.7, 1.8, 1.0? > (Especially sin

Re: svn commit: r1618138 - in /subversion/trunk/subversion: libsvn_fs_fs/caching.c libsvn_fs_fs/fs.c libsvn_fs_fs/fs.h libsvn_fs_fs/fs_fs.c libsvn_fs_fs/fs_fs.h libsvn_fs_fs/hotcopy.c libsvn_fs_fs/str

2014-08-21 Thread Branko Čibej
On 15.08.2014 11:13, kot...@apache.org wrote: > @@ -2922,6 +2985,7 @@ test_list = [ None, >fsfs_hotcopy_progress, >fsfs_hotcopy_progress_with_revprop_changes, >fsfs_hotcopy_progress_old, > + freeze_same_uuid, > ] It turns o

RE: Local diff of copied dir shows all props added

2014-08-21 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: donderdag 21 augustus 2014 14:57 > To: Subversion Development > Cc: Bert Huijben > Subject: Re: Local diff of copied dir shows all props added > > OK, seems to be fixed by copy-n-paste in r1619380. Patc

Re: Local diff of copied dir shows all props added

2014-08-21 Thread Julian Foad
OK, seems to be fixed by copy-n-paste in r1619380. - Julian Julian Foad wrote: > Locally copying an (unmodified) dir with properties results in a wrong local > diff output. > > [[[ > $ svn cp tools/hook-scripts/mailer hs > A hs > > $ svn st > A  +    hs > > $ svn diff hs/ > ### (pri

Re: [PATCH] Add a configuration option to disable HTTP pipelining.

2014-08-21 Thread Justin Erenkrantz
On Tue, Aug 19, 2014 at 2:53 PM, Lieven Govaerts wrote: > However, when the client certificate is requested for a resource > deeper in the repository, it's likely that say during a large > checkout, many (pipelined) requests will already be sent by the client > before the request for the protected

Local diff of copied dir shows all props added

2014-08-21 Thread Julian Foad
Locally copying an (unmodified) dir with properties results in a wrong local diff output. [[[ $ svn cp tools/hook-scripts/mailer hs A hs $ svn st A  +    hs $ svn diff hs/ ### (prints a bunch of diff headers for unchanged files ### and then...) Index: hs ==

Re: svn commit: r1506545 [1/2] - in /subversion/branches/fsfs-improvements/subversion: include/ libsvn_fs_fs/

2014-08-21 Thread Branko Čibej
On 21.08.2014 11:33, Branko Čibej wrote: > On 21.08.2014 10:44, Evgeny Kotkov wrote: >> >> I am wondering, whether this is a portable way of comparing structs. > > It is not. The portable way is to use the '==' operator. ... in C++, that is ... memcmp is not even safe (in general) if the struct i

Re: svn commit: r1506545 [1/2] - in /subversion/branches/fsfs-improvements/subversion: include/ libsvn_fs_fs/

2014-08-21 Thread Branko Čibej
On 21.08.2014 10:44, Evgeny Kotkov wrote: >> Author: stefan2 >> Date: Wed Jul 24 13:24:44 2013 >> New Revision: 1506545 >> >> URL: http://svn.apache.org/r1506545 >> Log: >> On the fsfs-improvements branch: Finally switch to a new FSFS ID API. >> >> This replaces the previous string-based API with

Re: r1619122 (stsp) broke 'make swig-py'

2014-08-21 Thread Ben Reser
On 8/21/14 9:39 AM, Ben Reser wrote: > I have the "correct" fix but in so much as it makes things compile. But I > don't know that it makes the svn_wc_conflict_description2_t setters do > anything > useful. Writing a test now, so I should have it fixed shortly. I think this is the right fix for

Re: svn commit: r1506545 [1/2] - in /subversion/branches/fsfs-improvements/subversion: include/ libsvn_fs_fs/

2014-08-21 Thread Evgeny Kotkov
> Author: stefan2 > Date: Wed Jul 24 13:24:44 2013 > New Revision: 1506545 > > URL: http://svn.apache.org/r1506545 > Log: > On the fsfs-improvements branch: Finally switch to a new FSFS ID API. > > This replaces the previous string-based API with one that represents > IDs as quadruples of pairs o

Re: svn commit: r1568684 - in /subversion/trunk/subversion/libsvn_fs_x: cached_data.c changes.c fs_x.c id.c id.h index.c noderevs.c pack.c transaction.c tree.c verify.c

2014-08-21 Thread Evgeny Kotkov
> Author: stefan2 > Date: Sat Feb 15 21:31:04 2014 > New Revision: 1568684 > > URL: http://svn.apache.org/r1568684 > Log: > In FSX, unifify the concept of revision and transaction numbers and > call it a "change set". > > The mapping is trivial (revs == non-neg change sets, txns are negative > chan

Re: r1619122 (stsp) broke 'make swig-py'

2014-08-21 Thread Ben Reser
On 8/21/14 1:29 AM, Alexey Neyman wrote: > The new fields added in svn_wc.h cause the following errors: > > subversion/bindings/swig/python/svn_wc.c: In function > ‘_wrap_svn_wc_conflict_description2_t_prop_value_base_set’: > subversion/bindings/swig/python/svn_wc.c:8798: error: ‘_global_pool’ >