Re: Regression in bindings? 1.7/1.8 vs 1.6

2014-08-10 Thread Alexey Neyman
[CC'ing users@] On Sunday, August 10, 2014 08:35:44 PM Ben Reser wrote: > > Also, I think it would be a good idea to have the transaction-modifying > > functions return an error once the transaction reached the stage of > > pre-commit hooks from functions like svn_fs_change_node_prop() - to avoid

Re: Regression in bindings? 1.7/1.8 vs 1.6

2014-08-10 Thread Ben Reser
Side note this is in the pre-commit.tmpl that we create when you create a repository: [[[ # *** NOTE: THE HOOK PROGRAM MUST NOT MODIFY THE TXN, EXCEPT *** # *** FOR REVISION PROPERTIES (like svn:log or svn:author). *** ]]] On 8/10/14 7:36 PM, Alexey Neyman wrote: > So, the unversioned pr

Re: Regression in bindings? 1.7/1.8 vs 1.6

2014-08-10 Thread Alexey Neyman
Thanks Ben for a detailed answer. A few follow-up questions below: On Sunday, August 10, 2014 06:21:04 PM Ben Reser wrote: [... snip ...] > Here's the most important sentence form the book: > > "While hook scripts can do almost anything, there is one dimension in which > hook script authors shoul

Re: Regression in bindings? 1.7/1.8 vs 1.6

2014-08-10 Thread Ben Reser
On 8/10/14 5:19 PM, Alexey Neyman wrote: > - First, if the fs.change_node_prop was not intended for use in scripts, why > is > it exposed in bindings at all? Bindings are not intended just for writing hook scripts. Rather the bindings are intended to wrap the entirety of our C API (though someti

Re: Regression in bindings? 1.7/1.8 vs 1.6

2014-08-10 Thread Alexey Neyman
On Monday, August 11, 2014 01:55:41 AM Branko Čibej wrote: > On 10.08.2014 23:59, Alexey Neyman wrote: > > On Sunday, August 10, 2014 08:46:45 PM Stefan Sperling wrote: > > > On Sun, Aug 10, 2014 at 09:14:05AM -0700, Alexey Neyman wrote: > > > > On Saturday, August 09, 2014 10:50:11 PM Alexey Neyma

Re: svn commit: r1617148 - /subversion/branches/authzperf/subversion/libsvn_repos/authz.c

2014-08-10 Thread Branko Čibej
On 10.08.2014 21:17, stef...@apache.org wrote: > Author: stefan2 > Date: Sun Aug 10 19:17:53 2014 > New Revision: 1617148 [...] > @@ -973,7 +869,11 @@ add_complex_matches(lookup_state_t *stat >for (i = 0; i < patterns->nelts; ++i) > { >node_t *node = APR_ARRAY_IDX(patterns, i, node

Re: random-test failure on powerpc64le and x86_64

2014-08-10 Thread Branko Čibej
On 11.08.2014 01:38, Alan Modra wrote: > On Sat, Aug 09, 2014 at 08:08:21PM +0200, Branko Čibej wrote: >> The way to fix this is to make sure that the macro >> SVN_UNALIGNED_ACCESS_IS_OK gives the correct answer; and it's OK if >> that answer compiler-specific, not just platform-specific. In other

Re: Regression in bindings? 1.7/1.8 vs 1.6

2014-08-10 Thread Branko Čibej
On 10.08.2014 23:59, Alexey Neyman wrote: > > On Sunday, August 10, 2014 08:46:45 PM Stefan Sperling wrote: > > > On Sun, Aug 10, 2014 at 09:14:05AM -0700, Alexey Neyman wrote: > > > > On Saturday, August 09, 2014 10:50:11 PM Alexey Neyman wrote: > > > > > Hi Subversion developers, > > > > > > > >

Re: svn commit: r1617088 - in /subversion/branches/svn-auth-x509: subversion/include/ subversion/libsvn_fs_base/ subversion/libsvn_fs_base/bdb/ subversion/libsvn_fs_fs/ subversion/libsvn_fs_x/ subvers

2014-08-10 Thread Branko Čibej
On 10.08.2014 22:26, Ivan Zhakov wrote: > On 10 August 2014 20:47, Branko Čibej wrote: >> On 10.08.2014 13:00, i...@apache.org wrote: >> >> Author: ivan >> Date: Sun Aug 10 11:00:39 2014 >> New Revision: 1617088 >> >> URL: http://svn.apache.org/r1617088 >> Log: >> On svn-auth-x509 branch: Revert r

Re: random-test failure on powerpc64le and x86_64

2014-08-10 Thread Alan Modra
On Sat, Aug 09, 2014 at 08:08:21PM +0200, Branko Čibej wrote: > On 09.08.2014 15:55, Alan Modra wrote: > > Using current git sources compiled with gcc-4.9.1 or mainline gcc at > > -O3 results in failure of random-test. > > > > On powerpc64le we see > > PASS: random-test 1: random delta test > > sv

Re: Regression in bindings? 1.7/1.8 vs 1.6

2014-08-10 Thread Alexey Neyman
On Sunday, August 10, 2014 08:46:45 PM Stefan Sperling wrote: > On Sun, Aug 10, 2014 at 09:14:05AM -0700, Alexey Neyman wrote: > > On Saturday, August 09, 2014 10:50:11 PM Alexey Neyman wrote: > > > Hi Subversion developers, > > > > > > I am trying to migrate some scripts from 1.6 server that we'r

Re: svn commit: r1617088 - in /subversion/branches/svn-auth-x509: subversion/include/ subversion/libsvn_fs_base/ subversion/libsvn_fs_base/bdb/ subversion/libsvn_fs_fs/ subversion/libsvn_fs_x/ subvers

2014-08-10 Thread Ivan Zhakov
On 10 August 2014 20:47, Branko Čibej wrote: > On 10.08.2014 13:00, i...@apache.org wrote: > > Author: ivan > Date: Sun Aug 10 11:00:39 2014 > New Revision: 1617088 > > URL: http://svn.apache.org/r1617088 > Log: > On svn-auth-x509 branch: Revert r1616093 (svn_checksum_to_cstring_display2 > impleme

Re: Regression in bindings? 1.7/1.8 vs 1.6

2014-08-10 Thread Stefan Sperling
On Sun, Aug 10, 2014 at 09:14:05AM -0700, Alexey Neyman wrote: > On Saturday, August 09, 2014 10:50:11 PM Alexey Neyman wrote: > > Hi Subversion developers, > > > > I am trying to migrate some scripts from 1.6 server that we're currently > > running to a newer SVN version, and encountered somethin

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

2014-08-10 Thread Ben Reser
On 8/10/14 7:35 AM, Ben Reser wrote: > There shouldn't be any such certificate that's valid (at least that's using > the > Internet profile for X.509). There are two places that the signature > algorithm > are specified in the certificate. First in the Certificate sequence and again > in the TB

Re: svn commit: r1617108 - /subversion/branches/authzperf/subversion/libsvn_repos/authz.c

2014-08-10 Thread Branko Čibej
On 10.08.2014 18:57, Branko Čibej wrote: > On 10.08.2014 16:00, stef...@apache.org wrote: >> Author: stefan2 >> Date: Sun Aug 10 14:00:08 2014 >> New Revision: 1617108 > [...] >> (has_matching_rule): Update to new data model - just iterate over all >>ACEs and handle generi

Re: svn commit: r1617108 - /subversion/branches/authzperf/subversion/libsvn_repos/authz.c

2014-08-10 Thread Branko Čibej
On 10.08.2014 16:00, stef...@apache.org wrote: > Author: stefan2 > Date: Sun Aug 10 14:00:08 2014 > New Revision: 1617108 [...] > (has_matching_rule): Update to new data model - just iterate over all >ACEs and handle generic ACEs as well. Or just use svn_authz__acl_get_ac

Re: svn commit: r1617088 - in /subversion/branches/svn-auth-x509: subversion/include/ subversion/libsvn_fs_base/ subversion/libsvn_fs_base/bdb/ subversion/libsvn_fs_fs/ subversion/libsvn_fs_x/ subvers

2014-08-10 Thread Branko Čibej
On 10.08.2014 13:00, i...@apache.org wrote: > Author: ivan > Date: Sun Aug 10 11:00:39 2014 > New Revision: 1617088 > > URL: http://svn.apache.org/r1617088 > Log: > On svn-auth-x509 branch: Revert r1616093 (svn_checksum_to_cstring_display2 > implementation) -- it's out of the scope of svn-auth-x50

Re: Regression in bindings? 1.7/1.8 vs 1.6

2014-08-10 Thread Alexey Neyman
On Saturday, August 09, 2014 10:50:11 PM Alexey Neyman wrote: > Hi Subversion developers, > > I am trying to migrate some scripts from 1.6 server that we're currently > running to a newer SVN version, and encountered something that looks like > a bug: with 1.7/1.8 the fs.change_node_prop (in Pytho

RE: 1.7.18 up for testing/signing

2014-08-10 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: donderdag 7 augustus 2014 19:40 > To: 'Ben Reser'; 'Subversion Development' > Subject: RE: 1.7.18 up for testing/signing > > > > > -Original Message- > > From: Ben Reser [mailto:b...@reser.org] > > Sent:

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

2014-08-10 Thread Ben Reser
On 8/10/14 5:03 AM, Ivan Zhakov wrote: > I agree svn_checksum_to_cstring_display() is wrong name and the proper > solution to make separated (probably) optimized function for > converting checksum to canonical string representation. But this is > definitely out of scope of this branch. I've gone ah

Re: 1.7.18 up for testing/signing

2014-08-10 Thread Ben Reser
On 8/9/14 7:10 AM, Ben Reser wrote: > Voting stands now at 2 for Unix and 2 for Windows. Need one more vote from > both camps. Reminder, in order to release on the 11th we need votes in by the > 10th. So I'd really appreciate if we can get these votes in the next day. With Branko's vote we're n

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-10 Thread Evgeny Kotkov
Hi Stefan, > Thanks for having a the (missing) instance ID issue. > From initial review, I have 1 objection and 2 issues > that your patch does not address, yet. Thank you for reviewing this patch. I did my best, but I cannot really tell, which of these points are objections, and which of them a

Re: [VOTE] Merge svn-auth-x509 branch to trunk?

2014-08-10 Thread Ivan Zhakov
On 7 August 2014 21:03, Ben Reser wrote: > On 8/7/14 4:10 AM, Ivan Zhakov wrote: >> Several comments on branch code itself: >> 1. Probably it makes sense to do not deprecate >> svn_checksum_to_cstring_display() or have local x509 implementation >> for fingerprint formatting because we use >> svn_c

svn:auto-props on project root (was Re: svn commit: r1617096 - in /subversion/branches/svn-auth-x509/subversion: include/svn_x509.h libsvn_subr/x509.h libsvn_subr/x509info.c libsvn_subr/x509parse.c te

2014-08-10 Thread Ivan Zhakov
On 10 August 2014 15:34, wrote: > Author: ivan > Date: Sun Aug 10 11:34:16 2014 > New Revision: 1617096 > > URL: http://svn.apache.org/r1617096 > Log: > On svn-auth-x509 branch: > > * subversion/include/svn_x509.h > * subversion/libsvn_subr/x509.h > * subversion/libsvn_subr/x509info.c > * subvers

Re: [PATCH] Introduce per-instance filesystem UUIDs

2014-08-10 Thread Ivan Zhakov
On 8 August 2014 21:24, Evgeny Kotkov wrote: > Hi, > > I would like to propose a patch for the problem discussed in > http://svn.haxx.se/dev/archive-2014-04/0245.shtml > > Please see the details below. > > Log message: > [[[ > Avoid shared data clashes between repositories duplicated using 'hotcop

Re: 1.8.10 up for testing/signing

2014-08-10 Thread Branko Čibej
Summary: +1 to release Platform Mac OS X 10.9.4 Mavericks, build 13E28 Standard dependencies: Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn) APR 1.4.5 APR-Util 1.3.12 zlib 1.2.5 httpd 2.2.24 Python 2.7.5 Perl 5.16.2 Rub

Re: 1.7.18 up for testing/signing

2014-08-10 Thread Branko Čibej
Summary: +1 to release Platform Mac OS X 10.9.4 Mavericks, build 13E28 Standard dependencies: Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn) APR 1.4.5 APR-Util 1.3.12 zlib 1.2.5 httpd 2.2.24 Python 2.7.5 Perl 5.16.2 Rub