Re: Numbers encoding in FSFS log addressing indexes

2014-06-25 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Wed, Jun 25, 2014 at 20:33:42 +0200: > Why would someone quote the 7b/8b encoding scheme docs if not to use > it *against* the current code? To bring enough context into the discussion so that people who haven't read the f7 design docs may participate in it.

Re: Numbers encoding in FSFS log addressing indexes

2014-06-25 Thread Stefan Fuhrmann
On Wed, Jun 25, 2014 at 8:03 PM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Wed, Jun 25, 2014 at 17:34:43 +0200: > > On Wed, Jun 25, 2014 at 5:09 PM, Ivan Zhakov wrote: > > > > > Subversion 1.8 and before in general uses human readable decimal > > > format to store numbers in FSFS repositor

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Julian Foad
Hi Stefan. Compared with the extent of what you have achieved, this is a minor thing, so I don't want to go on about it much. However the point about readable code is not just whether it will need to be changed within the lifetime of "format 7" deployments, but about whether other software eng

Re: Numbers encoding in FSFS log addressing indexes

2014-06-25 Thread Stefan Fuhrmann
On Wed, Jun 25, 2014 at 8:07 PM, Daniel Shahaf wrote: > Daniel Shahaf wrote on Wed, Jun 25, 2014 at 18:03:24 +: > > Stefan Fuhrmann wrote on Wed, Jun 25, 2014 at 17:34:43 +0200: > > > On Wed, Jun 25, 2014 at 5:09 PM, Ivan Zhakov > wrote: > > > > Log addressing > > > > implementation on trunk

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Daniel Shahaf
Ivan Zhakov wrote on Wed, Jun 25, 2014 at 20:03:11 +0400: > On 25 June 2014 19:54, Stefan Fuhrmann wrote: > > On Wed, Jun 25, 2014 at 5:46 PM, Ivan Zhakov wrote: > >> > >> On 25 June 2014 19:24, Stefan Fuhrmann > >> wrote: > >> > On Wed, Jun 25, 2014 at 4:57 PM, Ivan Zhakov wrote: > >> >> > >>

Re: Numbers encoding in FSFS log addressing indexes

2014-06-25 Thread Daniel Shahaf
Daniel Shahaf wrote on Wed, Jun 25, 2014 at 18:03:24 +: > Stefan Fuhrmann wrote on Wed, Jun 25, 2014 at 17:34:43 +0200: > > On Wed, Jun 25, 2014 at 5:09 PM, Ivan Zhakov wrote: > > > Log addressing > > > implementation on trunk introduces new encoding for storing numbers in > > > indexes. Quoti

Re: Numbers encoding in FSFS log addressing indexes

2014-06-25 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Wed, Jun 25, 2014 at 17:34:43 +0200: > On Wed, Jun 25, 2014 at 5:09 PM, Ivan Zhakov wrote: > > > Subversion 1.8 and before in general uses human readable decimal > > format to store numbers in FSFS repositories on disk. > > > True. However, there are exceptions to that

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Stefan Fuhrmann
On Wed, Jun 25, 2014 at 6:19 PM, Julian Foad wrote: > Stefan Fuhrmann wrote: > > > Ivan Zhakov wrote: > >> @@ -1449,15 +1449,35 @@ write_revision_zero(svn_fs_t *fs) > >>>+SVN_ERR(svn_io_file_create_binary(path_revision_zero, > >>>+ "PLAIN\nEND\nENDREP\n" > >>>+

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Julian Foad
Stefan Fuhrmann wrote: > Ivan Zhakov wrote: >> @@ -1449,15 +1449,35 @@ write_revision_zero(svn_fs_t *fs) >>>+    SVN_ERR(svn_io_file_create_binary(path_revision_zero, >>>+                  "PLAIN\nEND\nENDREP\n" >>>+                  "id: 0.0.r0/2\n" >>>+                  "type: dir\n" >>>+      

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Ivan Zhakov
On 25 June 2014 19:54, Stefan Fuhrmann wrote: > On Wed, Jun 25, 2014 at 5:46 PM, Ivan Zhakov wrote: >> >> On 25 June 2014 19:24, Stefan Fuhrmann >> wrote: >> > On Wed, Jun 25, 2014 at 4:57 PM, Ivan Zhakov wrote: >> >> >> >> On 21 June 2014 17:15, wrote: >> >> > Author: stefan2 >> >> > Date: S

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Stefan Fuhrmann
On Wed, Jun 25, 2014 at 5:46 PM, Ivan Zhakov wrote: > On 25 June 2014 19:24, Stefan Fuhrmann > wrote: > > On Wed, Jun 25, 2014 at 4:57 PM, Ivan Zhakov wrote: > >> > >> On 21 June 2014 17:15, wrote: > >> > Author: stefan2 > >> > Date: Sat Jun 21 15:15:30 2014 > >> > New Revision: 1604421 > >>

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Ivan Zhakov
On 25 June 2014 19:24, Stefan Fuhrmann wrote: > On Wed, Jun 25, 2014 at 4:57 PM, Ivan Zhakov wrote: >> >> On 21 June 2014 17:15, wrote: >> > Author: stefan2 >> > Date: Sat Jun 21 15:15:30 2014 >> > New Revision: 1604421 >> > >> > URL: http://svn.apache.org/r1604421 >> > Log: >> > Append index d

Re: Numbers encoding in FSFS log addressing indexes

2014-06-25 Thread Stefan Fuhrmann
On Wed, Jun 25, 2014 at 5:09 PM, Ivan Zhakov wrote: > Subversion 1.8 and before in general uses human readable decimal > format to store numbers in FSFS repositories on disk. True. However, there are exceptions to that general rule. The index data uses the same basic encoding as we already use

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Stefan Fuhrmann
On Wed, Jun 25, 2014 at 4:57 PM, Ivan Zhakov wrote: > On 21 June 2014 17:15, wrote: > > Author: stefan2 > > Date: Sat Jun 21 15:15:30 2014 > > New Revision: 1604421 > > > > URL: http://svn.apache.org/r1604421 > > Log: > > Append index data to the rev data file instead of using separate files. >

Numbers encoding in FSFS log addressing indexes

2014-06-25 Thread Ivan Zhakov
Subversion 1.8 and before in general uses human readable decimal format to store numbers in FSFS repositories on disk. Log addressing implementation on trunk introduces new encoding for storing numbers in indexes. Quoting log addressing indexes format documentation [1] [[[ Encoding The fi

Re: svn commit: r1604421 - in /subversion/trunk: subversion/libsvn_fs_fs/ subversion/tests/cmdline/ subversion/tests/libsvn_fs_fs/ tools/server-side/svnfsfs/

2014-06-25 Thread Ivan Zhakov
On 21 June 2014 17:15, wrote: > Author: stefan2 > Date: Sat Jun 21 15:15:30 2014 > New Revision: 1604421 > > URL: http://svn.apache.org/r1604421 > Log: > Append index data to the rev data file instead of using separate files. > > This gives unpacked FSFS format 7 similar I/O characteristics and d

Re: JavaHL segfault on svn-x64-ubuntu-gcc buildbot

2014-06-25 Thread Philip Martin
Philip Martin writes: > Philip Martin writes: > >> I'm getting a SEGV in the JVM and it varies from run to run, two >> examples at the end. I tried r1603298 and r1603297 and those also SEGV. > > Looks like I made a mistake when building the older versions. I am now > seeing the SEGV with r1603

Re: JavaHL segfault on svn-x64-ubuntu-gcc buildbot

2014-06-25 Thread Philip Martin
Philip Martin writes: > I'm getting a SEGV in the JVM and it varies from run to run, two > examples at the end. I tried r1603298 and r1603297 and those also SEGV. Looks like I made a mistake when building the older versions. I am now seeing the SEGV with r1603306 but not with r1603305 or earli

Re: "BASE != HEAD" notifications

2014-06-25 Thread Daniel Shahaf
Branko Čibej wrote on Mon, Jun 23, 2014 at 11:21:49 +0200: > On 23.06.2014 10:54, Julian Foad wrote: > > Daniel Shahaf wrote: > > > >> One of my colleagues ran bisect but forgot to update back to HEAD after > >> finishing it. Another forgot to run 'svn up' in the morning before > >> starting > >>

Re: "BASE != HEAD" notifications

2014-06-25 Thread Daniel Shahaf
Julian Foad wrote on Mon, Jun 23, 2014 at 09:54:46 +0100: > Daniel Shahaf wrote: > > > One of my colleagues ran bisect but forgot to update back to HEAD after > > finishing it.  Another forgot to run 'svn up' in the morning before starting > > to edit a file, and later got conflicts > > > > Both

Re: "BASE != HEAD" notifications

2014-06-25 Thread Daniel Shahaf
Neels Hofmeyr wrote on Tue, Jun 24, 2014 at 00:59:33 +0200: > On Fri, Jun 20, 2014 at 12:06:22AM +, Daniel Shahaf wrote: > > One of my colleagues ran bisect but forgot to update back to HEAD after > > finishing it. Another forgot to run 'svn up' in the morning before starting > > to edit a fil

Re: JavaHL segfault on svn-x64-ubuntu-gcc buildbot

2014-06-25 Thread Philip Martin
Branko Čibej writes: > On 24.06.2014 21:48, Bert Huijben wrote: >> Hi, >> >> For some time the JavaHL tests on the svn-x64-ubuntu-gcc have been >> segfaulting. >> >> Looking at >> http://ci.apache.org/builders/svn-x64-ubuntu-gcc?numbuilds=200 >> >> It appears this bot started failing after e