[PATCH] New --diff-cmd (just for discussion)

2014-06-20 Thread Gabriela Gibson
Hi, After looking at Stefan and Ivan's very helpful critique, I had one of those 'may be good or may be terrible' ideas :) --invoke-diff-cmd is now absorbed into --diff-cmd (whilst preserving the old functionality and look), and most issues that Ivan and Stefan flagged up have been resolved th

AW: AW: [Patch] Fix for Issue #4395: 'svn upgrade' loses 1.6-client format files

2014-06-20 Thread Markus Schaber
Hi, Julian, Von: Julian Foad [mailto:julianf...@btopenworld.com] > Markus Schaber wrote: > > > Second iteration of my patch for fixing issue #4395. > > http://subversion.tigris.org/issues/show_bug.cgi?id=4395 > > The issue report is unclear. What are the 'from' and 'to' versions > meant to be? I

RE: svn commit: r1604188 - in /subversion/trunk/subversion/libsvn_fs_fs: low_level.c low_level.h transaction.c

2014-06-20 Thread Bert Huijben
> -Original Message- > From: s...@apache.org [mailto:s...@apache.org] > Sent: vrijdag 20 juni 2014 17:24 > To: comm...@subversion.apache.org > Subject: svn commit: r1604188 - in > /subversion/trunk/subversion/libsvn_fs_fs: low_level.c low_level.h > transaction.c > > Author: stsp > Date:

Re: Improving svn commit progress notification

2014-06-20 Thread Julian Foad
Ivan Zhakov wrote: >> [[[ >> $ svn ci wc -m "log msg" >> Sending        wc\foo >> Transmitting file data done >> Committing transaction... >> Committed revision 5. >> ]]] >> >> Also consider the out-of-date case: > > Committed in r1603388 and r1604179. I'm going to implement showing >

Re: AW: [Patch] Fix for Issue #4395: 'svn upgrade' loses 1.6-client format files

2014-06-20 Thread Julian Foad
Markus Schaber wrote: > Second iteration of my patch for fixing issue #4395. > http://subversion.tigris.org/issues/show_bug.cgi?id=4395 The issue report is unclear. What are the 'from' and 'to' versions meant to be? Is the repro recipe meant to check out with 1.6 and then upgrade to 1.7? As wr

[PATCH] On the 'ra-git' branch: update to libgit2 v0.21

2014-06-20 Thread Carlos Martín Nieto
Hi, libgit2 v0.21.0 was just released, and there have been some changes to the API. [[[ On the ‘ra-git’ branch: update to libgit2 v0.21 * subversion/libsvn_ra_git/ra_plugin.c: (split_url): remotes which are not in the config are now called anonymous. (do_git_fetch): pass NULL to git_remote_f

Re: Improving svn commit progress notification

2014-06-20 Thread Ivan Zhakov
On 17 June 2014 18:10, Stefan Sperling wrote: > On Tue, Jun 17, 2014 at 06:40:43PM +0400, Ivan Zhakov wrote: >> Anyone have any ideas on the UI in svn command line. I've prepared >> several versions:1. >> [...] >> >> Any other ideas? > > [[[ > $ svn ci wc -m "log msg" > Sendingwc\foo > Tra

AW: [Patch] Fix for Issue #4395: 'svn upgrade' loses 1.6-client format files

2014-06-20 Thread Markus Schaber
Hi, Second iteration of my patch for fixing issue #4395. http://subversion.tigris.org/issues/show_bug.cgi?id=4395 The fix itself is actually unchanged, but I added a test case which upgrades some working copies of different formats and checks whether the "format" and "entries" files are present a

Re: [Patch] Fix for Issue 3046: document security requirement for hook script arguments

2014-06-20 Thread Daniel Shahaf
Markus Schaber wrote on Fri, Jun 20, 2014 at 07:53:09 +: > Hi, > > See attached the third iteration of the patch. > > I did add coverage for the problems of arguments containing whitespace and > dashes, and did drop the example I got from the issue tracker, as it is > questionable whether t

Re: Subversion 1.9.0-dev FSFS performance tests

2014-06-20 Thread Ivan Zhakov
On 20 June 2014 12:33, Stefan Fuhrmann wrote: > On Thu, Jun 19, 2014 at 12:21 PM, Ivan Zhakov wrote: >> >> Hi, >> >> I've performed several FSFS performace tests using latest Subversion >> from trunk@r1602928. >> >> Please find results bellow. I'm also attaching results as a table in >> pdf for e

[Patch] Fix for Issue #4395: 'svn upgrade' loses 1.6-client format files

2014-06-20 Thread Markus Schaber
Hi, See attached my patch for fixing issue #4395. http://subversion.tigris.org/issues/show_bug.cgi?id=4395 [[[ Fix issue 4395 by not deleting the format and entries file when we upgrade from an 1.7 working copy. * subversion/libsvn_wc/upgrade.c (wipe_obsolete_files): Add a boolean parameter r

Re: Subversion 1.9.0-dev FSFS performance tests

2014-06-20 Thread Stefan Fuhrmann
On Thu, Jun 19, 2014 at 12:21 PM, Ivan Zhakov wrote: > Hi, > > I've performed several FSFS performace tests using latest Subversion > from trunk@r1602928. > > Please find results bellow. I'm also attaching results as a table in > pdf for easier reading. > > Environment: > Windows Server 2012 R2 (

Re: Subversion 1.9.0-dev FSFS performance tests

2014-06-20 Thread Ivan Zhakov
> Can you guys dig a little bit deeper here? Seems the performance > regression that Ivan is seeing deserves some more investigation. With > Ivan testing http: (and file:) on Windows, and Stefan testing svn: on > Linux (with different cache settings) it's hard to see where the > regression comes fr

Re: Subversion 1.9.0-dev FSFS performance tests

2014-06-20 Thread Ivan Zhakov
On 19 June 2014 17:06, Stefan Fuhrmann wrote: > Turn out that the ruby repo is something special > in that it has very deep histories of relatively few, > very small files combined with one huge changelog > file (the latter taking up ~75% of the repo). See > below for details. > > Also, please not

controversial issues in the tracker

2014-06-20 Thread Markus Schaber
Hi, While querying the issue tracker for bite-sized issues, I found the following ones which seem to be controversial. Maybe we should try to come to a consensus with each of them, either agreeing on a way of implementing them, or closing them as "won't fix". * 4162 make svn status fix times

Re: Subversion 1.9.0-dev FSFS performance tests

2014-06-20 Thread Johan Corveleyn
On Thu, Jun 19, 2014 at 5:06 PM, Stefan Fuhrmann wrote: > > Turn out that the ruby repo is something special > in that it has very deep histories of relatively few, > very small files combined with one huge changelog > file (the latter taking up ~75% of the repo). See > below for details. > > Also

[Patch] Fix for 2619 In post-commit hook template, suggest redirecting output of backgrounded jobs

2014-06-20 Thread Markus Schaber
Hi, See attached an attempt to fix issue 2619 (http://subversion.tigris.org/issues/show_bug.cgi?id=2619). [[[ Fix issue 2619 by explaining how to prevent svn from waiting for the background processes when one wants to spawn some work asynchroneously in the post-commit hook * subversion/libsvn

AW: [Patch] Fix for Issue 3046: document security requirement for hook script arguments

2014-06-20 Thread Markus Schaber
Hi, See attached the third iteration of the patch. I did add coverage for the problems of arguments containing whitespace and dashes, and did drop the example I got from the issue tracker, as it is questionable whether that specific example really is a problem. [[[ Fix issue 3046 by adding a