RE: [PATCH]: fix check-mime-type.pl for changes to 'svnlook proplist' output

2014-03-01 Thread Leo Davis
Hello, With more explanation of how properties work now, I agree that my patch is broken. I can implement a FSM to get the properties the right way. I had considered using XML output, but didn't want to add needless complexity, especially to old Perl code. I may have to rethink that if the ne

Re: svn commit: r1573106 - /subversion/trunk/build/ac-macros/compiler.m4

2014-03-01 Thread Philip Martin
Branko Čibej writes: > On 02.03.2014 03:15, Philip Martin wrote: >> I have no problem with your change but I don't believe a compiler would >> reject 'int main()'. The standard explicitly allows declarations >> "equivalent" to the two declarations you give and I believe 'int main()' >> qualifies

Re: svn commit: r1573106 - /subversion/trunk/build/ac-macros/compiler.m4

2014-03-01 Thread Branko Čibej
On 02.03.2014 03:15, Philip Martin wrote: > Branko Čibej writes: > >> However, the 'main' function is explicitly defined to have exactly two >> forms: >> >> int main(void); // or int main(); in C++ >> >> and >> >> int main(int argc, char *argv[]); >> >> The distinction is unimportant as fa

Re: svn commit: r1573106 - /subversion/trunk/build/ac-macros/compiler.m4

2014-03-01 Thread Philip Martin
Branko Čibej writes: > However, the 'main' function is explicitly defined to have exactly two > forms: > > int main(void); // or int main(); in C++ > > and > > int main(int argc, char *argv[]); > > The distinction is unimportant as far as the purpose of he configure > test is concerned; b

Byte order issue in FSFS 7

2014-03-01 Thread Philip Martin
There is a problem with the FNV1a checksums in format 7: the on-disk representation for big-endian systems, like SPARC, is different from that of little-endian systems, like x86. Both systems calculate the same checksum value, however the checksum code calls htonl() before returning the value to t

Re: Possible unitialised memory in FSX

2014-03-01 Thread Stefan Fuhrmann
On Wed, Feb 26, 2014 at 7:13 PM, Philip Martin wrote: > $ svnadmin create repo3 --fs-type fsx > $ m -f repo3/db/format > $ printf "1\nlayout sharded 2\n" > repo3/db/format > $ svn mkdir -mm file://`pwd`/repo3/A > Thanks for the reproduction recipe, Philip. > $ valgrind -q subversion/svnadmin/.

Re: crash in serf credential callback

2014-03-01 Thread Lieven Govaerts
Update: On Fri, Feb 28, 2014 at 12:45 PM, Lieven Govaerts wrote: > Hi, > > On Wed, Feb 26, 2014 at 8:18 PM, Stefan Kueng wrote: >> Hi, >> >> There's a crash happening in libsvn_ra_serf\util.c in the function >> svn_ra_serf__credentials_callback. There's a full crash dump available from >> here:

Re: svn commit: r1573106 - /subversion/trunk/build/ac-macros/compiler.m4

2014-03-01 Thread Branko Čibej
On 01.03.2014 11:05, Philip Martin wrote: > Branko Čibej writes: > >> On 28.02.2014 23:57, phi...@apache.org wrote: >>> Author: philip >>> Date: Fri Feb 28 22:57:24 2014 >>> New Revision: 1573106 >>> >>> + AC_LINK_IFELSE([AC_LANG_SOURCE([[int main(){return 0;}]])] >> This bit of source is not val

Re: svn commit: r1573106 - /subversion/trunk/build/ac-macros/compiler.m4

2014-03-01 Thread Philip Martin
Branko Čibej writes: > On 28.02.2014 23:57, phi...@apache.org wrote: >> Author: philip >> Date: Fri Feb 28 22:57:24 2014 >> New Revision: 1573106 >> >> + AC_LINK_IFELSE([AC_LANG_SOURCE([[int main(){return 0;}]])] > > This bit of source is not valid C90. It should be: int main(void){ ... } I don