Re: [PATCH]: fix check-mime-type.pl for changes to 'svnlook proplist' output

2014-02-28 Thread Ben Reser
On 2/28/14, 7:07 PM, Ben Reser wrote: > To that end I'd suggest that you implement a finite state machine to parse > this. With the following states: > > Starting state is fileheader. > > fileheader: Sanity check state by checking that line has zero whitespace at > start (tempting to use /^Prope

Re: Compiler flag detection doesn't work

2014-02-28 Thread Branko Čibej
On 01.03.2014 04:05, Branko Čibej wrote: > On 28.02.2014 22:55, Philip Martin wrote: >> In configure.as we attempt to add compiler flags by detecting whether or >> not the compiler accepts them. It's unreliable on Solaris: >> >> SVN_CFLAGS_ADD_IFELSE([-fno-inline]) >> SVN_CFLAGS_ADD_IFELSE

Re: [PATCH]: fix check-mime-type.pl for changes to 'svnlook proplist' output

2014-02-28 Thread Ben Reser
On 2/25/14, 4:21 PM, Leo Davis wrote: > I recently discovered that the old 'check-mime-type.pl' contrib script is I > had installed on my server was broken when using subversion 1.8.5. I looked > for an updated script in the 1.8.5 branch and in trunk and discovered the > script was also broken

Re: Compiler flag detection doesn't work

2014-02-28 Thread Branko Čibej
On 28.02.2014 22:55, Philip Martin wrote: > In configure.as we attempt to add compiler flags by detecting whether or > not the compiler accepts them. It's unreliable on Solaris: > > SVN_CFLAGS_ADD_IFELSE([-fno-inline]) > SVN_CFLAGS_ADD_IFELSE([-fno-omit-frame-pointer]) > > $ touch x.c > $

Re: svn_ra_get_file_revs2 vs. blame vs. FS API

2014-02-28 Thread Stefan Fuhrmann
On Sun, Feb 23, 2014 at 11:33 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > On Fri, Feb 21, 2014 at 6:01 PM, Julian Foad > wrote: > >> Stefan Fuhrmann wrote: >> > Julian Foad wrote: >> >> Stefan Fuhrmann wrote: >>> >>> >> or something very much like that. Those assumptions look lik

Compiler flag detection doesn't work

2014-02-28 Thread Philip Martin
In configure.as we attempt to add compiler flags by detecting whether or not the compiler accepts them. It's unreliable on Solaris: SVN_CFLAGS_ADD_IFELSE([-fno-inline]) SVN_CFLAGS_ADD_IFELSE([-fno-omit-frame-pointer]) $ touch x.c $ cc -c -fno-omit-frame-pointer x.c cc: Warning: Option -f

Re: C99 code in utf8proc.h

2014-02-28 Thread Philip Martin
Branko Čibej writes: > Philip: Can you try the Solaris build with r1573069, please? Complains about redefining the sized types, fails due to undefined 'bool', 'true' or 'false'. See r1573084. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1572363 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_repos/

2014-02-28 Thread Ben Reser
On 2/28/14, 1:07 PM, Stefan Fuhrmann wrote: > Things are much worse, in fact. The old implementation > would consider all property lists to be equal (FSFS only) > because the representation_t structs are empty except > for the txn_id. Hence, revision, offset and unifier would > always match between

Re: svn commit: r1572363 - in /subversion/trunk/subversion: include/ libsvn_fs/ libsvn_fs_base/ libsvn_fs_fs/ libsvn_fs_x/ libsvn_repos/

2014-02-28 Thread Stefan Fuhrmann
On Fri, Feb 28, 2014 at 4:40 AM, Ben Reser wrote: > First off I understand what you're trying to do and appreciate that! But > you're changing API behavior in ways that don't make sense to me. > I don't intend to make the functionality "worse". On 2/26/14, 4:15 PM, stef...@apache.org wrote: >

Re: C99 code in utf8proc.h

2014-02-28 Thread Branko Čibej
On 28.02.2014 21:20, Branko Čibej wrote: > On 28.02.2014 20:15, Philip Martin wrote: >> The introduction of utf8proc in libsvn_subr has brought this code in >> utf8proc.h: >> >> #ifdef _MSC_VER >> typedef signed char int8_t; >> typedef unsigned char uint8_t; >> typedef short int16_t; >> typedef uns

Re: C99 code in utf8proc.h

2014-02-28 Thread Branko Čibej
On 28.02.2014 20:15, Philip Martin wrote: > The introduction of utf8proc in libsvn_subr has brought this code in > utf8proc.h: > > #ifdef _MSC_VER > typedef signed char int8_t; > typedef unsigned char uint8_t; > typedef short int16_t; > typedef unsigned short uint16_t; > typedef int int32_t; > #ifd

Re: C99 code in utf8proc.h

2014-02-28 Thread Philip Martin
"Bert Huijben" writes: >> -Original Message- >> From: Philip Martin [mailto:philip.mar...@wandisco.com] >> Sent: vrijdag 28 februari 2014 20:15 >> To: dev@subversion.apache.org >> Subject: C99 code in utf8proc.h >> >> The introduction of utf8proc in libsvn_subr has brought this code in >

RE: C99 code in utf8proc.h

2014-02-28 Thread Bert Huijben
> -Original Message- > From: Philip Martin [mailto:philip.mar...@wandisco.com] > Sent: vrijdag 28 februari 2014 20:15 > To: dev@subversion.apache.org > Subject: C99 code in utf8proc.h > > The introduction of utf8proc in libsvn_subr has brought this code in > utf8proc.h: > > #ifdef _MSC_

C99 code in utf8proc.h

2014-02-28 Thread Philip Martin
The introduction of utf8proc in libsvn_subr has brought this code in utf8proc.h: #ifdef _MSC_VER typedef signed char int8_t; typedef unsigned char uint8_t; typedef short int16_t; typedef unsigned short uint16_t; typedef int int32_t; #ifdef _WIN64 #define ssize_t __int64 #else #define ssize_t int #

Re: svn commit: r1572762 - /subversion/trunk/build/ac-macros/serf.m4

2014-02-28 Thread Branko Čibej
On 28.02.2014 18:46, Ben Reser wrote: > On 2/28/14, 9:42 AM, C. Michael Pilato wrote: >> I think this follows from the problem of making both symbol-specific and >> top-level changes in a given file. Some folks do this: >> >> * build/ac-macros/serf.m4: >> Update the description. >> (some_func):

Re: svn commit: r1572762 - /subversion/trunk/build/ac-macros/serf.m4

2014-02-28 Thread Ben Reser
On 2/28/14, 9:42 AM, C. Michael Pilato wrote: > I think this follows from the problem of making both symbol-specific and > top-level changes in a given file. Some folks do this: > > * build/ac-macros/serf.m4: > Update the description. > (some_func): Twiddle the deeznits. > > Others dislike th

Re: svn commit: r1572762 - /subversion/trunk/build/ac-macros/serf.m4

2014-02-28 Thread C. Michael Pilato
On 02/28/2014 11:31 AM, Branko Čibej wrote: > On 27.02.2014 23:26, bre...@apache.org wrote: >> Author: breser >> Date: Thu Feb 27 22:26:46 2014 >> New Revision: 1572762 >> >> URL: http://svn.apache.org/r1572762 >> Log: >> Fix a number of problems with our serf configure detection. >> >> build/ac-ma

Re: svn commit: r1572762 - /subversion/trunk/build/ac-macros/serf.m4

2014-02-28 Thread Ben Reser
On 2/28/14, 8:31 AM, Branko Čibej wrote: > On 27.02.2014 23:26, bre...@apache.org wrote: >> Author: breser >> Date: Thu Feb 27 22:26:46 2014 >> New Revision: 1572762 >> >> URL: http://svn.apache.org/r1572762 >> Log: >> Fix a number of problems with our serf configure detection. >> >> build/ac-macro

Re: typofixes

2014-02-28 Thread Ben Reser
On 2/28/14, 8:12 AM, Veres Lajos wrote: > Sometimes I play with fixing typos in OS projects with my pet tool. > https://github.com/vlajos/misspell_fixer > I ran it against the svn source and found a few of them. > Generally I send a proper patch, but in this case there are too > many live function

Re: typofixes

2014-02-28 Thread Branko Čibej
On 28.02.2014 17:12, Veres Lajos wrote: > Hi, > > Sorry to interrupt. > Sometimes I play with fixing typos in OS projects with my pet tool. > https://github.com/vlajos/misspell_fixer > I ran it against the svn source and found a few of them. > Generally I send a proper patch, but in this case there

Re: svn commit: r1572762 - /subversion/trunk/build/ac-macros/serf.m4

2014-02-28 Thread Branko Čibej
On 27.02.2014 23:26, bre...@apache.org wrote: > Author: breser > Date: Thu Feb 27 22:26:46 2014 > New Revision: 1572762 > > URL: http://svn.apache.org/r1572762 > Log: > Fix a number of problems with our serf configure detection. > > build/ac-macros/serf.m4 > (): Update the description I've been

Re: svn commit: r1554800 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs_base/tree.c libsvn_fs_fs/tree.c libsvn_fs_x/tree.c

2014-02-28 Thread Julian Foad
> Author: stefan2 > Date: Thu Jan  2 13:16:43 2014 > New Revision: 1554800 > > URL: http://svn.apache.org/r1554800 Hi Stefan. I just noticed a few things in this commit... > Log: > Provide a path-based counterpart to svn_fs_base__id_compare. > Most code can now compare nodes directly (next commi

Re: crash in serf credential callback

2014-02-28 Thread Lieven Govaerts
Hi, On Wed, Feb 26, 2014 at 8:18 PM, Stefan Kueng wrote: > Hi, > > There's a crash happening in libsvn_ra_serf\util.c in the function > svn_ra_serf__credentials_callback. There's a full crash dump available from > here: > https://www.crash-server.com/Problem.aspx?ClientID=tsvn&ProblemID=58311 > >

Re: svn commit: r1572105 - in /subversion/trunk/subversion: svn/auth-cmd.c svn/cl.h svn/svn.c tests/cmdline/getopt_tests_data/svn--help_stdout tests/cmdline/getopt_tests_data/svn_help_stdout

2014-02-28 Thread Branko Čibej
On 27.02.2014 15:11, Stefan Sperling wrote: > On Thu, Feb 27, 2014 at 05:48:42PM +0400, Ivan Zhakov wrote: >> On 27 February 2014 17:37, Stefan Sperling wrote: >>> On Thu, Feb 27, 2014 at 02:06:38PM +0100, Stefan Sperling wrote: Also note that the help text mentions 'credentials' for this rea

Re: svn commit: r1572105 - in /subversion/trunk/subversion: svn/auth-cmd.c svn/cl.h svn/svn.c tests/cmdline/getopt_tests_data/svn--help_stdout tests/cmdline/getopt_tests_data/svn_help_stdout

2014-02-28 Thread Branko Čibej
On 27.02.2014 15:22, Bert Huijben wrote: > >> -Original Message- >> From: Stefan Sperling [mailto:s...@apache.org] >> Sent: donderdag 27 februari 2014 13:27 >> To: Bert Huijben >> Cc: dev@subversion.apache.org >> Subject: Re: svn commit: r1572105 - in /subversion/trunk/subversion: >> svn/au