On Wed, Feb 5, 2014 at 6:03 AM, Stefan Fuhrmann <
stefan.fuhrm...@wandisco.com> wrote:
> On Wed, Feb 5, 2014 at 4:02 AM, Branko Čibej wrote:
>
>> On 05.02.2014 03:10, Daniel Shahaf wrote:
>>
>> However, 'load --ignore-dates' has another use-case: preventing the "-r
>> {DATE} doesn't work as inte
On Wed, Feb 5, 2014 at 4:02 AM, Branko Čibej wrote:
> On 05.02.2014 03:10, Daniel Shahaf wrote:
>
> However, 'load --ignore-dates' has another use-case: preventing the "-r
> {DATE} doesn't work as intended" syndrome when loading a project's history
> into an existing repository.
>
>
> I would ar
On 05.02.2014 03:10, Daniel Shahaf wrote:
> However, 'load --ignore-dates' has another use-case: preventing the
> "-r {DATE} doesn't work as intended" syndrome when loading a project's
> history into an existing repository.
I would argue that this is an implementation bug, pure and simple. The
fac
C. Michael Pilato wrote on Tue, Feb 04, 2014 at 17:13:12 -0500:
> Didn't want to commit this directly just yet, given my somewhat
> disconnected attention level in the project as of late. Mostly looking
> for general feedback on the idea of the "sounds useful if it works" or
> "you *really* don't
Didn't want to commit this directly just yet, given my somewhat
disconnected attention level in the project as of late. Mostly looking
for general feedback on the idea of the "sounds useful if it works" or
"you *really* don't want to go there" variety, but deeper review is of
course welcome, too.
On 2/4/14, 8:26 AM, Stefan Sperling wrote:
> My current plan is to close the pager from a pool cleanup handler
> that is invoked when svn exits.
If that can be made to work reliably then that sounds great. Philip mentioned
that I was just tossing out another idea.
On Tue, Feb 04, 2014 at 08:13:37AM -0800, Ben Reser wrote:
> On 2/4/14, 1:14 AM, Philip Martin wrote:
> > We want some pattern that ensures __close is always called even when an
> > error is returned part way through. Either a pool cleanup or some sort
> > of __with_pager().
>
> Maybe a new SVN_E
On 2/4/14, 1:14 AM, Philip Martin wrote:
> We want some pattern that ensures __close is always called even when an
> error is returned part way through. Either a pool cleanup or some sort
> of __with_pager().
Maybe a new SVN_ERR macro?
SVN_ERR_PAGER(pager, func())
Which calls __close for you be
Sorry for the confusion - I mixed up branches.
I still feel a bit under the weather and forgot to
switch before merging & committing.
Should all be sorted out now.
-- Stefan^2.
Stefan Sperling wrote:
> On Tue, Feb 04, 2014 at 12:37:45PM +, Julian Foad wrote:
>> A pager for all commands when producing more than a screenful of
>> output -- fine.
>
> For this requirement, we need to count newlines and compare the
> result to the terminal window's height, so we can make
Ben Reser wrote on Mon, Feb 03, 2014 at 23:36:15 -0800:
> A lot of these will make a lot more sense if we can reasonably default to
> something like the FRSX option set that git passes to less by default. They
> do
> this by setting the LESS environment variable (if not already set and the
> pag
On Tue, Feb 04, 2014 at 01:07:56PM +, Philip Martin wrote:
> To get visible output with -F I need -X as well.
Thanks! -X makes it work for me, too.
On Tue, Feb 04, 2014 at 12:37:45PM +, Julian Foad wrote:
> A pager for all commands when producing more than a screenful of output --
> fine.
For this requirement, we need to count newlines and compare the
result to the terminal window's height, so we can make a decision
to launch a pager.
I
Stefan Sperling writes:
> And if I set PAGER="less -F" and run a command which produces output
> that does not fill the terminal completely I don't see any output at all.
> It seems the pager decides to exit immediately and we're writing to a
> dead fd instead of stdout. I'm not sure what to do h
Stefan Sperling wrote:
> Ben Reser wrote:
>> I suspect we should allow the pager to be used with all our commands,
>> though most of them should be disabled by default. I'd say the following
>> should be enabled by default:
>> blame
>> cat
>> diff
>> list
>> log
>> mergeinfo (at le
On 01/31/14 21:07, Ben Reser wrote:
In the meantime you can do the following to do the canonicalization:
if (SVN::Core::path_is_url($file)) {
$file = SVN::Core::uri_canonicalize($file);
} else {
$file = SVN::Core::dirent_canonicalize($file);
}
Thanks. IMHO this sample should be added to S
On Tue, Feb 4, 2014 at 6:12 AM, Branko Čibej wrote:
> I've changed my mind since and now firmly stand by the position that I
> never, ever suggested anything other than having a no-pager default. :)
>
> I'm also somewhat opposed to the idea of having pager configuration crud for
> each client subc
On 04.02.2014 12:18, Stefan Sperling wrote:
> Branko also told me during a conversation we had at FOSDEM that he
> believes we should never use a pager unless PAGER or SVN_PAGER is set.
> Branko occasionally tends to contradict himself though :)
Please ... it's called "looking at both sides of the
On Mon, Feb 03, 2014 at 11:36:15PM -0800, Ben Reser wrote:
> I suspect we should allow the pager to be used with all our commands, though
> most of them should be disabled by default. I'd say the following should be
> enabled by default:
> blame
> cat
> diff
> list
> log
> mergeinfo (at least with
On 04.02.2014 08:36, Ben Reser wrote:
> Branko convinced me that we should default to less (or more on
> Windows) if PAGER and SVN_PAGER is missing.
I've changed my mind since and now firmly stand by the position that I
never, ever suggested anything other than having a no-pager default. :)
I'm a
On Tue, Feb 04, 2014 at 09:14:52AM +, Philip Martin wrote:
> We want some pattern that ensures __close is always called even when an
> error is returned part way through. Either a pool cleanup or some sort
> of __with_pager(). Otherwise we have to ensure that none of the error
> pass bypass __
Ben Reser writes:
> On 2/3/14, 4:31 PM, Daniel Shahaf wrote:
>> Do you need to call __close if there is an error after __start? i.e.,
>> is there a state in which stdout will be printed to in the error path?
>
> Yes you do. Just try running svn diff against a non-working copy. You'll end
> up
22 matches
Mail list logo
