Re: [PATCH] fix for programmer error in path split text logic

2013-12-06 Thread Martin Furter
On 12/06/13 15:31, Philip Martin wrote: "Bert Huijben" writes: -Original Message- From: Eric Lubin [mailto:e...@lubin.us] Sent: donderdag 5 december 2013 21:17 To: dev@subversion.apache.org Subject: [PATCH] fix for programmer error in path split text logic [[[ * subversion/libsvn_s

Re: [PATCH] Do not ignore --bin parameter for svnrdump when running Python tests

2013-12-06 Thread Ben Reser
On 12/4/13 3:09 PM, Evgeny Kotkov wrote: > I've attached a patch to fix this issue. AFAIK [1], SVNKit does not include > the "j" version of svnrdump, so I did not touch the part of the setup that > handles the --use-jsvn option. Log message: > [[[ > Do not ignore --bin parameter for svnrdump when

RE: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-06 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: vrijdag 6 december 2013 18:24 > To: Stefan Fuhrmann > Cc: Bert Huijben; APR Developer List; Stefan Fuhrman; Philip Martin; > Subversion Development > Subject: Re: Race condition in APR_DECLARE_LATE_DLL_F

Re: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-06 Thread William A. Rowe Jr.
On Fri, 6 Dec 2013 16:44:52 +0100 Stefan Fuhrmann wrote: > On Fri, Dec 6, 2013 at 6:05 AM, William A. Rowe Jr. > wrote: > > > On Thu, 5 Dec 2013 15:01:05 +0100 > > "Bert Huijben" wrote: > > > > > I think the dll load function should be converted to a more stable > > > pattern, that properly han

Re: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-06 Thread Stefan Fuhrmann
On Fri, Dec 6, 2013 at 6:05 AM, William A. Rowe Jr. wrote: > On Thu, 5 Dec 2013 15:01:05 +0100 > "Bert Huijben" wrote: > > > I think the dll load function should be converted to a more stable > > pattern, that properly handles multiple threads. And perhaps we > > should just assume a few more NT

AW: [PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-06 Thread Markus Schaber
Hi, On closer analysis: The broken code still delivers the correct result, however, it always scans the whole files even if the first byte is different. Good catch. I feel fortified in my love to static analysis... Best regards Markus Schaber CODESYS® a trademark of 3S-Smart Software Solution

AW: [PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-06 Thread Markus Schaber
Hi, I'm the author of said code, and feel ashamed that this bug slipped in. The patch looks okay, and somehow I wonder that the code ever worked and passed the tests. :-( Best regards Markus Schaber CODESYS® a trademark of 3S-Smart Software Solutions GmbH Inspiring Automation Solutions 3S-S

Re: svn commit: r1548214 - in /subversion/trunk/subversion: libsvn_wc/externals.c libsvn_wc/update_editor.c libsvn_wc/wc-queries.sql libsvn_wc/wc_db.c libsvn_wc/wc_db.h libsvn_wc/wc_db_update_move.c t

2013-12-06 Thread Stefan Sperling
On Fri, Dec 06, 2013 at 03:18:27PM +0100, Bert Huijben wrote: > It is a check if dst_cp_relpath is the root node or any of its descendants. > The root of a move can never be shadowed (as the maximum op_depth of a node > is its own op depth... which is the move) Then why not use something like svn_

RE: svn commit: r1548214 - in /subversion/trunk/subversion: libsvn_wc/externals.c libsvn_wc/update_editor.c libsvn_wc/wc-queries.sql libsvn_wc/wc_db.c libsvn_wc/wc_db.h libsvn_wc/wc_db_update_move.c t

2013-12-06 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: vrijdag 6 december 2013 12:25 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1548214 - in /subversion/trunk/subversion: > libsvn_wc/externals.c libsvn_wc/update_editor.c libsvn_wc/wc-queries.sql > lib

Re: svn commit: r1548214 - in /subversion/trunk/subversion: libsvn_wc/externals.c libsvn_wc/update_editor.c libsvn_wc/wc-queries.sql libsvn_wc/wc_db.c libsvn_wc/wc_db.h libsvn_wc/wc_db_update_move.c t

2013-12-06 Thread Stefan Sperling
On Thu, Dec 05, 2013 at 05:36:58PM -, rhuij...@apache.org wrote: > Author: rhuijben > Date: Thu Dec 5 17:36:57 2013 > New Revision: 1548214 > > URL: http://svn.apache.org/r1548214 > Log: > Apply some minor preparing and correctness changes for the move logic in > libsvn_wc. > > This patch ad

Re: [PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-06 Thread Eric Lubin
Yes. I used a static checker developed at MIT called STACK that looks for unstable code due to undefined behavior. http://css.csail.mit.edu/stack/ Compilers pay close attention to the C standard, and are free to optimize out certain logical operations, where possible, in the case of undefined

Re: [PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-06 Thread Philip Martin
Eric Lubin writes: > [[[ > * subversion/libsvn_subr/io.c > (contents_three_identical_p): Fixed incorrect pointer check against NULL, > when the purpose was actually to check the value stored at that pointer for > true or false > ]]] Committed, thanks! I guess you found these via a compiler

Re: [PATCH] fix for programmer error in path split text logic

2013-12-06 Thread Philip Martin
"Bert Huijben" writes: >> -Original Message- >> From: Eric Lubin [mailto:e...@lubin.us] >> Sent: donderdag 5 december 2013 21:17 >> To: dev@subversion.apache.org >> Subject: [PATCH] fix for programmer error in path split text logic >> >> >> [[[ >> * subversion/libsvn_subr/path.c >>

RE: [PATCH] fix for programmer error in path split text logic

2013-12-06 Thread Bert Huijben
> -Original Message- > From: Eric Lubin [mailto:e...@lubin.us] > Sent: donderdag 5 december 2013 21:17 > To: dev@subversion.apache.org > Subject: [PATCH] fix for programmer error in path split text logic > > > [[[ > * subversion/libsvn_subr/path.c >(svn_path_splitext): Fixed ncorre