[PATCH] fix for programmer error in file equality check due to pointer logic

2013-12-05 Thread Eric Lubin
Index: subversion/libsvn_subr/io.c === --- subversion/libsvn_subr/io.c (revision 1548158) +++ subversion/libsvn_subr/io.c (working copy) @@ -4614,7 +4614,7 @@ contents_three_identical_p(svn_boolean_t *identica /* As long as a

[PATCH] fix for programmer error in path split text logic

2013-12-05 Thread Eric Lubin
Index: subversion/libsvn_subr/path.c === --- subversion/libsvn_subr/path.c (revision 1548158) +++ subversion/libsvn_subr/path.c (working copy) @@ -1252,7 +1252,7 @@ svn_path_splitext(const char **path_root, anything a

Re: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-05 Thread William A. Rowe Jr.
On Thu, 5 Dec 2013 15:01:05 +0100 "Bert Huijben" wrote: > I think the dll load function should be converted to a more stable > pattern, that properly handles multiple threads. And perhaps we > should just assume a few more NT functions to be alsways there > instead of loading them dynamically. T

Re: svn commit: r1547995 - in /subversion/trunk/subversion/svn: cl-log.h log-cmd.c mergeinfo-cmd.c

2013-12-05 Thread Ben Reser
On 12/5/13 2:09 PM, Ben Reser wrote: > The only complication it really presents is we have to allocate a > apr_array_header_t for merge_stack since the code in the log receiver doesn't > check it. Which actually would be really trivial to fix, I just didn't do it. Done in r1548334

Re: svn commit: r1547995 - in /subversion/trunk/subversion/svn: cl-log.h log-cmd.c mergeinfo-cmd.c

2013-12-05 Thread Ben Reser
On 12/5/13 12:30 PM, Ivan Zhakov wrote: > On 5 December 2013 06:20, wrote: >> Author: breser >> Date: Thu Dec 5 02:20:41 2013 >> New Revision: 1547995 >> >> URL: http://svn.apache.org/r1547995 >> Log: >> Make mergeinfo and log commands share the same log receiver implementation. >> > The only pr

Re: svn commit: r1547995 - in /subversion/trunk/subversion/svn: cl-log.h log-cmd.c mergeinfo-cmd.c

2013-12-05 Thread Ivan Zhakov
On 5 December 2013 06:20, wrote: > Author: breser > Date: Thu Dec 5 02:20:41 2013 > New Revision: 1547995 > > URL: http://svn.apache.org/r1547995 > Log: > Make mergeinfo and log commands share the same log receiver implementation. > The only problem with this change that 'svn log' has special be

Re: svn commit: r1547873 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2013-12-05 Thread Ben Reser
On 12/5/13 6:13 AM, Philip Martin wrote: > Stefan Sperling writes: > >> I think a hotcopy should be a drop-in replica in most respects, >> so it can be used easily in case the original repository is lost. >> If people want to change access permissions they should do so explicitly. > > I think ho

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-05 Thread Stefan Sperling
On Thu, Dec 05, 2013 at 02:30:23PM +, Philip Martin wrote: > Create a repository with group write access: > > (umask 002 ; svnadmin create repo) > > -rw-rw-r-- 1 pm pm 2 Dec 5 14:27 repo/db/current > -r--r--r-- 1 pm pm 115 Dec 5 14:27 repo/db/revs/0/0 > > Accidentally commit with umask d

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-05 Thread Philip Martin
Stefan Sperling writes: > I think we do want umask permissions. The rep-cache is written by > the server process, and there are cases where the group write bit > must be set for this to work (e.g. in some svn+ssh setups). In any > case the server process will have the proper umask configured, so

Re: svn commit: r1547873 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2013-12-05 Thread Philip Martin
Stefan Sperling writes: > I think a hotcopy should be a drop-in replica in most respects, > so it can be used easily in case the original repository is lost. > If people want to change access permissions they should do so explicitly. I think hotcopy should respect umask. > So copying permission

Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-05 Thread Bert Huijben
Hi, Someone in the Subversion team made our C tests run in parallel. With that our buildbot found a race condition in the Windows specific APR_DECLARE_LATE_DLL_FUNC() implementation. The current code is [[ #define APR_DECLARE_LATE_DLL_FUNC(lib, rettype, calltype, fn, ord, args, names) \

Re: svn commit: r1547873 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2013-12-05 Thread Stefan Sperling
On Thu, Dec 05, 2013 at 11:13:42AM +, Philip Martin wrote: > Stefan Sperling writes: > > > On Wed, Dec 04, 2013 at 07:53:40PM +0100, Stefan Sperling wrote: > >> On Wed, Dec 04, 2013 at 06:38:05PM -, phi...@apache.org wrote: > >> > @@ -1314,6 +1314,12 @@ svn_sqlite__hotcopy(const char *src

Re: svn commit: r1547866 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2013-12-05 Thread Stefan Sperling
On Wed, Dec 04, 2013 at 08:09:32PM +, Philip Martin wrote: > Philip Martin writes: > > > Stefan Sperling writes: > > > >> Oops, I pasted an old version of my diff. Here's the final one, > >> mostly with adjusted comments. > >> > >> Overall, I like your trick with creating an empty file bette

Re: svn commit: r1547873 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2013-12-05 Thread Philip Martin
Stefan Sperling writes: > On Wed, Dec 04, 2013 at 07:53:40PM +0100, Stefan Sperling wrote: >> On Wed, Dec 04, 2013 at 06:38:05PM -, phi...@apache.org wrote: >> > @@ -1314,6 +1314,12 @@ svn_sqlite__hotcopy(const char *src_path >> > svn_sqlite__db_t *dst_db; >> > sqlite3_backup *backu