Re: svn_mime_type_is_binary, libmagic and application/xml

2013-11-19 Thread Stefan Sperling
On Tue, Nov 19, 2013 at 11:23:39PM -0800, Ben Reser wrote: > I suggest that we do two things: > > 1) update our defaults for some mime types to be text > > 2) make which mime types are treated as text user configurable with a new > "text-types" category in ~/.subversion/config. Keys would be mi

svn_mime_type_is_binary, libmagic and application/xml

2013-11-19 Thread Ben Reser
Libmagic in some cases is flagging XML files as application/xml. Currently we do not treat application/xml as text. We have had a discussion about this in the past. The main argument against setting application/xml as text was that application/xml should be used for XML files that contain bin

Re: svn commit: r1543596 - in /subversion/trunk/subversion: libsvn_fs_x/changes.c libsvn_fs_x/noderevs.c libsvn_fs_x/reps.c libsvn_fs_x/string_table.c libsvn_subr/packed_data.c

2013-11-19 Thread Stefan Fuhrmann
On Tue, Nov 19, 2013 at 11:45 PM, Bert Huijben wrote: > > > > -Original Message- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: dinsdag 19 november 2013 23:17 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1543596 - in /subversion/trunk/subversion: > >

RE: svn commit: r1543596 - in /subversion/trunk/subversion: libsvn_fs_x/changes.c libsvn_fs_x/noderevs.c libsvn_fs_x/reps.c libsvn_fs_x/string_table.c libsvn_subr/packed_data.c

2013-11-19 Thread Bert Huijben
> -Original Message- > From: stef...@apache.org [mailto:stef...@apache.org] > Sent: dinsdag 19 november 2013 23:17 > To: comm...@subversion.apache.org > Subject: svn commit: r1543596 - in /subversion/trunk/subversion: > libsvn_fs_x/changes.c libsvn_fs_x/noderevs.c libsvn_fs_x/reps.c > lib

Re: Warning for missing sentinel arguments

2013-11-19 Thread Branko Čibej
On 19.11.2013 18:19, Julian Foad wrote: > Bert Huijben wrote: > >>> Bert Huijben wrote: Julian Foad wrote: > On 11/18/13 3:03 PM, Julian Foad wrote: >> The patch also changes SVN_NO_ERROR from "0" to "((svn_error_t*)0)". >> This has the side effect of detecting other mis-uses: I co

Re: [PATCH] initialize some variables in test to prevent -Wmaybe-uninitialized

2013-11-19 Thread Andreas Stieger
Hello, thanks for review. I get the comments about this being a rather unimportant warning as it's all test code, but still less warnings are better. Updated patch with TRUE/FALSE attached. [[[ * subversion/tests/libsvn_fs/fs-test.c (check_entry_present, check_entry_absent), * subversion/tests/

Re: 1.8.5 up for testing/signing

2013-11-19 Thread Johan Corveleyn
On Fri, Nov 15, 2013 at 3:13 AM, Ben Reser wrote: > The 1.8.5 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on November > 25th so please try a

Re: Warning for missing sentinel arguments

2013-11-19 Thread Julian Foad
Bert Huijben wrote: >> Bert Huijben wrote: >>> Julian Foad wrote: On 11/18/13 3:03 PM, Julian Foad wrote: > The patch also changes SVN_NO_ERROR from "0" to "((svn_error_t*)0)". > This has the side effect of detecting other mis-uses: I committed two such > fixes as http://svn.apach

Re: Using Sqlite in libsvn_wc towards Subversion 1.9++

2013-11-19 Thread Philip Martin
"Bert Huijben" writes: > As users that have upgraded to Sqlite 3.8.0 or later have found out our > design choices really affect performance on huge working copies: several > performance critical queries during operations such as commit, delete and > revert are now handled as a full table scan. T

The FLOSS 2013 survey

2013-11-19 Thread Gabriela Gibson
If you have contributed to a FLOSS project (such as Subversion), please take a moment to fill out this survey: http://floss2013.libresoft.es/ thanks, Gabriela

RE: Warning for missing sentinel arguments

2013-11-19 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: dinsdag 19 november 2013 13:23 > To: 'Julian Foad'; 'Ben Reser' > Cc: dev@subversion.apache.org > Subject: RE: Warning for missing sentinel arguments > > > > > -Original Message- > > From: Julian Foad [ma

RE: Warning for missing sentinel arguments

2013-11-19 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: dinsdag 19 november 2013 12:39 > To: Ben Reser > Cc: dev@subversion.apache.org > Subject: Re: Warning for missing sentinel arguments > > > On 11/18/13 3:03 PM, Julian Foad wrote: > > >> The patch also c

Re: Warning for missing sentinel arguments

2013-11-19 Thread Julian Foad
> On 11/18/13 3:03 PM, Julian Foad wrote: >> The patch also changes SVN_NO_ERROR from "0" to "((svn_error_t *)0)". This >> has the side effect of detecting other mis-uses: I committed two such fixes >> as http://svn.apache.org/r1543193 and http://svn.apache.org/r1543216 . I >> can't think of any n