Re: svn commit: r1527217 - /subversion/trunk/subversion/libsvn_fs_fs/transaction.c

2013-10-16 Thread Stefan Fuhrmann
On Sat, Sep 28, 2013 at 9:22 PM, Ivan Zhakov wrote: > On 28 September 2013 23:11, wrote: > > Author: stefan2 > > Date: Sat Sep 28 19:11:23 2013 > > New Revision: 1527217 > > > > URL: http://svn.apache.org/r1527217 > > Log: > > Skip move-related checks and updates in FSFS if moves are not suppor

Re: Branch 'invoke-diff-cmd-feature' is ready for half-way review

2013-10-16 Thread roderich.sch...@gmail.com
Looking over __create_custom_diff_cmd() in ./subversion/libsvn_subr/io.c: (1) The function doesn't strip double quotes, e.g. _create_custom_diff_cmd(..., /* cmd= */ "duff \"quoted\"", pool) will return the array { "duff", "\"quoted\"", NULL } You probably need to split cmd into tokens yourself

Re: Branch 'invoke-diff-cmd-feature' is ready for half-way review

2013-10-16 Thread Branko Čibej
On 16.10.2013 02:02, Gabriela Gibson wrote: > Hi, > > my branch is ready for a half-way review as the 'invoke-diff-cmd' > part is complete and adding the 'invoke-diff3-cmd' part would > only duplicate current errors. Why are we inventing a new syntax for variable substitutions? I wrote ages ago th

Re: Branch 'invoke-diff-cmd-feature' is ready for half-way review

2013-10-16 Thread roderich.sch...@gmail.com
On Wednesday, October 16, 2013 3:02:57 AM UTC+2, Gabriela Gibson wrote: > > The BRANCH-README file is here: > Substitutions: ;f1 original file ;f2 changed file "svn help diff" uses "old" and "new" (instead of "original" and "changed") to refer to t