Re: man pages for Subversion

2013-08-08 Thread James K. Lowden
On Thu, 8 Aug 2013 08:58:29 +0300 Daniel Shahaf wrote: > Perhaps this is a good time to point out that you were writing man > pages for 1.7, which is in "Security fixes only" mode. The supported > release is 1.8 and trunk (where new development should be targeted) > is 1.9. > > > 1. Keep the m

Re: Security patches release process

2013-08-08 Thread Ben Reser
On Thu, Aug 8, 2013 at 3:13 AM, Stefan Sperling wrote: > The assertion that packagers only use unmodified tarball is strange to > me. Packagers routinely patch upstream software to make it work on their > system or to backport security fixes. But usually the version number of > the upstream releas

Re: [PATCH] speed up svn_repos_authz_check_access

2013-08-08 Thread Ivan Zhakov
On Thu, Aug 8, 2013 at 11:04 PM, Ben Reser wrote: > On Thu, Aug 8, 2013 at 5:41 AM, Ivan Zhakov wrote: >> I don't see problem here: in worst scenario cache size would same as >> authorization file. So even for large authorization files memory usage >> will be limited. > > Yes I realize it's not e

Re: [PATCH] speed up svn_repos_authz_check_access

2013-08-08 Thread Ben Reser
On Wed, Aug 7, 2013 at 4:15 PM, Roderich Schupp wrote: > Actually I think that your worst case scenario should be illegal > and that Apache should close a connection when the user changes > between requests. I disagree that this sort of scenario should be disallowed. It's a fundamental feature o

Re: localisation: status, migration to pootle

2013-08-08 Thread Daniel Shahaf
Mattias Engdegård wrote on Thu, Aug 08, 2013 at 19:40:00 +0200: > 8 aug 2013 kl. 08.21 skrev Daniel Shahaf: > >> Mattias Engdegård wrote on Wed, Aug 07, 2013 at 23:43:36 +0200: >>> Sorry about the late reply; I rarely have time to read the >>> development >>> list. It seems unlikely that many tra

Re: localisation: status, migration to pootle

2013-08-08 Thread Mattias Engdegård
8 aug 2013 kl. 08.21 skrev Daniel Shahaf: Mattias Engdegård wrote on Wed, Aug 07, 2013 at 23:43:36 +0200: Sorry about the late reply; I rarely have time to read the development list. It seems unlikely that many translators do - how are they notified about the need to update their translation

Re: SVN update of child ignores files if preceded by update --depth immediates

2013-08-08 Thread Philip Martin
Mihai Danila writes: > With Subversion 1.6.5, 1.6.13, and I believe Subversion 1.7 also, I noticed > the following bug, which I first asked about on StackOverflow about and had > independently confirmed ( > http://stackoverflow.com/questions/18114102/strange-svn-behavior-missing-files-when-using-

SVN update of child ignores files if preceded by update --depth immediates

2013-08-08 Thread Mihai Danila
With Subversion 1.6.5, 1.6.13, and I believe Subversion 1.7 also, I noticed the following bug, which I first asked about on StackOverflow about and had independently confirmed ( http://stackoverflow.com/questions/18114102/strange-svn-behavior-missing-files-when-using-depth-immediates-followed-by-de

Re: [PATCH] add 'svn:use-commit-times' property

2013-08-08 Thread Daniel Shahaf
Masaru Tsuchiyama wrote on Thu, Aug 08, 2013 at 23:13:54 +0900: >>>" before it is modified. Makes the working copy file >>> read-only¥n" >>>" when it is not locked. Use 'svn propdel svn:needs-lock >>> PATH...'¥n" >>>" to clear.¥n" >>> + "svn:use-co

Re: [PATCH] add 'svn:use-commit-times' property

2013-08-08 Thread Masaru Tsuchiyama
+/** The value to force the executable property to when set. + * + * @deprecated Provided for backward compatibility with the 1.4 API. + * Use @c SVN_PROP_BOOLEAN_TRUE instead. removed this. Fix line breaks, wrap to 80 columns. fixed this. Please make the comments say more than the struct

Re: [PATCH] add support for svnrdump to svn-backup-dumps.py

2013-08-08 Thread C. Michael Pilato
On 08/08/2013 09:40 AM, Daniel Shahaf wrote: > On Thu, Aug 08, 2013 at 09:26:09AM -0400, C. Michael Pilato wrote: >> This tells the options parser that there are no command-line options >> which follow, which would keep self.__repospath from being treated as an >> option in the unlikely scenario th

Re: [PATCH] add support for svnrdump to svn-backup-dumps.py

2013-08-08 Thread Daniel Shahaf
On Thu, Aug 08, 2013 at 09:26:09AM -0400, C. Michael Pilato wrote: > This tells the options parser that there are no command-line options > which follow, which would keep self.__repospath from being treated as an > option in the unlikely scenario that it begins with a hyphen. Right. 99% of the ti

Re: [PATCH] add support for svnrdump to svn-backup-dumps.py

2013-08-08 Thread C. Michael Pilato
On 08/08/2013 09:17 AM, Masaru Tsuchiyama wrote: >> Also, it'd be good practice to pass "--" in front of self.__repospath, >> but that >> appears to be a preexisting problem in the code (i.e., not introduced >> by your >> patch). > > What is the purpose in passing "--"? This tells the options par

Re: [PATCH] add support for svnrdump to svn-backup-dumps.py

2013-08-08 Thread Daniel Shahaf
Masaru Tsuchiyama wrote on Thu, Aug 08, 2013 at 22:17:05 +0900: > > > +cmd = [ self.__svnadmin_path, "dump", > > > +"--incremental", "-r", revparam, > self.__repospath ] > > > > That doesn't look right. If self.__repospath can be a local path to a > > repository r

Re: [PATCH] add support for svnrdump to svn-backup-dumps.py

2013-08-08 Thread Masaru Tsuchiyama
> Typo, "revision_regex" fixed at the attached patch. > > +cmd = [ self.__svnadmin_path, "dump", > > +"--incremental", "-r", revparam, self.__repospath ] > > That doesn't look right. If self.__repospath can be a local path to a > repository root, you shouldn'

Re: [PATCH] speed up svn_repos_authz_check_access

2013-08-08 Thread Ivan Zhakov
On Thu, Aug 8, 2013 at 1:08 AM, Ben Reser wrote: > On Wed, Aug 7, 2013 at 1:03 PM, Roderich Schupp > wrote: >> Err... the cache apr_hash_t by construction cannot contain keys (i.e.paths) >> that are not in the authz file also, so is bounded by the size of the >> corresponding svn_config_t. In fac

Re: svn commit: r1511603 - /subversion/trunk/subversion/svnadmin/svnadmin.c

2013-08-08 Thread Ivan Zhakov
On Thu, Aug 8, 2013 at 11:24 AM, wrote: > Author: danielsh > Date: Thu Aug 8 07:24:25 2013 > New Revision: 1511603 > > URL: http://svn.apache.org/r1511603 > Log: > Follow-up to r1506966: > > * subversion/svnadmin/svnadmin.c > (repos_notify_handler): Don't use the length of an English string wh

Re: fsfs-improvements branch complete

2013-08-08 Thread Philip Martin
Stefan Fuhrmann writes: > After two weeks now, I finally completed the fsfs format 6 refactoring > and improvement work on said branch. Please review. See also > http://svn.haxx.se/dev/archive-2013-07/0385.shtml for the "split up > fs_fs.c" part of it. > > If there are no objections, I will merge

Re: Security patches release process

2013-08-08 Thread Stefan Sperling
On Thu, Aug 08, 2013 at 12:51:06PM +0300, Daniel Shahaf wrote: > Ben Reser wrote on Thu, Aug 08, 2013 at 00:58:50 -0700: > > On Wed, Aug 7, 2013 at 3:49 AM, Justin Erenkrantz > > wrote: > > > I'm okay with choice 3 - however, the "release a signed .diff" should also > > > include a full release -

Re: Security patches release process

2013-08-08 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Aug 08, 2013 at 12:51:06 +0300: > (a) - Unidiffs in /repos/private/pmc/subversion > (b) - Branch in /repos/asf/subversion/shadow > (c) - Branch in /repos/private/pmc/subversion/shadow > (d) - Branch in fossil/bzr/hg/git > (e) - (We could ask infra to 'zfs clone' the asf

Re: Security patches release process

2013-08-08 Thread Daniel Shahaf
Ben Reser wrote on Thu, Aug 08, 2013 at 00:58:50 -0700: > On Wed, Aug 7, 2013 at 3:49 AM, Justin Erenkrantz > wrote: > > I'm okay with choice 3 - however, the "release a signed .diff" should also > > include a full release - including whatever normal things we include with a > > standard release

Re: Security patches release process

2013-08-08 Thread Ben Reser
On Wed, Aug 7, 2013 at 3:49 AM, Justin Erenkrantz wrote: > I'm okay with choice 3 - however, the "release a signed .diff" should also > include a full release - including whatever normal things we include with a > standard release process. If 1.8.(x+1) is *only* available as a diff > against 1.8.

Re: man pages for Subversion

2013-08-08 Thread Stefan Sperling
On Thu, Aug 08, 2013 at 09:20:16AM +0200, Alan Barrett wrote: > On Wed, 07 Aug 2013, James K. Lowden wrote: > >If HTML is desired, there are a couple of options. I haven't used it, > >but troff2page sounds nice. > >http://www.ccs.neu.edu/home/dorai/troff2page/index.html#node_toc_start > >GNU troff

Re: man pages for Subversion

2013-08-08 Thread Alan Barrett
On Wed, 07 Aug 2013, James K. Lowden wrote: If HTML is desired, there are a couple of options. I haven't used it, but troff2page sounds nice. http://www.ccs.neu.edu/home/dorai/troff2page/index.html#node_toc_start GNU troff also supports HTML output, but I haven't had great luck with it. For re