Re: Review of invoke-diff-cmd-feature branch

2013-06-10 Thread Daniel Shahaf
Gabriela Gibson wrote on Mon, Jun 10, 2013 at 23:39:45 +0100: > On 6/10/13, Daniel Shahaf wrote: > > >> Index: subversion/include/svn_client.h > >> === > >> --- subversion/include/svn_client.h (revision 1484305) > >> +++ subversion/i

Re: Review of invoke-diff-cmd-feature branch

2013-06-10 Thread Gabriela Gibson
On 6/10/13, Daniel Shahaf wrote: >> Index: subversion/include/svn_client.h >> === >> --- subversion/include/svn_client.h (revision 1484305) >> +++ subversion/include/svn_client.h (working copy) >> @@ -2988,8 +2988,8 @@ svn_client_bla

Svn Hackathon - Web Talks and Live Interviews

2013-06-10 Thread Julian Foad
Hi, devs. I'm currently at the Svn Hackathon hosted by elego Software Solutions in Berlin, and a few of us are going to be giving web talks about Svn over the next three days. I hope you'll log in and listen to whichever ones interest you. The PDF with abstracts of the talks is at http://www.el

Automatic tree conflicts resolution during svn update

2013-06-10 Thread Danil Shopyrin
The current draft of the Subversion 1.8 Release Notes announces automatic tree conflicts resolution for locally moved files and directories. But it seems that this feature does not actually work in RC2. The detailed reproduction script is given below. I think that we should either drop this feature

AW: svn commit: r1491445 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2013-06-10 Thread Markus Schaber
Hi, On Mon, Jun 10, 2013 at 01:38:48PM -, danie...@apache.org wrote: >> Author: danielsh >> Date: Mon Jun 10 13:38:48 2013 >> New Revision: 1491445 >> >> URL: http://svn.apache.org/r1491445 >> Log: >> * subversion/libsvn_fs_fs/fs_fs.c: Restore linebreak that was removed, I >> suspect by accid

Re: svn commit: r1491445 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2013-06-10 Thread Daniel Shahaf
On Mon, Jun 10, 2013 at 01:38:48PM -, danie...@apache.org wrote: > Author: danielsh > Date: Mon Jun 10 13:38:48 2013 > New Revision: 1491445 > > URL: http://svn.apache.org/r1491445 > Log: > * subversion/libsvn_fs_fs/fs_fs.c: Restore linebreak that was removed, I > suspect by accident. > It

Long delta chains edge case revived

2013-06-10 Thread Daniel Shahaf
>From fs_fs.c:choose_delta_base(): svn_boolean_t maybe_shared_rep = FALSE; if (!props && base->data_rep && svn_fs_fs__id_rev(base->id) > base->data_rep->revision) maybe_shared_rep = TRUE; The third conjunct was intended to answer the question "Is base->data_rep a shared rep", but t

Re: svn commit: r1418963 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2013-06-10 Thread Stefan Fuhrmann
On Mon, Jun 10, 2013 at 1:23 PM, Daniel Shahaf wrote: > On Sun, Dec 09, 2012 at 02:05:48PM -, stef...@apache.org wrote: > > Author: stefan2 > > Date: Sun Dec 9 14:05:47 2012 > > New Revision: 1418963 > > > > URL: http://svn.apache.org/viewvc?rev=1418963&view=rev > > Log: > > Representation s

Re: svn commit: r1418963 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2013-06-10 Thread Daniel Shahaf
On Sun, Dec 09, 2012 at 02:05:48PM -, stef...@apache.org wrote: > Author: stefan2 > Date: Sun Dec 9 14:05:47 2012 > New Revision: 1418963 > > URL: http://svn.apache.org/viewvc?rev=1418963&view=rev > Log: > Representation sharing interacts badly with our skip-delta algorithm > as the former po

Re: svn commit: r1490326 - /subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py

2013-06-10 Thread Daniel Shahaf
bre...@apache.org wrote on Thu, Jun 06, 2013 at 15:36:09 -: > Author: breser > Date: Thu Jun 6 15:36:08 2013 > New Revision: 1490326 > > URL: http://svn.apache.org/r1490326 > Log: > svnpubsub: Remove version header that was uninitentionally added in r1490045. > > [in tools/server-side/svnpub

Re: Review of invoke-diff-cmd-feature branch

2013-06-10 Thread Daniel Shahaf
Gabriela Gibson wrote on Tue, Jun 04, 2013 at 09:56:57 +0100: > Hi, > > I hope I've resolved most issues, here are ones I need to ask about: > > > Index: subversion/include/svn_client.h > === > --- subversion/include/svn_client.h (r