Re: [PATCH] SVN_UNALIGNED_ACCESS_IS_OK for ppc

2013-05-21 Thread Ben Reser
On Thu, May 16, 2013 at 2:27 PM, Branko Čibej wrote: > On 16.05.2013 23:12, Mattias Engdegård wrote: >> [[[ >> * subversion/include/svn_types.h: >> Set SVN_UNALIGNED_ACCESS_IS_OK for PowerPC. >> ]]] > > At first I thought, "that can't be right!" but it turns out that it is > ... somewhat. Only i

Re: over-tolerant code in run_file_install?

2013-05-21 Thread Mattias Engdegård
21 maj 2013 kl. 12.02 skrev Bert Huijben: Before we had a single DB we stored the workqueue items per directory. (We had a wc.db per directory, just like the old entries). If the workqueue contained an item that specified to install an item in the directory we could safely assume that the

Re: over-tolerant code in run_file_install?

2013-05-21 Thread Mattias Engdegård
20 maj 2013 kl. 22.41 skrev Daniel Shahaf: Have you checked IRC logs for the day r1142088 was committed on? Thanks for the reference. As far as I can make out from the conversation, the change was made in order to handle working copies whose directory structure had been trashed by the user

Re: Review of invoke-diff-cmd-feature branch

2013-05-21 Thread Gabriela Gibson
Because there is no option object that we can query from within io.c, diff.c and other places, we have to add extra courier parameters for every command line option we wish to add, in a number of places. We have 4 (potential) diff commands -- diff-cmd, diff3-cmd, invoke-diff-cmd and invoke-diff3

Re: svn commit: r1461775 - /subversion/trunk/subversion/include/svn_error.h

2013-05-21 Thread Ivan Zhakov
On Mon, May 20, 2013 at 6:24 PM, Philip Martin wrote: > Ivan Zhakov writes: > Are you saying that VC10 produces something different? >>> Yes, with VC10 I get "assertion failed (3)" >>> >>> >> Sorry, I meant "assertion failed (0)". > > We have to support Visual Studio so it doesn't reall

RE: over-tolerant code in run_file_install?

2013-05-21 Thread Bert Huijben
> -Original Message- > From: Mattias Engdegård [mailto:matti...@bredband.net] > Sent: maandag 20 mei 2013 22:23 > To: Subversion Development > Cc: rhuij...@collab.net > Subject: over-tolerant code in run_file_install? > > When trying to consolidate file copying into svn_io_copy_file, I r