Re: Issue with svnpubsub to update the web site of Ant

2013-05-09 Thread Daniel Shahaf
Ben Reser wrote on Thu, May 09, 2013 at 20:58:24 -0700: > On Mon, May 6, 2013 at 5:28 PM, Antoine Levy Lambert wrote: > > The question is how can an API consumer resolve the externals ? > > Not sure why that's important, svnwcsub doesn't use our APIs and just > drives the client. svnwcsub would

Re: Issue with svnpubsub to update the web site of Ant

2013-05-09 Thread Ben Reser
On Mon, May 6, 2013 at 5:28 PM, Antoine Levy Lambert wrote: > the web site of Ant http://ant.apache.org is maintained using svnpubsub from > https://svn.apache.org/repos/asf/ant/site/ant/production/ > > The web site contains ant"s manual as an external but svnpubsub does not seem > to support th

Re: issues dump ?

2013-05-09 Thread Branko Čibej
On 10.05.2013 01:08, Ben Reser wrote: > On Thu, May 9, 2013 at 4:04 PM, Daniel Shahaf wrote: >> Can we get a periodic data dump of subversion.tigris.org/issues/ onto >> ASF hardware? > Drive by comment here but we should probably spend some time and > migrate this to Bloodhound. We really ought t

Re: issues dump ?

2013-05-09 Thread Daniel Shahaf
Ben Reser wrote on Thu, May 09, 2013 at 16:08:57 -0700: > On Thu, May 9, 2013 at 4:04 PM, Daniel Shahaf wrote: > > Can we get a periodic data dump of subversion.tigris.org/issues/ onto > > ASF hardware? > > Drive by comment here but we should probably spend some time and > migrate this to Bloodho

Re: issues dump ?

2013-05-09 Thread Ben Reser
On Thu, May 9, 2013 at 4:04 PM, Daniel Shahaf wrote: > Can we get a periodic data dump of subversion.tigris.org/issues/ onto > ASF hardware? Drive by comment here but we should probably spend some time and migrate this to Bloodhound. We really ought to be dogfooding our own Apache project's issu

issues dump ?

2013-05-09 Thread Daniel Shahaf
Can we get a periodic data dump of subversion.tigris.org/issues/ onto ASF hardware? Not because we need to migrate from tigris, but because we need to have our own backup of our data. (Yes, there is the issues@ history, but, besides it is not designed for machine parsing, and excludes attachments

Re: Thread issues in svnserve

2013-05-09 Thread Philip Martin
Ivan Zhakov writes: > Another way add some kind of svn__shared_pool_t with atomic reference > counter and destroying attached pool when counter reaches zero. > > Something like this: > [[[ > svn__shared_pool_t * svn__shared_pool_attach(apr_pool_t *pool) > { > svn__shared_pool_t sp = apr_pcall

Re: Thread issues in svnserve

2013-05-09 Thread Ivan Zhakov
On Thu, May 9, 2013 at 10:57 PM, Branko Čibej wrote: > On 09.05.2013 18:43, Ivan Zhakov wrote: >> On Thu, May 9, 2013 at 8:41 PM, Philip Martin >> wrote: >>> Branko Čibej writes: >>> On 09.05.2013 17:14, Ivan Zhakov wrote: >> Perhaps we have to look at the httpd code? >> > httpd

Re: Thread issues in svnserve

2013-05-09 Thread Branko Čibej
On 09.05.2013 18:43, Ivan Zhakov wrote: > On Thu, May 9, 2013 at 8:41 PM, Philip Martin > wrote: >> Branko Čibej writes: >> >>> On 09.05.2013 17:14, Ivan Zhakov wrote: > Perhaps we have to look at the httpd code? > httpd doesn't create worker thread dynamically, so they can allocate

Re: Questions about code in svn_client_log5()'s helper func resolve_log_targets()

2013-05-09 Thread Paul Burba
On Fri, May 3, 2013 at 7:18 PM, Julian Foad wrote: > I (Julian Foad) wrote: > >> I (Julian Foad) wrote: [...] can't we simply open [a session] before calling this function, and let this function make simple calls to svn_client__get_revision_number()? >>> >>> The attached patch im

Re: Questions about code in svn_client_log5()'s helper func resolve_log_targets()

2013-05-09 Thread Paul Burba
On Fri, May 3, 2013 at 4:37 PM, Julian Foad wrote: > Hi Paul. > > A bit more review. > >> + If TARGETS contains a single URL and one or more relative paths, then >> + set *RA_TARGET to a copy of that URL and *CONDENSED_PATHS to a copy of >> + each relative path after the URL. >> [...] >> +re

Re: Questions about code in svn_client_log5()'s helper func resolve_log_targets()

2013-05-09 Thread Paul Burba
On Fri, May 3, 2013 at 3:24 PM, C. Michael Pilato wrote: > Paul, > > Was reviewing your svn_client_log5() changes. There are a couple of places > in your reworked svn_client_log5() code (resolve_log_targets(), > specifically) that read like so or similar: > >if (peg_revision->kind == svn_

Re: Thread issues in svnserve

2013-05-09 Thread Ivan Zhakov
On Thu, May 9, 2013 at 8:41 PM, Philip Martin wrote: > Branko Čibej writes: > >> On 09.05.2013 17:14, Ivan Zhakov wrote: Perhaps we have to look at the httpd code? >>> httpd doesn't create worker thread dynamically, so they can allocate >>> apr_thread_t in global pool. Also it has dedic

Re: Thread issues in svnserve

2013-05-09 Thread Philip Martin
Branko Čibej writes: > On 09.05.2013 17:14, Ivan Zhakov wrote: >>> Perhaps we have to look at the httpd code? >>> >> httpd doesn't create worker thread dynamically, so they can allocate >> apr_thread_t in global pool. Also it has dedicated win32 mpm that uses >> CreateThread Windows API directly.

Re: Thread issues in svnserve

2013-05-09 Thread Ivan Zhakov
On Thu, May 9, 2013 at 8:38 PM, Ivan Zhakov wrote: > On Thu, May 9, 2013 at 8:10 PM, Philip Martin > wrote: >> Ivan Zhakov writes: >> >>> But currently APR doesn't access apr_threadattr_t from worker thread >>> and doesn't need access to apr_thread_t from main thread. So using >>> iterpool for a

Re: Thread issues in svnserve

2013-05-09 Thread Ivan Zhakov
On Thu, May 9, 2013 at 8:10 PM, Philip Martin wrote: > Ivan Zhakov writes: > >> But currently APR doesn't access apr_threadattr_t from worker thread >> and doesn't need access to apr_thread_t from main thread. So using >> iterpool for apr_threadattr_t and connection_pool for apr_thread_t >> fixes

Re: Thread issues in svnserve

2013-05-09 Thread Philip Martin
Philip Martin writes: > I think we may be able to create non-detached threads and then > explicitly detach: Oops! I forgot to pass iterpool to apr_thread_create. Doesn't seem to work when I fix it. -- Philip

Re: Thread issues in svnserve

2013-05-09 Thread Philip Martin
Ivan Zhakov writes: > But currently APR doesn't access apr_threadattr_t from worker thread > and doesn't need access to apr_thread_t from main thread. So using > iterpool for apr_threadattr_t and connection_pool for apr_thread_t > fixes problem, but only with current APR implementation. I don't

Re: Thread issues in svnserve

2013-05-09 Thread Branko Čibej
On 09.05.2013 17:14, Ivan Zhakov wrote: >> Perhaps we have to look at the httpd code? >> > httpd doesn't create worker thread dynamically, so they can allocate > apr_thread_t in global pool. Also it has dedicated win32 mpm that uses > CreateThread Windows API directly. I'm beginning to think that

Re: Thread issues in svnserve

2013-05-09 Thread Ivan Zhakov
On Thu, May 9, 2013 at 6:32 PM, Philip Martin wrote: > Philip Martin writes: > >> It might be better to pass iterpool instead of connection_pool into >> apr_thread_create. The problem with tattr also applies to memory >> allocated by apr_thread_create such as *new. At present *new is not >> acc

Re: Thread issues in svnserve

2013-05-09 Thread Philip Martin
Philip Martin writes: > It might be better to pass iterpool instead of connection_pool into > apr_thread_create. The problem with tattr also applies to memory > allocated by apr_thread_create such as *new. At present *new is not > accessed after the thread has started but the implementation cou

Re: Thread issues in svnserve

2013-05-09 Thread Philip Martin
Philip Martin writes: > We could do this: > > Index: subversion/svnserve/svnserve.c > === > --- subversion/svnserve/svnserve.c(revision 1480565) > +++ subversion/svnserve/svnserve.c(working copy) > @@ -444,6 +444,7 @@ int mai

Re: Thread issues in svnserve

2013-05-09 Thread Philip Martin
Ivan Zhakov writes: > On Wed, May 8, 2013 at 1:00 PM, Bert Huijben wrote: >> >> The fix resolves the symptoms, but I would guess it might be better >> to make the thread create (and destroy) its own pool, while using >> some proper iterpool in the function that creates the pools. Handing >> a te