Re: svn commit: r1427278 - in /subversion/trunk/subversion: libsvn_diff/diff_file.c tests/libsvn_diff/diff-diff3-test.c

2013-01-10 Thread Johan Corveleyn
On Tue, Jan 1, 2013 at 3:03 AM, wrote: > Author: rhuijben > Date: Tue Jan 1 02:03:35 2013 > New Revision: 1427278 > > URL: http://svn.apache.org/viewvc?rev=1427278&view=rev > Log: > Resolve another issue in the diff code when using full whitespace > normalization. > > Patch by: Hideki IWAMOTO >

Re: [PATCH] Re: Diff Project compilation problem

2013-01-10 Thread Ben Reser
On Thu, Jan 10, 2013 at 2:24 PM, Gabriela Gibson wrote: > I was testing whether the current tarball (subversion-1.7.8.tar.gz) is > affected by the wrong-lib-linking compilation issue, and I discovered > that zlib.net no longer offers a direct download of the zlib version > in the get-deps.sh scrip

Re: [PATCH] Re: Diff Project compilation problem

2013-01-10 Thread Ben Reser
On Thu, Jan 10, 2013 at 3:19 PM, Branko Čibej wrote: > Looks like we'll have to get-deps.sh on the 1.7.x branch for the next > 1.7 release, then. Care to file an issue about this, tagged with the > 1.7.9 milestone? r1352031 nominated for backport in the 1.7.x STATUS.

Re: [PATCH] Re: Diff Project compilation problem

2013-01-10 Thread Branko Čibej
On 10.01.2013 23:24, Gabriela Gibson wrote: > On 10/01/13 03:55, Daniel Shahaf wrote: > >> Is this section applicable to tarball builds (which don't use >> autogen.sh) too? > > I'm worming my way through the list (more to come) but have > encountered the following issue: > > I was testing whether t

Re: [PATCH] Re: Diff Project compilation problem

2013-01-10 Thread Gabriela Gibson
On 10/01/13 03:55, Daniel Shahaf wrote: Is this section applicable to tarball builds (which don't use autogen.sh) too? I'm worming my way through the list (more to come) but have encountered the following issue: I was testing whether the current tarball (subversion-1.7.8.tar.gz) is affected

RE: svn commit: r1431114 - /subversion/trunk/subversion/svn/merge-cmd.c

2013-01-10 Thread Bert Huijben
> -Original Message- > From: Paul Burba [mailto:ptbu...@gmail.com] > Sent: donderdag 10 januari 2013 20:26 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1431114 - > /subversion/trunk/subversion/svn/merge-cmd.c > > On Thu, Jan 10, 2013 at 2:15 PM, Bert Hui

Re: svn commit: r1431114 - /subversion/trunk/subversion/svn/merge-cmd.c

2013-01-10 Thread Paul Burba
On Thu, Jan 10, 2013 at 2:15 PM, Bert Huijben wrote: > >> -Original Message- >> From: Paul Burba [mailto:ptbu...@gmail.com] >> Sent: donderdag 10 januari 2013 19:59 >> To: Bert Huijben >> Cc: dev@subversion.apache.org >> Subject: Re: svn commit: r1431114 - >> /subversion/trunk/subversion/s

RE: svn commit: r1431114 - /subversion/trunk/subversion/svn/merge-cmd.c

2013-01-10 Thread Bert Huijben
> -Original Message- > From: Paul Burba [mailto:ptbu...@gmail.com] > Sent: donderdag 10 januari 2013 19:59 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1431114 - > /subversion/trunk/subversion/svn/merge-cmd.c > > On Thu, Jan 10, 2013 at 12:38 PM, Bert Hu

Re: svn commit: r1431114 - /subversion/trunk/subversion/svn/merge-cmd.c

2013-01-10 Thread Paul Burba
On Thu, Jan 10, 2013 at 12:38 PM, Bert Huijben wrote: > > >> -Original Message- >> From: pbu...@apache.org [mailto:pbu...@apache.org] >> Sent: woensdag 9 januari 2013 23:04 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1431114 - /subversion/trunk/subversion/svn/merge- >> cm

RE: svn commit: r1431114 - /subversion/trunk/subversion/svn/merge-cmd.c

2013-01-10 Thread Bert Huijben
> -Original Message- > From: pbu...@apache.org [mailto:pbu...@apache.org] > Sent: woensdag 9 januari 2013 23:04 > To: comm...@subversion.apache.org > Subject: svn commit: r1431114 - /subversion/trunk/subversion/svn/merge- > cmd.c > > Author: pburba > Date: Wed Jan 9 22:04:24 2013 > New

Not filtering self-ref mergeinfo in reverse merges [was: The purpose of prepare_merge_props_changed()]

2013-01-10 Thread Julian Foad
Paul Burba wrote on 2013-01-07: > Julian Foad wrote: >> FWIW, I tried removing the "if (! reverse-merge)" condition entirely >> (from both the foreign-repos and the self-ref filtering), and the test >> suite passed.  That is not too surprising, as it probably has very few >> test cases for for

Re: The purpose of prepare_merge_props_changed()

2013-01-10 Thread Julian Foad
Paul Burba wrote on 2013-01-07: > Julian Foad wrote: >> The condition was originally added in r873100, following the discussion >> (mainly between Paul and me) at >> . >>   >> At that time, the "foreign repos" filte

Re: svn commit: r1431279 - /subversion/trunk/subversion/libsvn_wc/wc_db_util.c

2013-01-10 Thread Philip Martin
Philip Martin writes: > The WC layer has a clear distinction between create and open so fixing > in the WC layer only adds an overhead to checkout, the other operations > are unaffected. The other user is FSFS and it does not have this > distinction so the overhead would apply to all operations.

Re: svn commit: r1431279 - /subversion/trunk/subversion/libsvn_wc/wc_db_util.c

2013-01-10 Thread Philip Martin
Julian Foad writes: > Philip Martin wrote: > >> URL: http://svn.apache.org/viewvc?rev=1431279&view=rev > >> Log: >> Ensure wc.db has the permissions allowed by umask. > > ... in order to be consistent with the other files we write, > and to fix sharing a WC? > > If this bug was breaking sharing a

AW: Work in progress: WC "add node" including the props

2013-01-10 Thread Markus Schaber
Hi, Julian, Nice work. I think that CODESYS SVN could profit from this, as we use properties on nearly every file to store our metadata. Now I only need to hack (or convice Bert :-) to expose those APIs in SharpSVN. :-) Best regards Markus Schaber CODESYS® a trademark of 3S-Smart Software So

RE: svn commit: r1431279 - /subversion/trunk/subversion/libsvn_wc/wc_db_util.c

2013-01-10 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: donderdag 10 januari 2013 14:33 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1431279 - > /subversion/trunk/subversion/libsvn_wc/wc_db_util.c > > On 10.01.2013 14:23, Julian Foad wrote: > > If we

Re: svn commit: r1431279 - /subversion/trunk/subversion/libsvn_wc/wc_db_util.c

2013-01-10 Thread Branko Čibej
On 10.01.2013 14:23, Julian Foad wrote: > If we consider this to be a fix for the way SQLite behaves, do we want the > same throughout Subversion? Move the fix into svn_sqlite__open()? Only when creating a new database. > File a bug report with SQLite project? SQLite has a bug related to permi

Re: svn commit: r1431279 - /subversion/trunk/subversion/libsvn_wc/wc_db_util.c

2013-01-10 Thread Julian Foad
Philip Martin wrote: > URL: http://svn.apache.org/viewvc?rev=1431279&view=rev > Log: > Ensure wc.db has the permissions allowed by umask. ... in order to be consistent with the other files we write, and to fix sharing a WC? If this bug was breaking sharing a WC, should we back-port this fix? >

FSFS access map tool

2013-01-10 Thread Stefan Fuhrmann
Hi there, Julian recently asked me about my new FSFS access map tool. I take that as an opportunity to introduce you all to it. As part of my work on I/O reduction in FSFS repos, I needed some way to actually measure, and ideally visualize, the I/O activity such that we have nice before-and-after