Re: [PATCH] Re: Diff Project compilation problem

2013-01-09 Thread Daniel Shahaf
Gabriela Gibson wrote on Thu, Jan 10, 2013 at 00:15:29 +: > I thought that the solutions to this question might be useful to have in > the faq.html. > +There are a couple of frequent causes of this kind of problem: > + > +1. You could be linking about your own installed libraries. It would

Re: [PATCH] Re: Diff Project compilation problem

2013-01-09 Thread Ben Reser
On Wed, Jan 9, 2013 at 4:15 PM, Gabriela Gibson wrote: > I thought that the solutions to this question might be useful to have in the > faq.html. > +1. You could be linking about your own installed libraries. Think you mean "You could be linking to your own installed libraries." I'd probably f

[PATCH] Re: Diff Project compilation problem

2013-01-09 Thread Gabriela Gibson
I thought that the solutions to this question might be useful to have in the faq.html. Index: publish/faq.html === --- publish/faq.html (revision 1431153) +++ publish/faq.html (working copy) @@ -282,6 +282,8 @@ validating server certi

Re: svn commit: r1424708 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_ra/ libsvn_wc/

2013-01-09 Thread Julian Foad
Paul Burba wrote: > On Thu, Dec 20, 2012 at 4:56 PM, Julian Foad wrote: >>> Author: pburba >>> Date: Thu Dec 20 21:19:08 2012 >>> New Revision: 1424708 >>> >>> URL: http://svn.apache.org/viewvc?rev=1424708&view=rev >>> Log: >>> Store repos root relative paths in NODES.INHERITED_PROPS rather

Re: svn commit: r1431072 - in /subversion/trunk/subversion: include/svn_types.h libsvn_client/copy.c libsvn_ra_serf/commit.c libsvn_subr/named_atomic.c libsvn_subr/stream.c mod_dav_svn/reports/replay.

2013-01-09 Thread Julian Foad
Blair Zajac wrote: > On 01/09/2013 01:02 PM, julianf...@apache.org wrote: >> Log: >> Consistify a few remaining redundant or odd expressions involving boolean >> constants, such as "foo == FALSE" to "!foo" and "number ? FALSE : TRUE" to >> "number != 0".  A follow-up to r1431017 and r1431040.

Re: svn commit: r1431072 - in /subversion/trunk/subversion: include/svn_types.h libsvn_client/copy.c libsvn_ra_serf/commit.c libsvn_subr/named_atomic.c libsvn_subr/stream.c mod_dav_svn/reports/replay.

2013-01-09 Thread Blair Zajac
On 01/09/2013 01:02 PM, julianf...@apache.org wrote: Author: julianfoad Date: Wed Jan 9 21:02:33 2013 New Revision: 1431072 URL: http://svn.apache.org/viewvc?rev=1431072&view=rev Log: Consistify a few remaining redundant or odd expressions involving boolean constants, such as "foo == FALSE" to

Re: Diff Project compilation problem

2013-01-09 Thread Gabriela Gibson
On 09/01/13 16:54, Philip Martin wrote:> > ./configure --prefix=/usr/local/subversionx ... > > which solves the linking problem. I never install this build so > /usr/local/subversionx/lib never exists. When I want to install a build > of Subversion I reconfigure and rebuild using the correct

Re: svn commit: r1430185 - in /subversion/trunk/subversion: include/svn_dav.h libsvn_ra_serf/options.c libsvn_ra_serf/ra_serf.h mod_dav_svn/version.c

2013-01-09 Thread Mark Phippard
On Wed, Jan 9, 2013 at 3:22 PM, Ivan Zhakov wrote: > On Thu, Jan 10, 2013 at 12:14 AM, C. Michael Pilato > wrote: >> On 01/09/2013 03:10 PM, Ivan Zhakov wrote: >>> I'm thinking about interoperability between svn 1.8-serf client and >>> pre-1.8 server: currently we use non-bulk skelta mode and th

Re: svn commit: r1430185 - in /subversion/trunk/subversion: include/svn_dav.h libsvn_ra_serf/options.c libsvn_ra_serf/ra_serf.h mod_dav_svn/version.c

2013-01-09 Thread Ivan Zhakov
On Thu, Jan 10, 2013 at 12:14 AM, C. Michael Pilato wrote: > On 01/09/2013 03:10 PM, Ivan Zhakov wrote: >> I'm thinking about interoperability between svn 1.8-serf client and >> pre-1.8 server: currently we use non-bulk skelta mode and this leads >> PROPFINDs and GETs for each file/directory. I've

Re: svn commit: r1431017 - in /subversion/trunk: subversion/libsvn_delta/ subversion/libsvn_fs_base/ subversion/libsvn_fs_fs/ subversion/libsvn_ra_serf/ subversion/libsvn_ra_svn/ subversion/libsvn_rep

2013-01-09 Thread Stefan Fuhrmann
On Wed, Jan 9, 2013 at 8:36 PM, Julian Foad wrote: > Stefan, > > > Log: > > > Coding style patch: in logical expressions, instead of comparing > > with logical constants use arithmetic operations. I.e. replace > > No don't use arithmetic operations. Maybe write, "In *boolean* > expressions, inst

Re: svn commit: r1430185 - in /subversion/trunk/subversion: include/svn_dav.h libsvn_ra_serf/options.c libsvn_ra_serf/ra_serf.h mod_dav_svn/version.c

2013-01-09 Thread C. Michael Pilato
On 01/09/2013 03:10 PM, Ivan Zhakov wrote: > I'm thinking about interoperability between svn 1.8-serf client and > pre-1.8 server: currently we use non-bulk skelta mode and this leads > PROPFINDs and GETs for each file/directory. I've added option to > advertise inline props support to leave possib

Re: svn commit: r1430185 - in /subversion/trunk/subversion: include/svn_dav.h libsvn_ra_serf/options.c libsvn_ra_serf/ra_serf.h mod_dav_svn/version.c

2013-01-09 Thread Ivan Zhakov
On Tue, Jan 8, 2013 at 6:55 PM, C. Michael Pilato wrote: > On 01/08/2013 04:20 AM, i...@apache.org wrote: >> Author: ivan >> Date: Tue Jan 8 09:20:54 2013 >> New Revision: 1430185 >> >> URL: http://svn.apache.org/viewvc?rev=1430185&view=rev >> Log: >> mod_dav_svn: Advertise if server supports sen

Re: svn commit: r1431017 - in /subversion/trunk: subversion/libsvn_delta/ subversion/libsvn_fs_base/ subversion/libsvn_fs_fs/ subversion/libsvn_ra_serf/ subversion/libsvn_ra_svn/ subversion/libsvn_rep

2013-01-09 Thread Julian Foad
Stefan,  > Log: > Coding style patch: in logical expressions, instead of comparing > with logical constants use arithmetic operations. I.e. replace No don't use arithmetic operations.  Maybe write, "In *boolean* expressions, instead of comparing with FALSE (or, worse, with TRUE), use *boolean*

Re: svn commit: r1430975 - /subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/low_level.c

2013-01-09 Thread Stefan Fuhrmann
On Wed, Jan 9, 2013 at 8:11 PM, Branko Čibej wrote: > On 09.01.2013 20:00, Stefan Fuhrmann wrote: > > On Wed, Jan 9, 2013 at 7:42 PM, Branko Čibej > > wrote: > > > > On 09.01.2013 19:35, Ben Reser wrote: > > > On Wed, Jan 9, 2013 at 10:00 AM, Branko Čibej > >

Re: svn commit: r1430975 - /subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/low_level.c

2013-01-09 Thread Branko Čibej
On 09.01.2013 20:00, Stefan Fuhrmann wrote: > On Wed, Jan 9, 2013 at 7:42 PM, Branko Čibej > wrote: > > On 09.01.2013 19:35, Ben Reser wrote: > > On Wed, Jan 9, 2013 at 10:00 AM, Branko Čibej > mailto:br...@wandisco.com>> wrote: > >> On 09.01.2013 18:54,

Re: svn commit: r1430975 - /subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/low_level.c

2013-01-09 Thread Stefan Fuhrmann
On Wed, Jan 9, 2013 at 7:42 PM, Branko Čibej wrote: > On 09.01.2013 19:35, Ben Reser wrote: > > On Wed, Jan 9, 2013 at 10:00 AM, Branko Čibej > wrote: > >> On 09.01.2013 18:54, stef...@apache.org wrote: > >>> - if (header->is_delta) > >>> + if (header->is_delta == FALSE) > >> Can we please use

Re: svn commit: r1430975 - /subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/low_level.c

2013-01-09 Thread Branko Čibej
On 09.01.2013 19:35, Ben Reser wrote: > On Wed, Jan 9, 2013 at 10:00 AM, Branko Čibej wrote: >> On 09.01.2013 18:54, stef...@apache.org wrote: >>> - if (header->is_delta) >>> + if (header->is_delta == FALSE) >> Can we please use logical operators to test boolean values, not >> arithmetic ones? >

Re: svn commit: r1430975 - /subversion/branches/fsfs-format7/subversion/libsvn_fs_fs/low_level.c

2013-01-09 Thread Ben Reser
On Wed, Jan 9, 2013 at 10:00 AM, Branko Čibej wrote: > On 09.01.2013 18:54, stef...@apache.org wrote: >> >> - if (header->is_delta) >> + if (header->is_delta == FALSE) > > Can we please use logical operators to test boolean values, not > arithmetic ones? > > if (!header->is_delta) There's quite

Re: sha-256 comment in /trunk/subversion/libsvn_subr/crypto.c

2013-01-09 Thread Ben Reser
On Wed, Jan 9, 2013 at 6:39 AM, C. Michael Pilato wrote: > My state concern about our export status has, IIRC, been refuted. But I > need to find documentation of that refutation, and then remember to update > the wiki. I'm guessing that your concern here is with US export restrictions. Incident

Re: Diff Project compilation problem

2013-01-09 Thread Philip Martin
Gabriela Gibson writes: > cd subversion/svnmucc && /bin/bash /home/g/trunk/libtool --tag=CC --silent > --mode=link gcc -g3 -fno-omit-frame-pointer -fno-inline -Wall -Wmiss\ > ing-prototypes -Wstrict-prototypes -Wmissing-declarations -pthread > -DSVN_DEBUG -DAP_DEBUG -rpath /usr/local/lib -o

Re: Diff Project compilation problem

2013-01-09 Thread Stefan Sperling
On Wed, Jan 09, 2013 at 04:31:05PM +, Gabriela Gibson wrote: > I added a new option to the command structure and the compile error > I get is this: > > ../../subversion/libsvn_client/.libs/libsvn_client-1.so: undefined > reference to `svn_wc__get_wcroot' > ../../subversion/libsvn_client/.libs/

Re: Diff Project compilation problem

2013-01-09 Thread Hyrum K Wright
On Wed, Jan 9, 2013 at 11:37 AM, Branko Čibej wrote: > On 09.01.2013 17:31, Gabriela Gibson wrote: > > I added a new option to the command structure and the compile error I > > get is this: > > > > ../../subversion/libsvn_client/.libs/libsvn_client-1.so: undefined > > reference to `svn_wc__get_wc

Re: Diff Project compilation problem

2013-01-09 Thread Branko Čibej
On 09.01.2013 17:31, Gabriela Gibson wrote: > I added a new option to the command structure and the compile error I > get is this: > > ../../subversion/libsvn_client/.libs/libsvn_client-1.so: undefined > reference to `svn_wc__get_wcroot' > ../../subversion/libsvn_client/.libs/libsvn_client-1.so: un

Diff Project compilation problem

2013-01-09 Thread Gabriela Gibson
I added a new option to the command structure and the compile error I get is this: ../../subversion/libsvn_client/.libs/libsvn_client-1.so: undefined reference to `svn_wc__get_wcroot' ../../subversion/libsvn_client/.libs/libsvn_client-1.so: undefined reference to `svn_wc_add_from_disk2' What is

Re: sha-256 comment in /trunk/subversion/libsvn_subr/crypto.c

2013-01-09 Thread C. Michael Pilato
On 01/08/2013 07:53 PM, Ben Reser wrote: > In this case I think this code should probably be removed from trunk > for the time being. The wiki for this functionality mentions that it > may complicate our export control status. If we're not using it we > should probably remove it prior to 1.8 bran

Re: Subversion & Windows

2013-01-09 Thread Justin Erenkrantz
On Wed, Jan 9, 2013 at 3:30 AM, Branko Čibej wrote: > We talked about that a couple days ago, but the problem is that a > Windows VM requires a Windows OS license for every user of that VM. > That's not something we can provide or hack around (well ... we could > hack around it, but it would be a

Re: Subversion & Windows

2013-01-09 Thread Branko Čibej
On 09.01.2013 07:32, Miha Vitorovic wrote: > On 8.1.2013 21:28, Ben Reser wrote: >> I think flat out the problem is that building on Windows is just a >> pain. I remember it took me several days to get a working build >> environment so I could be the last signature on 1.6.19. Unfortunately >> I c