Re: [PATCH] code file names linkified in general.html of the Hacking Guide

2013-01-03 Thread Ben Reser
On Wed, Dec 26, 2012 at 4:27 PM, Gabriela Gibson wrote: > * docs/community-guide/general.part.html > > (code-to-read): Linkified code file names. You've got an extra blank line in there between the file and the identifier. > * docs/community-guide/general.part.html > (directory-layout): Link

Re: svn commit: r1428209 - in /subversion/trunk: Makefile.in build.conf build/win32/make_dist.py tools/server-side/svnauthz-validate.c tools/server-side/svnauthz.c

2013-01-03 Thread Ben Reser
On Thu, Jan 3, 2013 at 2:46 PM, Daniel Shahaf wrote: > Use a relative target for the symlink? > > For svnmucc I couldn't do this because bindir != toolsdir, but that > consideration doesn't kick in for svnauthz. Done in r1428712.

Re: What version of Serf will be the required minimum for Subversion 1.8?

2013-01-03 Thread Branko Čibej
On 04.01.2013 00:29, Greg Stein wrote: > > Eep! Didn't realize, or forgot, that I'm blocking the release. > > Okay. I'll release 1.2 by Sunday. > I believe you should consider including this (or an equivalent) fix in 1.2: https://code.google.com/p/serf/issues/detail?id=93 It addresses a known bu

Re: Proposal for OPW project

2013-01-03 Thread Daniel Shahaf
Philip Martin wrote on Wed, Jan 02, 2013 at 21:59:59 +: > Gabriela Gibson writes: > > > On 02/01/13 10:38, Philip Martin wrote: > >> A small one: svnadmin freeze multiple repositories > >> http://subversion.tigris.org/issues/show_bug.cgi?id=4276 > >> > >> A bit larger: rep-cache offset valida

Re: [PATCH]: Re: Proposal for OPW project

2013-01-03 Thread Branko Čibej
On 03.01.2013 23:27, Gabriela Gibson wrote: > Change default behaviour of get_deps.sh from downloading gtest > library to making it an optional target. > > * get-deps.sh > (usage): Add gtest to list of possible arguments. > (get_deps): Remove gtest from list of default downloads. > > Patch by:

Re: Proposal for OPW project

2013-01-03 Thread Gabriela Gibson
On 02/01/13 21:59, Philip Martin wrote: Or the loop could go in the libsvn_repos library by changing the svn_repos_freeze API to pass an array of paths. The loop in the library may well look much like the above svnadmin loop, but putting it in the library has the advantage of making it readily

Re: What version of Serf will be the required minimum for Subversion 1.8?

2013-01-03 Thread Greg Stein
Eep! Didn't realize, or forgot, that I'm blocking the release. Okay. I'll release 1.2 by Sunday. Then I'd support Lieven's suggestion to make it the minimum for 1.8. I would also recommend it as the suggested version for 1.7 (and keep 0.7 as the minimum, I guess) Cheers, -g On Jan 3, 2013 2:27 P

Re: svn commit: r1428209 - in /subversion/trunk: Makefile.in build.conf build/win32/make_dist.py tools/server-side/svnauthz-validate.c tools/server-side/svnauthz.c

2013-01-03 Thread Daniel Shahaf
bre...@apache.org wrote on Thu, Jan 03, 2013 at 08:19:37 -: > @@ -926,4 +926,5 @@ INSTALL_EXTRA_TOOLS=\ >$(MKDIR) $(DESTDIR)$(bindir); \ >test -n "$$SVN_SVNMUCC_IS_SVNSYITF" && \ >ln -sf svnmucc$(EXEEXT) $(DESTDIR)$(bindir)/svnsyitf$(EXEEXT); \ > - ln -sf $(DESTDIR)$(bindir)/svnmuc

[PATCH]: Re: Proposal for OPW project

2013-01-03 Thread Gabriela Gibson
On Thu, Jan 03, 2013 at 06:09:33AM +0200, Daniel Shahaf wrote: > > Something's missing. > > If gtest is a dependency of svn 1.8, you should add it to the usage > message of the script; if it's not, there's no reason to download it in > the argc == 1 branch. I have attached a patch, thank you for

Re: svn commit: r1427254 - /subversion/trunk/tools/server-side/svnauthz-validate.c

2013-01-03 Thread Ben Reser
On Thu, Jan 3, 2013 at 12:40 PM, Branko Čibej wrote: > We have maintainer-mode magic that aborts if it detects an svn_error_t > that was not properly cleaned up. That's exactly what it was, we didn't call svn_error_clear() after svn_handle_error2().

Re: svn commit: r1427254 - /subversion/trunk/tools/server-side/svnauthz-validate.c

2013-01-03 Thread Branko Čibej
On 03.01.2013 21:38, Ben Reser wrote: > On Thu, Jan 3, 2013 at 12:17 PM, Daniel Shahaf wrote: >> What's the benefit of this? Destroying the pool at process exit --- >> it's not to reclaim memory. Is it to ensure some pool cleanup callback >> fires? > It's mostly just a correctness thing. I noti

Re: svn commit: r1427254 - /subversion/trunk/tools/server-side/svnauthz-validate.c

2013-01-03 Thread Ben Reser
On Thu, Jan 3, 2013 at 12:17 PM, Daniel Shahaf wrote: > What's the benefit of this? Destroying the pool at process exit --- > it's not to reclaim memory. Is it to ensure some pool cleanup callback > fires? It's mostly just a correctness thing. I noticed it when I noticed that 1.7.x's svnauthz-

Re: What version of Serf will be the required minimum for Subversion 1.8?

2013-01-03 Thread Lieven Govaerts
Hi Mike, In short: for me serf 1.2.0 should be the minimum version. Its release blocks on gstein for now, but I'm ready to release it in time for svn 1.8.0. On Thu, Jan 3, 2013 at 5:02 PM, C. Michael Pilato wrote: > Hey, all. I'd like to get a sense of what we're targeting in terms of > minimum

Re: svn commit: r1427254 - /subversion/trunk/tools/server-side/svnauthz-validate.c

2013-01-03 Thread Daniel Shahaf
bre...@apache.org wrote on Mon, Dec 31, 2012 at 23:12:43 -: > Author: breser > Date: Mon Dec 31 23:12:42 2012 > New Revision: 1427254 > > URL: http://svn.apache.org/viewvc?rev=1427254&view=rev > Log: > svnauthz-validate: Split main in main and sub_main so pool is cleaned up > properly. > Wha

Re: svn commit: r1428561 - in /subversion/trunk/subversion/libsvn_client: client.h diff.c diff_summarize.c

2013-01-03 Thread Mark Phippard
On Thu, Jan 3, 2013 at 2:24 PM, wrote: > Author: rhuijben > Date: Thu Jan 3 19:24:06 2013 > New Revision: 1428561 > > URL: http://svn.apache.org/viewvc?rev=1428561&view=rev > Log: > Make 'svn diff --summarize' handle repos-wc diffs to make its implementation > match all the capabilities of the n

Re: What version of Serf will be the required minimum for Subversion 1.8?

2013-01-03 Thread C. Michael Pilato
On 01/03/2013 11:23 AM, Branko Čibej wrote: > On 03.01.2013 17:02, C. Michael Pilato wrote: >> Hey, all. I'd like to get a sense of what we're targeting in terms of >> minimum required Serf library versions for Subversion 1.8. >> >> First, the status quo: >> >> - In Subversion 1.7, we require Serf

Re: What version of Serf will be the required minimum for Subversion 1.8?

2013-01-03 Thread Branko Čibej
On 03.01.2013 17:02, C. Michael Pilato wrote: > Hey, all. I'd like to get a sense of what we're targeting in terms of > minimum required Serf library versions for Subversion 1.8. > > First, the status quo: > > - In Subversion 1.7, we require Serf 0.7.1 or better. > - Currently on the trunk, we req

What version of Serf will be the required minimum for Subversion 1.8?

2013-01-03 Thread C. Michael Pilato
Hey, all. I'd like to get a sense of what we're targeting in terms of minimum required Serf library versions for Subversion 1.8. First, the status quo: - In Subversion 1.7, we require Serf 0.7.1 or better. - Currently on the trunk, we require Serf 1.0.0 or better. In reviewing the changes relea

Re: 1.6.20 up for testing/signing

2013-01-03 Thread Branko Čibej
Summary: +1 to release Platform Mac OS X 10.8.2 Mountain Lion, build 12C2034 Standard dependencies: clang(++) 4.1/LLVM 3.1svn APR 1.4.5 APR-Util 1.3.12 zlib 1.2.5 httpd 2.2.22 OpenSSL 0.9.8r SQLite 3.7.12 Java 1.6.0_37 Python 2.7

Re: 1.6.20 up for testing/signing

2013-01-03 Thread Stefan Sperling
On Thu, Jan 03, 2013 at 12:26:22AM -0800, Ben Reser wrote: > On Fri, Dec 28, 2012 at 8:38 AM, Stefan Sperling wrote: > > Summary: +1 to release > > I noticed you signed the zip file. Just wanting to clarify that your > vote is for UNIX only right? Yes, it's just that the release.py target signs

Re: [PATCH] Add -no-suppress to LT_CFLAGS

2013-01-03 Thread Justin Erenkrantz
If you look at the path of the file that failed compilation, it is in subversion/svn/. On Mac OS X there is no need to compile it twice as there is no real supported concept of PIC - it's a no-op for the compiler. Linking the libraries statically or dynamically is different of course. -- justin O

Re: 1.6.20 up for testing/signing

2013-01-03 Thread Philip Martin
Philip Herron writes: > aptitude shows me i am on 0.2.0-1 from archive.debian.org since this is > lenny. All 1.6.x releases require serf to be at least 0.3.0. If you build 1.6 on this platform in the past you must have built it without serf or used a different serf package or patched the Subver

Re: [PATCH] Implement svnadmin verify --keep-going

2013-01-03 Thread Prabhu Gnana Sundar
On 12/20/2012 11:25 PM, Julian Foad wrote: Hi Prabhu. I have now looked in detail at your patch and tried using it. I think I have found an inconsistency and a serious problem. The output for a failed revision depends on whether --keep-going was passed. With --keep-going you print a "* Erro

Re: 1.6.20 up for testing/signing

2013-01-03 Thread Ben Reser
On Thu, Dec 27, 2012 at 12:54 PM, Ben Reser wrote: > The 1.6.20 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on January > 4th so please try an

Re: 1.6.20 up for testing/signing

2013-01-03 Thread Ben Reser
On Fri, Dec 28, 2012 at 8:38 AM, Stefan Sperling wrote: > Summary: +1 to release > > Tested: [bdb | fsfs] x [ra_local | ra_svn | ra_neon | ra_serf] > swig bindings > javahl bindings > > Test results: Tests passed, except: > ra_local-bdb: > FAIL: diff_tests.py 32: repos-wc diff