Re: [PATCH] Fix for "\r" in "svnrdump load" (issue 4263)

2012-12-17 Thread Ben Reser
On Mon, Dec 17, 2012 at 5:40 PM, Gabriela Gibson wrote: > [[ > Fix issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in > 'svn:log' property > > Fix to ensure that no "\r" characters are present in revision or node > props. Looks pretty good to me with a few relatively minor comme

[PATCH] Fix for "\r" in "svnrdump load" (issue 4263)

2012-12-17 Thread Gabriela Gibson
Hi all, [[ Fix issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in 'svn:log' property Fix to ensure that no "\r" characters are present in revision or node props. In the case of "\r\n" character sequences, the "\r" is removed. In the case of "\r" characters which are not follo

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, Dec 17, 2012 at 21:39:49 +0100: > On Mon, Dec 17, 2012 at 01:44:43PM -0600, Peter Samuelson wrote: > > [Stefan Sperling] > > > We could use iatty() to enable --non-interactive if output is not > > > going to a terminal, for instance. > > > > I floated this idea some t

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, Dec 17, 2012 at 21:32:24 +0100: > On Mon, Dec 17, 2012 at 09:14:42PM +0100, Branko Čibej wrote: > > That "blatant abuse" happens at least in two places that I'm aware of: > > our tests, and Emacs vc-mode. > > There is a difference between scraping the cli output and h

Work in progress: WC "add node" including the props

2012-12-17 Thread Julian Foad
Just for information, here's the patch showing what I am working on.  The log message is at the top of the patch and begins: "Teach some WC and client 'add' functions to take the properties as a parameter so that the whole addition including any properties can be done all at once.  ..." - Julia

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Peter Samuelson
> On Mon, Dec 17, 2012 at 01:44:43PM -0600, Peter Samuelson wrote: > > [Stefan Sperling] > > > We could use iatty() to enable --non-interactive if output is not > > > going to a terminal, for instance. > > > > I floated this idea some time ago and I'm still in favor of it. But I > > think a simp

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Stefan Sperling
On Mon, Dec 17, 2012 at 01:44:43PM -0600, Peter Samuelson wrote: > [Stefan Sperling] > > We could use iatty() to enable --non-interactive if output is not > > going to a terminal, for instance. > > I floated this idea some time ago and I'm still in favor of it. But I > think a simple isatty(STDER

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Stefan Sperling
On Mon, Dec 17, 2012 at 09:14:42PM +0100, Branko Čibej wrote: > That "blatant abuse" happens at least in two places that I'm aware of: > our tests, and Emacs vc-mode. There is a difference between scraping the cli output and having a program type answers into prompts. Do our tests really do the la

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread C. Michael Pilato
On 12/17/2012 03:11 PM, Branko Čibej wrote: > On 17.12.2012 20:01, C. Michael Pilato wrote: >> On 12/17/2012 01:05 PM, Branko Čibej wrote: >>> On 17.12.2012 15:03, C. Michael Pilato wrote: On 12/17/2012 05:19 AM, Branko Čibej wrote: > On 17.12.2012 09:47, Bert Huijben wrote: >> I think

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Branko Čibej
On 17.12.2012 20:44, Peter Samuelson wrote: > [Stefan Sperling] >> We could use iatty() to enable --non-interactive if output is not >> going to a terminal, for instance. > I floated this idea some time ago and I'm still in favor of it. But I > think a simple isatty(STDERR_FILENO) would be wrong.

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Branko Čibej
On 17.12.2012 20:01, C. Michael Pilato wrote: > On 12/17/2012 01:05 PM, Branko Čibej wrote: >> On 17.12.2012 15:03, C. Michael Pilato wrote: >>> On 12/17/2012 05:19 AM, Branko Čibej wrote: On 17.12.2012 09:47, Bert Huijben wrote: > I think we should suppress this warning on Windows when th

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Peter Samuelson
[Stefan Sperling] > We could use iatty() to enable --non-interactive if output is not > going to a terminal, for instance. I floated this idea some time ago and I'm still in favor of it. But I think a simple isatty(STDERR_FILENO) would be wrong. What you want is to detect that there is a contro

Re: 1.7.8 up for testing/signing

2012-12-17 Thread Mark Phippard
Good because I am getting some compile errors with the tests that I have had before and having trouble resolving it. On Mon, Dec 17, 2012 at 2:07 PM, Bert Huijben wrote: > I completed the test run succesfull on my test vm. > > I just have to check the status of my gpg key migration. > > Bert >

RE: 1.7.8 up for testing/signing

2012-12-17 Thread Bert Huijben
I completed the test run succesfull on my test vm. I just have to check the status of my gpg key migration. Bert From: Mark Phippard Sent: 17-12-2012 19:54 To: Ben Reser Cc: Subversion Development Subject: Re: 1.7.8 up for testing/signing On Mon, Dec 17, 2012 at

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread C. Michael Pilato
On 12/17/2012 01:05 PM, Branko Čibej wrote: > On 17.12.2012 15:03, C. Michael Pilato wrote: >> On 12/17/2012 05:19 AM, Branko Čibej wrote: >>> On 17.12.2012 09:47, Bert Huijben wrote: I think we should suppress this warning on Windows when the CryptoAPI encryption is enabled (read: +- alw

Re: 1.7.8 up for testing/signing

2012-12-17 Thread Mark Phippard
On Mon, Dec 17, 2012 at 1:36 PM, Ben Reser wrote: > On Fri, Dec 14, 2012 at 3:57 PM, Ben Reser wrote: >> I need one more signature for Windows in order to release. Listed >> expected release day is Monday December 17th. So I'll need to get the >> signatures by Sunday in order to have the files

Re: 1.7.8 up for testing/signing

2012-12-17 Thread Ben Reser
On Fri, Dec 14, 2012 at 3:57 PM, Ben Reser wrote: > I need one more signature for Windows in order to release. Listed > expected release day is Monday December 17th. So I'll need to get the > signatures by Sunday in order to have the files staged for that > release date. Still waiting on that o

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Branko Čibej
On 17.12.2012 15:03, C. Michael Pilato wrote: > On 12/17/2012 05:19 AM, Branko Čibej wrote: >> On 17.12.2012 09:47, Bert Huijben wrote: >>> I think we should suppress this warning on Windows when the CryptoAPI >>> encryption is enabled (read: +- always) to avoid unneeded user questions. >> I rather

Re: svn commit: r1422893 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/getopt_tests.py

2012-12-17 Thread Branko Čibej
On 17.12.2012 14:51, Stefan Sperling wrote: > On Mon, Dec 17, 2012 at 12:17:40PM -, br...@apache.org wrote: >> Author: brane >> Date: Mon Dec 17 12:17:40 2012 >> New Revision: 1422893 >> >> URL: http://svn.apache.org/viewvc?rev=1422893&view=rev >> Log: >> Don't colourize the plaintext-store war

Re: svn commit: r1421489 - in /subversion/trunk: configure.ac get-deps.sh

2012-12-17 Thread Daniel Shahaf
Daniel Shahaf wrote on Mon, Dec 17, 2012 at 18:38:11 +0200: > Arfrever Frehtes Taifersar Arahesis wrote on Mon, Dec 17, 2012 at 11:35:10 > +0100: > > 2012-12-14 22:36:27 Daniel Shahaf napisał(a): > > > arfre...@apache.org wrote on Thu, Dec 13, 2012 at 20:21:13 -: > > > > Author: arfrever > > >

Re: svn commit: r1421489 - in /subversion/trunk: configure.ac get-deps.sh

2012-12-17 Thread Daniel Shahaf
Arfrever Frehtes Taifersar Arahesis wrote on Mon, Dec 17, 2012 at 11:35:10 +0100: > 2012-12-14 22:36:27 Daniel Shahaf napisał(a): > > arfre...@apache.org wrote on Thu, Dec 13, 2012 at 20:21:13 -: > > > Author: arfrever > > > Date: Thu Dec 13 20:21:12 2012 > > > New Revision: 1421489 > > > > >

Re: Improve error handling in svn_ra_serf__replay_range()

2012-12-17 Thread Philip Martin
vijay writes: > The function svn_ra_serf__replay_range() doesn't return any error > while running 'svnrdump dump -rN:M '[Issue #4100]. > It behaves as if the dump completed successfully. > > * subversion/libsvn_ra_serf/replay.c > (svn_ra_serf__replay_range): Handle the errors from server's re

Improve error handling in svn_ra_serf__replay_range()

2012-12-17 Thread vijay
Hi, I was looking at the issue #4100: "svnrdump dump -rN:M ' fails" [1]. [[[ $ URL=http://svn.apache.org/repos/asf/subversion/trunk/contrib/server-side/mod_setlocale $ svnrdump dump $URL -r1232154 > /dev/null * Dumped revision 1232154. $ svnrdump dump $URL -r1232155 > /dev/null * Dumped rev

Re: svn commit: r1422206 - in /subversion/trunk/subversion: svnrdump/ tests/cmdline/ tests/cmdline/svnrdump_tests_data/

2012-12-17 Thread C. Michael Pilato
On 12/17/2012 12:24 AM, vijay wrote: > On Saturday 15 December 2012 02:33 PM, cmpil...@apache.org wrote: >> Author: cmpilato >> Date: Sat Dec 15 09:03:23 2012 >> New Revision: 1422206 >> >> URL: http://svn.apache.org/viewvc?rev=1422206&view=rev >> Log: >> Fix issue #4104 ("'svnrdump dump -rN:M /sub

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread C. Michael Pilato
On 12/17/2012 05:19 AM, Branko Čibej wrote: > On 17.12.2012 09:47, Bert Huijben wrote: >> I think we should suppress this warning on Windows when the CryptoAPI >> encryption is enabled (read: +- always) to avoid unneeded user questions. > > I rather think we should disable plaintext password stora

Re: svn commit: r1422893 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/getopt_tests.py

2012-12-17 Thread Stefan Sperling
On Mon, Dec 17, 2012 at 12:17:40PM -, br...@apache.org wrote: > Author: brane > Date: Mon Dec 17 12:17:40 2012 > New Revision: 1422893 > > URL: http://svn.apache.org/viewvc?rev=1422893&view=rev > Log: > Don't colourize the plaintext-store warning, > and don't ignore too many blank lines in the

Re: svn commit: r1413451 - /subversion/branches/cache-server/BRANCH-README

2012-12-17 Thread Branko Čibej
Resent to the correct list. On 17.12.2012 11:41, Branko Čibej wrote: > On 17.12.2012 11:25, Daniel Shahaf wrote: >> stef...@apache.org wrote on Mon, Nov 26, 2012 at 00:21:26 -: >>> Author: stefan2 >>> Date: Mon Nov 26 00:21:26 2012 >>> New Revision: 1413451 >>> >>> URL: http://svn.apache.org/v

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Branko Čibej
On 17.12.2012 11:23, Bert Huijben wrote: > >> -Original Message- >> From: Branko Čibej [mailto:br...@wandisco.com] >> Sent: maandag 17 december 2012 11:19 >> To: dev@subversion.apache.org >> Subject: Re: svn commit: r1422706 - in /subversion/trunk/subversion: >> libsvn_subr/opt.c tests/cmdl

Re: svn commit: r1421489 - in /subversion/trunk: configure.ac get-deps.sh

2012-12-17 Thread Arfrever Frehtes Taifersar Arahesis
2012-12-14 22:36:27 Daniel Shahaf napisał(a): > arfre...@apache.org wrote on Thu, Dec 13, 2012 at 20:21:13 -: > > Author: arfrever > > Date: Thu Dec 13 20:21:12 2012 > > New Revision: 1421489 > > > > URL: http://svn.apache.org/viewvc?rev=1421489&view=rev > > Log: > > * configure.ac: Update rec

Re: svn commit: r1413451 - /subversion/branches/cache-server/BRANCH-README

2012-12-17 Thread Daniel Shahaf
stef...@apache.org wrote on Mon, Nov 26, 2012 at 00:21:26 -: > Author: stefan2 > Date: Mon Nov 26 00:21:26 2012 > New Revision: 1413451 > > URL: http://svn.apache.org/viewvc?rev=1413451&view=rev > Log: > On the cache-server branch. > > * BRANCH-README: add > > Added: > subversion/branche

RE: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: maandag 17 december 2012 11:19 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1422706 - in /subversion/trunk/subversion: > libsvn_subr/opt.c tests/cmdline/svntest/main.py > > On 17.12.2012 09:47, B

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Branko Čibej
On 17.12.2012 10:28, Stefan Sperling wrote: > On Mon, Dec 17, 2012 at 08:47:43AM +, Bert Huijben wrote: >> And I’m not sure what to think of the color escape strings... >> Do these work on any not Windows os with any terminal settings? >> (We currently only use these in the test suite and the r

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Branko Čibej
On 17.12.2012 09:47, Bert Huijben wrote: > I think we should suppress this warning on Windows when the CryptoAPI > encryption is enabled (read: +- always) to avoid unneeded user questions. I rather think we should disable plaintext password storage by default, I don't care about Windows, and let p

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Philip Martin
"Bert Huijben" writes: >> -Original Message- >> From: br...@apache.org [mailto:br...@apache.org] >> Sent: zondag 16 december 2012 23:43 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1422706 - in /subversion/trunk/subversion: >> libsvn_subr/opt.c tests/cmdline/svntest/main.

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Stefan Sperling
On Sun, Dec 16, 2012 at 10:43:26PM -, br...@apache.org wrote: > Author: brane > Date: Sun Dec 16 22:43:25 2012 > New Revision: 1422706 > > URL: http://svn.apache.org/viewvc?rev=1422706&view=rev > Log: > Print a warning in "svn --version" if plaintext password storage is enabled. One more rema

RE: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Bert Huijben
> -Original Message- > From: br...@apache.org [mailto:br...@apache.org] > Sent: zondag 16 december 2012 23:43 > To: comm...@subversion.apache.org > Subject: svn commit: r1422706 - in /subversion/trunk/subversion: > libsvn_subr/opt.c tests/cmdline/svntest/main.py > > Author: brane > Date: S

Re: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Stefan Sperling
On Mon, Dec 17, 2012 at 08:47:43AM +, Bert Huijben wrote: > I think we should suppress this warning on Windows when the CryptoAPI > encryption is enabled (read: +- always) to avoid unneeded user questions. Also, the warning is printed even if plaintext password storage is disabled at runtime v

RE: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-17 Thread Bert Huijben
I think we should suppress this warning on Windows when the CryptoAPI encryption is enabled (read: +- always) to avoid unneeded user questions. And I’m not sure what to think of the color escape strings... Do these work on any not Windows os with any terminal settings? (We currently only use thes