Re: [PATCH] Rough cut at update-move support for properties

2012-12-07 Thread Julian Foad
In r1418585 I committed a much better version of this, and a test which passes. It's still not right -- it's putting the props into the DB immediately, whereas it should be adding another work item to the work queue instead -- but it's a start. - Julian >> Julian Foad wrote: >>> I'm just po

Re: Literals in wc SQLite queries

2012-12-07 Thread Julian Foad
Greg Stein wrote: > That sounds like a great idea! +1 > > It shouldn't be hard to tweak transform_sql.py. If you have a specific > prefix for the "token" symbols (eg TOKEN_BASE_DELETED), then we can > have the transform script simply look for lines like you suggest in > (say) wc_db.h. If the sear

Re: Literals in wc SQLite queries

2012-12-07 Thread Greg Stein
That sounds like a great idea! +1 It shouldn't be hard to tweak transform_sql.py. If you have a specific prefix for the "token" symbols (eg TOKEN_BASE_DELETED), then we can have the transform script simply look for lines like you suggest in (say) wc_db.h. If the search regex is strong enough, then

Re: [PATCH] Missing Binding for svn_checksum_t

2012-12-07 Thread Shivani Poddar
On Sat, Dec 8, 2012 at 1:51 AM, Ben Reser wrote: > On Thu, Dec 6, 2012 at 2:40 PM, Shivani Poddar > wrote: > > Log Message: > > subversion/bindings/swig/include > > (svn_checksum_t.swg) : Generated a typemap. > > (svn_checksum_kind_t,svn_checksum_create,svn_checksum_clear): typemapped > > these

Re: [PATCH] Missing Binding for svn_checksum_t

2012-12-07 Thread Ben Reser
On Thu, Dec 6, 2012 at 2:40 PM, Shivani Poddar wrote: > Log Message: > subversion/bindings/swig/include > (svn_checksum_t.swg) : Generated a typemap. > (svn_checksum_kind_t,svn_checksum_create,svn_checksum_clear): typemapped > these functions > > Suggested by: Stefan Sperling > Ben

Literals in wc SQLite queries

2012-12-07 Thread Philip Martin
Columns such as nodes.kind, nodes.presence, etc. have strings that should be one of a discrete set of values. When we bind these columns in C code we use something like: svn_sqlite__bindf("t", presence_map, svn_wc__db_status_normal); This means we only use known values (svn_wc__db_status_nor

Re: [PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread vijay
Thanks, Philip and Julian. I will explain things clearly in future patches. Thanks & Regards, Vijayaguru On Friday 07 December 2012 10:02 PM, Julian Foad wrote: Philip Martin wrote: Philip Martin writes: The logging is really just a side-effect. We setup this structure in several pla

Re: [PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread Julian Foad
Philip Martin wrote: > Philip Martin writes: >> The logging is really just a side-effect.  We setup this structure in >> several places and set the path member to a path.  In one place we put a >> full URL in by mistake.  As far as I can tell the member is supposed to >> be a path and the URL

Re: [PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread Julian Foad
Philip Martin wrote: > Julian Foad writes: >>   The mod_dav_svn replay report was logging the entire session >>   URL in the httpd access log.  Make it do what it is supposed >>   to do, which is log just the path-within-repos. > > The logging is really just a side-effect.  We setup this stru

Re: [PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread Philip Martin
Philip Martin writes: > Julian Foad writes: > >>   The mod_dav_svn replay report was logging the entire session >>   URL in the httpd access log.  Make it do what it is supposed >>   to do, which is log just the path-within-repos. > > The logging is really just a side-effect. We setup this stru

Re: [PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread Philip Martin
Julian Foad writes: >   The mod_dav_svn replay report was logging the entire session >   URL in the httpd access log.  Make it do what it is supposed >   to do, which is log just the path-within-repos. The logging is really just a side-effect. We setup this structure in several places and set t

Re: [PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread Julian Foad
Philip Martin wrote: > Julian Foad writes: >> Philip Martin >>> vijay writes:   Attached the patch and log message. >>> >>> Committed in r1418322. Thanks! >> >> Hi Philip and Vijay. >> >> Your log message: >> [[[ >> * subversion/libsvn_ra_serf/replay.c >>   (svn_ra_serf__replay,

Re: [PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread Philip Martin
Julian Foad writes: > Philip Martin >> vijay writes: >>>  Attached the patch and log message. >> >> Committed in r1418322. Thanks! > > Hi Philip and Vijay. > > Your log message: > [[[ > * subversion/libsvn_ra_serf/replay.c >   (svn_ra_serf__replay, svn_ra_serf__replay_range): Replace the >    

Re: [PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread Julian Foad
Philip Martin > vijay writes: >>  Attached the patch and log message. > > Committed in r1418322. Thanks! Hi Philip and Vijay. Your log message: [[[ * subversion/libsvn_ra_serf/replay.c   (svn_ra_serf__replay, svn_ra_serf__replay_range): Replace the     session url string with the request path

Re: [PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread Philip Martin
vijay writes: > Attached the patch and log message. Committed in r1418322. Thanks! -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download

[PATCH] Replay report logs the entire session url in httpd access log

2012-12-07 Thread vijay
Hi, The REPORT request during replay is being logged in httpd access log with the entire session url instead of the request path portion of the url. E.g, Now the REPORT request during 'svnsync sync' or 'svnrdump dump' is logged in httpd access log as follows. 127.0.0.1 - jrandom [07/Dec/2

Re: [PATCH] Rough cut at update-move support for properties

2012-12-07 Thread Julian Foad
Ben Reser > Julian Foad wrote: >> I'm just posting this so you (Philip et el.) can take a look if you >> want to.  I might proceed by extending the tests to check props and >> then committing it if it works, but really I want to factor it better >> -- maybe by reusing svn_wc_merge5() or the gut

Re: [PATCH] Missing Binding for svn_checksum_t

2012-12-07 Thread Shivani Poddar
On Fri, Dec 7, 2012 at 2:32 PM, Daniel Shahaf wrote: > > Index: svn_checksum_t.swg > > === > > --- svn_checksum_t.swg(revision 0) > > +++ svn_checksum_t.swg(revision 0) > > @@ -0,0 +1,47 @@ > > +%module checksum/** >

Re: [PATCH] Missing Binding for svn_checksum_t

2012-12-07 Thread Daniel Shahaf
> Index: svn_checksum_t.swg > === > --- svn_checksum_t.swg(revision 0) > +++ svn_checksum_t.swg(revision 0) > @@ -0,0 +1,47 @@ > +%module checksum/** > + * TYPE: svn_checksum_t.; functions typemapped svn_checksum_t ;