Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Martin Furter
On 11/30/12 00:55, Eric S. Raymond wrote: Ben Reser: The only thing that's really lacking here is a good way to pass along extra property values in an easy to configure way per server/repository so that you can use a client defined value to put it in svn:author. I don't really see adding suppor

Re: svn commit: r1415451 [1/9] - in /subversion/branches/fsfs-format7/subversion/libsvn_fs_fs: fs.c fs_fs.c fs_fs.h low_level.c low_level.h rep-cache.c revprops.c revprops.h util.c util.h

2012-11-29 Thread Peter Samuelson
[stef...@apache.org] > * subversion/libsvn_fs_fs/util.h > (RECOVERABLE_RETRY_COUNT, [...] >move_into_place): lib-locally declare functions previously >private in fs_fs.c This is a problem - on many OSes[*], all global functions and variables that are not 'static', i.e., anything not

RE: 1.8 Progress

2012-11-29 Thread Gavin Baumanis
[...] > > 3) libsvn_ra_serf stabilization. I know there have been a couple > > concerns that Philip has raised (EAGAIN and the random failures). > > Philip and Ivan both seem keen on reinstating ra_neon. [GB: ] Hi Everyone, I realise I am non-committer to SVN - but am a Software Developer none

Re: svn commit: r1415365 - in /subversion/trunk/subversion: svn/info-cmd.c tests/cmdline/info_tests.py

2012-11-29 Thread Daniel Shahaf
cmpil...@apache.org wrote on Thu, Nov 29, 2012 at 20:44:48 -: > Author: cmpilato > Date: Thu Nov 29 20:44:47 2012 > New Revision: 1415365 > > URL: http://svn.apache.org/viewvc?rev=1415365&view=rev > Log: > Show the ^/foo/bar repository relative URL of the item in 'svn info' > output. > > * su

Re: [PATCH] match svnauthz-validate exit code to --help promise

2012-11-29 Thread Daniel Shahaf
C. Michael Pilato wrote on Thu, Nov 29, 2012 at 14:58:07 -0500: > On 10/09/2012 02:29 PM, Daniel Shahaf wrote: > > svnauthz-validate --help promises exitcode==2 in most code paths: > > r1415344. Thanks.

Re: [PATCH] svn property name test functions

2012-11-29 Thread Julian Foad
I (Julian Foad) wrote: > Nothing terribly exciting to see here.  I'm posting these patches just in > case someone wants to comment or pick them up, because I won't be able to > finish them today, or if Brane wants to take note because it's relevant to > the property name testing in his recent p

[PATCH] svn property name test functions

2012-11-29 Thread Julian Foad
Nothing terribly exciting to see here.  I'm posting these patches just in case someone wants to comment or pick them up, because I won't be able to finish them today, or if Brane wants to take note because it's relevant to the property name testing in his recent prop-name spell-check code. The

Re: 1.8 Progress

2012-11-29 Thread C. Michael Pilato
[I'm going to try to summarize the body of responses generated from this original query -- a conversational reset, if you will -- so as to keep this line of inquiry moving toward closure.] On 11/01/2012 02:42 PM, Ben Reser wrote: > Looking at our roadmap we have the following things still in progr

Re: [PATCH] match svnauthz-validate exit code to --help promise

2012-11-29 Thread C. Michael Pilato
On 10/09/2012 02:29 PM, Daniel Shahaf wrote: > svnauthz-validate --help promises exitcode==2 in most code paths: r1415344. -- C. Michael Pilato CollabNet <> www.collab.net <> Enterprise Cloud Development signature.asc Description: OpenPGP digital signature

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Eric S. Raymond
Ben Reser : > The only thing that's really lacking here is a good way to pass along > extra property values in an easy to configure way per > server/repository so that you can use a client defined value to put it > in svn:author. I don't really see adding support for something like > that as terri

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Ben Reser
On Thu, Nov 29, 2012 at 5:49 AM, Eric S. Raymond wrote: > I say break the hell out of it. The utility of Internet-scoped > attributions is pretty high in a bunch of different ways (I love me > some Ohloh statistics, there's one). And I doubt "server > verification" actually buys you much. Whete

Re: Serf crashes on fork

2012-11-29 Thread C. Michael Pilato
Perhaps this should be discussed on the serf dev list? Or an issue filed in their tracker? On 11/19/2012 10:09 AM, Stefan Fuhrmann wrote: > On Mon, Nov 19, 2012 at 2:44 PM, Philip Martin > wrote: > > Philip Martin >

Re: svn commit: r1414880 - /subversion/trunk/subversion/libsvn_client/merge.c

2012-11-29 Thread Paul Burba
On Wed, Nov 28, 2012 at 8:27 PM, C. Michael Pilato wrote: > On 11/28/2012 03:39 PM, Julian Foad wrote: >> @@ -2425,10 +2441,8 @@ merge_dir_added(svn_wc_notify_state_t *s >>> } >>>else >>> { >>> - const char *added_path = apr_pstrdup(merge_b->pool,

Re: svn commit: r1414880 - /subversion/trunk/subversion/libsvn_client/merge.c

2012-11-29 Thread C. Michael Pilato
On 11/28/2012 08:27 PM, C. Michael Pilato wrote: > Paul: have you any opinions here? To summarize, I'm wondering why, in > merge_dir_added(), in the switch that begins like so: > > /* Switch on the on-disk state of this path */ > switch (kind) > > ... the merged addition of a brand new dire

Re: Regression tests FAILs with older format repositories

2012-11-29 Thread Julian Foad
Philip Martin wrote: > Julian Foad writes: >> Philip Martin wrote: >>> $ ./fs-test --server-minor-version=4 34 >>> lt-fs-test: ../src/subversion/libsvn_subr/dirent_uri.c:1456: >>> svn_relpath_skip_ancestor: Assertion >>> `relpath_is_canonical(parent_relpath)' failed. >> >> OK, I'll investi

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Eric S. Raymond
Daniel Shahaf : > I don't see the kludge here --- git has a "author" != "committer" > distinction, svn doesn't, so if you want to grow that distinction the > most natural way is a new property. Storing additional information in > svn:author is a separate issue. See my advocacy to Branko of going

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Eric S. Raymond
Branko Čibej : > Well, I find that we don't actually spell out anywhere that svn:author > can be pretty much any UTF-8 string. It can even contain newlines, > although that's not recommended. No kidding. That's an edge case *I* surely wouldn't want to screw with. > Hint: svn commit --with-revpr

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Daniel Shahaf
Philip Martin wrote on Thu, Nov 29, 2012 at 13:27:09 +: > Daniel Shahaf writes: > > > Specifically, the server code special-cases svn:author and svn:date --- > > an administrator would have to use a pre-commit hook (or patch the > > server) to avoid those being set from the authentication inf

AW: reposurgeon now writes Subversion repositories

2012-11-29 Thread Markus Schaber
Hi, Von: Eric S. Raymond [mailto:e...@thyrsus.com] > > How does reposurgeon handle empty directories with (node) properties? > > Currently by ignoring all of them except svn:ignore, which it turns > into .gitignore content on the gitspace side. And now vice-versa, too. > > Not clear what else i

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Daniel Shahaf
(note, other half of the thread is on dev@svn only..) Eric S. Raymond wrote on Thu, Nov 29, 2012 at 06:46:37 -0500: > Daniel Shahaf : > > You might also seek community consensus to reserve an svn:foo name for > > the "original author" property --- perhaps svn:original-author --- so > > that reposu

Re: svn commit: r1414728 - in /subversion/trunk: ./ build/generator/ subversion/bindings/cxxhl/ subversion/bindings/cxxhl/include/ subversion/bindings/cxxhl/include/types/ subversion/bindings/cxxhl/sr

2012-11-29 Thread Branko Čibej
On 29.11.2012 14:22, Hyrum K Wright wrote: > On Wed, Nov 28, 2012 at 3:10 PM, Branko Čibej wrote: > >> On 28.11.2012 17:15, Philip Martin wrote: >>> Branko Čibej writes: >>> On 28.11.2012 15:39, br...@apache.org wrote: > Author: brane > Date: Wed Nov 28 14:39:42 2012 > New Revisi

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Philip Martin
Daniel Shahaf writes: > Specifically, the server code special-cases svn:author and svn:date --- > an administrator would have to use a pre-commit hook (or patch the > server) to avoid those being set from the authentication info and system > clock. - for RA access (a network client like svn) t

Re: svn commit: r1414728 - in /subversion/trunk: ./ build/generator/ subversion/bindings/cxxhl/ subversion/bindings/cxxhl/include/ subversion/bindings/cxxhl/include/types/ subversion/bindings/cxxhl/sr

2012-11-29 Thread Hyrum K Wright
On Wed, Nov 28, 2012 at 3:10 PM, Branko Čibej wrote: > On 28.11.2012 17:15, Philip Martin wrote: > > Branko Čibej writes: > > > >> On 28.11.2012 15:39, br...@apache.org wrote: > >>> Author: brane > >>> Date: Wed Nov 28 14:39:42 2012 > >>> New Revision: 1414728 > >>> > >>> URL: http://svn.apache.

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Daniel Shahaf
Branko Čibej wrote on Thu, Nov 29, 2012 at 13:41:34 +0100: > On 29.11.2012 12:46, Eric S. Raymond wrote: > > Daniel Shahaf : > >>> Subversion's metadata doesn't have separate author and committer > >>> properties, and doesn't store anything but a Unix user ID as > >>> attribution. I don't see any

Re: Regression tests FAILs with older format repositories

2012-11-29 Thread Philip Martin
Daniel Shahaf writes: > Philip Martin wrote on Wed, Nov 28, 2012 at 15:55:44 +: >> -Warning: 'post-commit' hook failed with error output: >> +Warning: post-commit hook failed (exit code 1) with output: >> >> I've not investigated why the error message is different. > > Maybe it's the same co

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Branko Čibej
On 29.11.2012 12:46, Eric S. Raymond wrote: > Daniel Shahaf : >>> Subversion's metadata doesn't have separate author and committer >>> properties, and doesn't store anything but a Unix user ID as >>> attribution. I don't see any way around this. >> You're not fully informed, then. >> >> 1) svn:aut

Re: Regression tests FAILs with older format repositories

2012-11-29 Thread Philip Martin
Philip Martin writes: > We are passing fspaths to a relpath function. The test passes in 1.7 > because svn_relpath_skip_ancestor doesn't assert that the paths are > relpaths and works if passed fspaths. svn_relpath__is_child, not svn_relpath_skip_ancestor. -- Philip

Re: Regression tests FAILs with older format repositories

2012-11-29 Thread Philip Martin
Julian Foad writes: > Philip Martin wrote: >> The more significant fail >> is: >> >> $ ./fs-test --server-minor-version=4 34 >> lt-fs-test: ../src/subversion/libsvn_subr/dirent_uri.c:1456: >> svn_relpath_skip_ancestor: Assertion `relpath_is_canonical(parent_relpath)' >> failed. > > OK, I'll in

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Eric S. Raymond
Daniel Shahaf : > > Subversion's metadata doesn't have separate author and committer > > properties, and doesn't store anything but a Unix user ID as > > attribution. I don't see any way around this. > > You're not fully informed, then. > > 1) svn:author revprops can contain any UTF-8 string. T

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Branko Čibej
On 29.11.2012 08:58, Daniel Shahaf wrote: > I think you're saying that adds might turn into copies, and > vice-versa. That is something users would notice --- it is certainly > exposed in the UI --- even though node-id's are not exposed to clients. ... yet. But there are plans underway to expose

Re: reposurgeon now writes Subversion repositories

2012-11-29 Thread Daniel Shahaf
Eric S. Raymond wrote on Thu, Nov 29, 2012 at 00:59:45 -0500: > In summary, Subversion repository histories do not round-trip through > reposurgeon editing. File content changes are preserved but some > metadata is unavoidably lost. Furthermore, writing out a DVCS history > in Subversion a