Re: svnmucc: add comment marker ?

2012-11-24 Thread Daniel Shahaf
sebb wrote on Sun, Nov 25, 2012 at 00:59:34 +: > No, the idea was that # should only be recognised when expecting an action. Sounds good to me.

Re: svnmucc: add comment marker ?

2012-11-24 Thread sebb
On 24 November 2012 12:36, Daniel Shahaf wrote: > sebb wrote on Sat, Nov 24, 2012 at 11:33:01 +: >> svnmucc can be used to read commands from files. >> >> It would be handy to be able to add comments to files. >> One could use a # marker as an indication that the rest of the line is >> a comme

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-24 Thread Branko Čibej
The latest change takes account of property name similarity. So for example, svn propset svn:foobar . will emit an error but will not suggest an alternative spelling, whereas svn propset svn:ignores . will suggest two, svn:ignore and svn:global-ignores. The only open question now, IMO,

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-24 Thread Branko Čibej
On 24.11.2012 15:20, Daniel Shahaf wrote: > Branko Čibej wrote on Sat, Nov 24, 2012 at 13:38:39 +0100: >> On 24.11.2012 13:30, Daniel Shahaf wrote: >>> Branko Čibej wrote on Sat, Nov 24, 2012 at 12:33:01 +0100: I'm also considering requiring --force if one tries to use a revision property

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-24 Thread Daniel Shahaf
Branko Čibej wrote on Sat, Nov 24, 2012 at 13:38:39 +0100: > On 24.11.2012 13:30, Daniel Shahaf wrote: > > Branko Čibej wrote on Sat, Nov 24, 2012 at 12:33:01 +0100: > >> I'm also considering requiring --force if one tries to use a revision > >> property name as a node property, and vice versa. > >

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-24 Thread Branko Čibej
On 24.11.2012 13:30, Daniel Shahaf wrote: > Branko Čibej wrote on Sat, Nov 24, 2012 at 12:33:01 +0100: >> I'm also considering requiring --force if one tries to use a revision >> property name as a node property, and vice versa. >> > +0 > >> $ svn ps svn:barfoo x . >> svn: E195011: 'svn:barfoo' is

Re: svnmucc: add comment marker ?

2012-11-24 Thread Daniel Shahaf
sebb wrote on Sat, Nov 24, 2012 at 11:33:01 +: > svnmucc can be used to read commands from files. > > It would be handy to be able to add comments to files. > One could use a # marker as an indication that the rest of the line is > a comment (this cannot be confused with an existing action). >

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-24 Thread Daniel Shahaf
Branko Čibej wrote on Sat, Nov 24, 2012 at 12:33:01 +0100: > I'm also considering requiring --force if one tries to use a revision > property name as a node property, and vice versa. > +0 > $ svn ps svn:barfoo x . > svn: E195011: 'svn:barfoo' is not a valid svn: property name; did you mean > 's

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-24 Thread Stefan Sperling
On Fri, Nov 23, 2012 at 11:22:44AM -0800, Ben Reser wrote: > On Fri, Nov 23, 2012 at 9:09 AM, Branko Čibej wrote: > > No. The check specifically looks for a three-letter prefix ending in a > > colon, and allows only one wrong character or transposition. It will > > flag svm: but not tsvn:. > > sv

Re: svn commit: r1413109 - in /subversion/trunk: ./ subversion/svnrdump/svnrdump.c subversion/svnrdump/svnrdump.h

2012-11-24 Thread Hyrum K Wright
On Fri, Nov 23, 2012 at 7:44 PM, Branko Čibej wrote: > On 24.11.2012 01:39, hwri...@apache.org wrote: > > Author: hwright > > Date: Sat Nov 24 00:39:38 2012 > > New Revision: 1413109 > > > > URL: http://svn.apache.org/viewvc?rev=1413109&view=rev > > Log: > > Cherrypick r1413107 from the ev2-expor

Re: svn commit: r1411629 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2012-11-24 Thread Hyrum K Wright
Sure, if philip thinks it's appropriate. On Sat, Nov 24, 2012 at 1:08 AM, Daniel Shahaf wrote: > Revert r1412515 then? > > Hyrum K Wright wrote on Fri, Nov 23, 2012 at 15:29:32 -0500: > > I did a little poking and fixed this in r1413046. > > > > > > On Fri, Nov 23, 2012 at 2:18 PM, Hyrum K Wrigh

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

2012-11-24 Thread Branko Čibej
On 23.11.2012 18:09, Branko Čibej wrote: > I agree that looking at the prefix is dicey, ... ... so I've tightened up the prefix matching so that --force is required only when: * the prefix is exactly 3 letters long (propname[3] == ':'); * and the first three letters differ in only one change

svnmucc: add comment marker ?

2012-11-24 Thread sebb
svnmucc can be used to read commands from files. It would be handy to be able to add comments to files. One could use a # marker as an indication that the rest of the line is a comment (this cannot be confused with an existing action). This should be simple to implement if it's thought to be usef