Re: svn commit: r1398599 - /subversion/trunk/subversion/svndumpfilter/main.c

2012-10-15 Thread Philip Martin
stef...@apache.org writes: > Author: stefan2 > Date: Tue Oct 16 01:13:14 2012 > New Revision: 1398599 > > URL: http://svn.apache.org/viewvc?rev=1398599&view=rev > Log: > * subversion/svndumpfilter/main.c > (create_stdio_stream): fix memory class warning under Windows This appears to cause a bui

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Stefan Fuhrmann
On Tue, Oct 16, 2012 at 5:51 AM, Branko Čibej wrote: > On 15.10.2012 17:14, Stefan Fuhrmann wrote: > > However, if you have a long-running process like a server, that race > > condition extends now extends over its whole lifetime. I.e. once a > > revprop got read, any change to its value by a pre

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Branko Čibej
On 15.10.2012 17:14, Stefan Fuhrmann wrote: > However, if you have a long-running process like a server, that race > condition extends now extends over its whole lifetime. I.e. once a > revprop got read, any change to its value by a pre-1.8 tool may never > get detected. Ouch. This seems wrong. I'

Re: [Issue 4246] hotcopy of packed revprops in FSFS f6

2012-10-15 Thread Daniel Shahaf
On Tue, Oct 16, 2012 at 03:16:23AM +0200, Stefan Fuhrmann wrote: > On Tue, Oct 16, 2012 at 1:28 AM, Daniel Shahaf wrote: > > > danie...@tigris.org wrote on Mon, Oct 15, 2012 at 16:21:37 -0700: > > > http://subversion.tigris.org/issues/show_bug.cgi?id=4246 > > > > > > In short, hotcopy fails becaus

Re: [Issue 4246] hotcopy of packed revprops in FSFS f6

2012-10-15 Thread Stefan Fuhrmann
On Tue, Oct 16, 2012 at 1:28 AM, Daniel Shahaf wrote: > danie...@tigris.org wrote on Mon, Oct 15, 2012 at 16:21:37 -0700: > > http://subversion.tigris.org/issues/show_bug.cgi?id=4246 > > > > In short, hotcopy fails because r1's revprops have been packed. > > If anyone wonders how I found this: I r

Re: svn commit: r1398389 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_subr/ libsvn_wc/ svn/ tests/libsvn_wc/

2012-10-15 Thread Julian Foad
> URL: http://svn.apache.org/viewvc?rev=1398389&view=rev > Log: > Enable SQLite exclusive locking for the command line client as this is [...] This deprecates svn_client_config_create() and adds /** Initialize a client context.  * Set @a *ctx to a client context object, allocated in @a pool,

Re: svn commit: r1398389 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_subr/ libsvn_wc/ svn/ tests/libsvn_wc/

2012-10-15 Thread Philip Martin
Daniel Shahaf writes: > phi...@apache.org wrote on Mon, Oct 15, 2012 at 17:09:02 -: >> Author: philip >> Date: Mon Oct 15 17:09:01 2012 >> New Revision: 1398389 >> >> URL: http://svn.apache.org/viewvc?rev=1398389&view=rev >> Log: >> Enable SQLite exclusive locking for the command line client

Re: svn commit: r1398541 - /subversion/branches/1.7.x/STATUS

2012-10-15 Thread Philip Martin
Daniel Shahaf writes: > phi...@apache.org wrote on Mon, Oct 15, 2012 at 22:20:32 -: >> Author: philip >> Date: Mon Oct 15 22:20:32 2012 >> New Revision: 1398541 >> >> URL: http://svn.apache.org/viewvc?rev=1398541&view=rev >> Log: >> * STATUS: Clarify effect of r1237779. >> >> Modified: >>

Re: svn commit: r1398389 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_subr/ libsvn_wc/ svn/ tests/libsvn_wc/

2012-10-15 Thread Daniel Shahaf
phi...@apache.org wrote on Mon, Oct 15, 2012 at 17:09:02 -: > Author: philip > Date: Mon Oct 15 17:09:01 2012 > New Revision: 1398389 > > URL: http://svn.apache.org/viewvc?rev=1398389&view=rev > Log: > Enable SQLite exclusive locking for the command line client as this is > > +"### Se

Re: svn commit: r1398541 - /subversion/branches/1.7.x/STATUS

2012-10-15 Thread Daniel Shahaf
phi...@apache.org wrote on Mon, Oct 15, 2012 at 22:20:32 -: > Author: philip > Date: Mon Oct 15 22:20:32 2012 > New Revision: 1398541 > > URL: http://svn.apache.org/viewvc?rev=1398541&view=rev > Log: > * STATUS: Clarify effect of r1237779. > > Modified: > subversion/branches/1.7.x/STATUS

Re: revprop packing question

2012-10-15 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Oct 16, 2012 at 02:24:12 +0200: > libsvn_fs_fs/structure says that a pack file starts with an > svndiff-encoded integer. Where is that integer written, please? > I meant, "Where is the code that writes that integer". > serialize_revprops_header() doesn't write an svn

revprop packing question

2012-10-15 Thread Daniel Shahaf
libsvn_fs_fs/structure says that a pack file starts with an svndiff-encoded integer. Where is that integer written, please? serialize_revprops_header() doesn't write an svndiff-encoded integer, so I suspect the two binary bytes at the start of a revprops pack file are actually an artifact of zlib

Re: [Issue 4246] hotcopy of packed revprops in FSFS f6

2012-10-15 Thread Daniel Shahaf
danie...@tigris.org wrote on Mon, Oct 15, 2012 at 16:21:37 -0700: > http://subversion.tigris.org/issues/show_bug.cgi?id=4246 > > In short, hotcopy fails because r1's revprops have been packed. If anyone wonders how I found this: I read r1358721:1358725, noticed that upgrade/pack/recover were ment

API simplification opportunity Re: svn commit: r1348666 - in /subversion/trunk/subversion: include/ libsvn_delta/ libsvn_fs_fs/ libsvn_ra/ tests/libsvn_delta/

2012-10-15 Thread Daniel Shahaf
stef...@apache.org wrote on Sun, Jun 10, 2012 at 21:34:22 -: > Author: stefan2 > Date: Sun Jun 10 21:34:21 2012 > New Revision: 1348666 > > URL: http://svn.apache.org/viewvc?rev=1348666&view=rev > Log: > When handing out node contents, the delta streams don't need > to calculate MD5 checksums

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Philip Martin
Philip Martin writes: > Stefan Fuhrmann writes: > >> On Mon, Oct 15, 2012 at 7:36 PM, Daniel Shahaf >> wrote: >> >>> (It also has the pretty odd side effect that it's not safe to run >>> 'svnadmin1.7 setrevprop' and 'svnadmin1.8 dump' concurrently on the >>> same repository...) >>> >> >> That's

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Philip Martin
Stefan Fuhrmann writes: > On Mon, Oct 15, 2012 at 7:36 PM, Daniel Shahaf wrote: > >> (It also has the pretty odd side effect that it's not safe to run >> 'svnadmin1.7 setrevprop' and 'svnadmin1.8 dump' concurrently on the >> same repository...) >> > > That's a misrepresentation of what is going o

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Stefan Fuhrmann
On Mon, Oct 15, 2012 at 7:36 PM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Mon, Oct 15, 2012 at 19:32:57 +0200: > > On Mon, Oct 15, 2012 at 7:10 PM, Daniel Shahaf >wrote: > > > > > Daniel Shahaf wrote on Sun, Apr 29, 2012 at 12:58:56 +0300: > > > > stef...@apache.org wrote on Sun, Apr 29, 2

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread C. Michael Pilato
On 10/15/2012 01:36 PM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Mon, Oct 15, 2012 at 19:32:57 +0200: >> On Mon, Oct 15, 2012 at 7:10 PM, Daniel Shahaf >> wrote: >>> What happens if 'svnadmin1.7 setrevprop' is run while a 1.8 server is >>> running? Will the 1.8 server miss svnadmin1.7's ch

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Mon, Oct 15, 2012 at 19:32:57 +0200: > On Mon, Oct 15, 2012 at 7:10 PM, Daniel Shahaf wrote: > > > Daniel Shahaf wrote on Sun, Apr 29, 2012 at 12:58:56 +0300: > > > stef...@apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -: > > > > Author: stefan2 > > > > Date: Sun A

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Stefan Fuhrmann
On Mon, Oct 15, 2012 at 7:10 PM, Daniel Shahaf wrote: > Daniel Shahaf wrote on Sun, Apr 29, 2012 at 12:58:56 +0300: > > stef...@apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -: > > > Author: stefan2 > > > Date: Sun Apr 29 09:12:48 2012 > > > New Revision: 1331883 > > > > > > URL: http://sv

Re: svn commit: r1331883 - /subversion/trunk/subversion/svnadmin/main.c

2012-10-15 Thread Daniel Shahaf
Daniel Shahaf wrote on Sun, Apr 29, 2012 at 12:58:56 +0300: > stef...@apache.org wrote on Sun, Apr 29, 2012 at 09:12:49 -: > > Author: stefan2 > > Date: Sun Apr 29 09:12:48 2012 > > New Revision: 1331883 > > > > URL: http://svn.apache.org/viewvc?rev=1331883&view=rev > > Log: > > SvnAdmin shoul

Re: #if/#ifdef mismatches

2012-10-15 Thread Daniel Shahaf
Ben Reser wrote on Mon, Oct 15, 2012 at 11:44:14 -0400: > On Mon, Oct 15, 2012 at 10:43 AM, Daniel Shahaf > wrote: > > Found these two: > > > > subversion/libsvn_subr/cache_config.c:#ifdef APR_HAS_THREADS > > subversion/svnserve/main.c:#ifdef APR_HAS_THREADS > > > > (which should use #if, not #if

Re: #if/#ifdef mismatches

2012-10-15 Thread Ben Reser
On Mon, Oct 15, 2012 at 10:43 AM, Daniel Shahaf wrote: > Found these two: > > subversion/libsvn_subr/cache_config.c:#ifdef APR_HAS_THREADS > subversion/svnserve/main.c:#ifdef APR_HAS_THREADS > > (which should use #if, not #ifdef) > > I don't have time to audit the entire tree --- I checked only th

#if/#ifdef mismatches

2012-10-15 Thread Daniel Shahaf
Found these two: subversion/libsvn_subr/cache_config.c:#ifdef APR_HAS_THREADS subversion/svnserve/main.c:#ifdef APR_HAS_THREADS (which should use #if, not #ifdef) I don't have time to audit the entire tree --- I checked only these two libraries and this one macro, not all source files and all ma

Re: svn commit: r1398252 - /subversion/trunk/subversion/libsvn_subr/error.c

2012-10-15 Thread Ben Reser
On Mon, Oct 15, 2012 at 10:18 AM, Ben Reser wrote: > On Mon, Oct 15, 2012 at 7:30 AM, wrote: >> Author: ivan >> Date: Mon Oct 15 11:30:08 2012 >> New Revision: 1398252 >> >> URL: http://svn.apache.org/viewvc?rev=1398252&view=rev >> Log: >> Make code a little bit more clear and faster. >> >> * su

Re: svn commit: r1398252 - /subversion/trunk/subversion/libsvn_subr/error.c

2012-10-15 Thread Ben Reser
On Mon, Oct 15, 2012 at 7:30 AM, wrote: > Author: ivan > Date: Mon Oct 15 11:30:08 2012 > New Revision: 1398252 > > URL: http://svn.apache.org/viewvc?rev=1398252&view=rev > Log: > Make code a little bit more clear and faster. > > * subversion/libsvn_subr/error.c > (svn_error_wrap_apr): Use apr_

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2012-10-15 Thread Mark Phippard
On Mon, Oct 15, 2012 at 7:59 AM, C. Michael Pilato wrote: > What solutions do we have? > > - Something automated? Can a slave server contact a master server with > a custom feature negotiation request and cache the results? Is this possible? Could we try to contact the master at server start

Re: svn commit: r1398147 - /subversion/trunk/subversion/svn/conflict-callbacks.c

2012-10-15 Thread C. Michael Pilato
On 10/15/2012 05:48 AM, Stefan Sperling wrote: > It feels good to argue about something entirely pointless for a change :) Indeed. You guys aren't even painting the bikeshed siding. You're painting the roofing sheets -- which will be immediately and completely covered with tar paper and shingles

Re: svn commit: r1397993 - /subversion/branches/http-dynamic-prop-namespaces/BRANCH-README

2012-10-15 Thread C. Michael Pilato
On 10/14/2012 01:22 PM, Daniel Shahaf wrote: >> +Note that Bert will probably suggest soon that there be a way to flip >> +off the server-side support for this to accomodate WebDAV proxy >> +configurations where the slave and master are of different pedigrees. > > Do we actually support this? I r

WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2012-10-15 Thread C. Michael Pilato
Fellow devs, I begin my week feeling constrained by the little bits of extra work involved in keeping our WebDAV proxy support sane every time we add a feature that changes the protocol for write requests over DAV. The extra work isn't hard work: just add yet another httpd.conf option so admins

Re: svn commit: r1398147 - /subversion/trunk/subversion/svn/conflict-callbacks.c

2012-10-15 Thread Stefan Sperling
On Sun, Oct 14, 2012 at 11:20:48PM -, danie...@apache.org wrote: > Author: danielsh > Date: Sun Oct 14 23:20:48 2012 > New Revision: 1398147 > > URL: http://svn.apache.org/viewvc?rev=1398147&view=rev > Log: > Easter egg. > > * subversion/svn/conflict-callbacks.c > (handle_text_conflict): Us