Re: modify-file within an added tree (r1356317) ; possibly rep-cache.db -related

2012-07-09 Thread Trent Nelson
On 7/8/12 11:48 AM, "Daniel Shahaf" wrote: >Daniel Shahaf wrote on Sat, Jul 07, 2012 at 15:09:38 +0100: >> How can we have a 'modify-file' within an added-without-copyfrom tree? That's a pretty impressive invariant violation. Enversion would have caught it, but only because we assert that a m

Re: Revprop packing implemented

2012-07-09 Thread Trent Nelson
Hi Stefan, > This week I had one of my "how hard can it be?" moments > and finally implemented revprop packing Lots of tools, like svnsync, store metadata in r0 rev props. Could this rev be excluded from packing? What's the performance penalty for modifying a packed rev props? From what you'v

Re: Subtree mergeinfo -- what I learnt at the Hackathon

2012-07-09 Thread Julian Foad
To move forward and decide what behaviour is right, we need to be able to compare the 1.7 behaviour with the proposed behaviour in *specific* scenarios.  So we need to be able to enumerate the specific scenarios that we mean by the general term "merging with subtree mergeinfo".  This is what I a

Re: svn commit: r1358779 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-07-09 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Mon, Jul 09, 2012 at 10:18:35 +0200: > On Mon, Jul 9, 2012 at 1:40 AM, Bert Huijben wrote: > > Wasn't the fsfs fileformat architecture independent before this change? > > > > It still is. The problem was with the runtime presentation > of the pack file content. > Stefan,

Re: Measured: btrfs COW and sqlite exclusive locking

2012-07-09 Thread Daniel Shahaf
Mattias Engdegård wrote on Mon, Jul 09, 2012 at 09:40:48 +0200: > 8 jul 2012 kl. 19.26 skrev Daniel Shahaf: > > >Yes, please specify what the client used COW for. Was it for > >populating the working tree files from the pristine store? Was it for > >something else? > > It was only intended for

Re: svn commit: r1358022 - in /subversion/trunk: LICENSE NOTICE subversion/include/svn_utf.h subversion/libsvn_subr/utf_width.c subversion/svn/file-merge.c

2012-07-09 Thread Stefan Sperling
On Mon, Jul 09, 2012 at 04:04:42PM +0200, Johan Corveleyn wrote: > On Mon, Jul 9, 2012 at 3:30 PM, Stefan Sperling wrote: > > On Mon, Jul 09, 2012 at 02:47:25PM +0200, Bert Huijben wrote: > >> How do you check if the file you are merging is valid utf-8? > > > > See the merge_chunks() function. > >

Re: svn commit: r1358022 - in /subversion/trunk: LICENSE NOTICE subversion/include/svn_utf.h subversion/libsvn_subr/utf_width.c subversion/svn/file-merge.c

2012-07-09 Thread Johan Corveleyn
On Mon, Jul 9, 2012 at 3:30 PM, Stefan Sperling wrote: > On Mon, Jul 09, 2012 at 02:47:25PM +0200, Bert Huijben wrote: >> How do you check if the file you are merging is valid utf-8? > > See the merge_chunks() function. > > We convert data to UTF-8 from the native (locale) encoding. > This cannot

Re: svn commit: r1358022 - in /subversion/trunk: LICENSE NOTICE subversion/include/svn_utf.h subversion/libsvn_subr/utf_width.c subversion/svn/file-merge.c

2012-07-09 Thread Stefan Sperling
On Mon, Jul 09, 2012 at 02:47:25PM +0200, Bert Huijben wrote: > How do you check if the file you are merging is valid utf-8? See the merge_chunks() function. We convert data to UTF-8 from the native (locale) encoding. This cannot fail (every encoding can be represented in UTF-8) but the result mi

RE: svn commit: r1358022 - in /subversion/trunk: LICENSE NOTICE subversion/include/svn_utf.h subversion/libsvn_subr/utf_width.c subversion/svn/file-merge.c

2012-07-09 Thread Bert Huijben
> -Original Message- > From: s...@apache.org [mailto:s...@apache.org] > Sent: vrijdag 6 juli 2012 04:21 > To: comm...@subversion.apache.org > Subject: svn commit: r1358022 - in /subversion/trunk: LICENSE NOTICE > subversion/include/svn_utf.h subversion/libsvn_subr/utf_width.c > subversion

Re: Revprop packing implemented

2012-07-09 Thread Stefan Fuhrmann
On Mon, Jul 9, 2012 at 11:40 AM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > On Mon, Jul 9, 2012 at 9:19 AM, Philip Martin < > philip.mar...@wandisco.com>wrote: > > > >> Stefan Fuhrmann writes: > >> > >> > This week I had one of my "how hard can it be?" moments > >> > and finally implem

Re: Revprop packing implemented

2012-07-09 Thread Philip Martin
Stefan Fuhrmann writes: > On Mon, Jul 9, 2012 at 9:19 AM, Philip Martin > wrote: > >> Stefan Fuhrmann writes: >> >> > This week I had one of my "how hard can it be?" moments >> > and finally implemented revprop packing (did that mainly >> > offline). It passes all tests and seems to work pretty

Fwd: Revprop packing implemented

2012-07-09 Thread Stefan Fuhrmann
Effing gmail :( On Sun, Jul 8, 2012 at 2:28 AM, Hyrum K Wright wrote: > On Fri, Jul 6, 2012 at 3:32 AM, Stefan Fuhrmann > wrote: > > Hi devs, > > > > This week I had one of my "how hard can it be?" moments > > and finally implemented revprop packing (did that mainly > > offline). It passes all t

Re: Revprop packing implemented

2012-07-09 Thread Stefan Fuhrmann
On Mon, Jul 9, 2012 at 9:19 AM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > This week I had one of my "how hard can it be?" moments > > and finally implemented revprop packing (did that mainly > > offline). It passes all tests and seems to work pretty well. > > There are buildbot failure

Re: svn commit: r1358779 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-07-09 Thread Stefan Fuhrmann
On Mon, Jul 9, 2012 at 1:40 AM, Bert Huijben wrote: > > > > -Original Message- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: zondag 8 juli 2012 18:50 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1358779 - > > /subversion/trunk/subversion/libsvn_fs_f

Re: Measured: btrfs COW and sqlite exclusive locking

2012-07-09 Thread Mattias Engdegård
8 jul 2012 kl. 19.26 skrev Daniel Shahaf: Yes, please specify what the client used COW for. Was it for populating the working tree files from the pristine store? Was it for something else? It was only intended for that, but it's possible that the copying code is used for other purposes as

Re: Revprop packing implemented

2012-07-09 Thread Philip Martin
Stefan Fuhrmann writes: > This week I had one of my "how hard can it be?" moments > and finally implemented revprop packing (did that mainly > offline). It passes all tests and seems to work pretty well. There are buildbot failures, I don't know if they are caused by the packing code. valgrind