[PATCH] JavaHL: Reduce amount of duplicate code used to check C++ pointer extracted from the java object

2012-05-30 Thread Vladimir Berezniker
Patch 01 - Introduce macro [[[ JavaHL: Added CPPADDR_NULL_PTR macro to reduce amount of duplicate code checking C++ pointer extracted from the java object [ in subversion/bindings/javahl/native ] * JNIUtil.h (CPPADDR_NULL_PTR): New macro to test for NULL pointer and raise java exception if

Turning a merge graph into svn commands

2012-05-30 Thread Julian Foad
Just a toy a the moment, but the attached patch makes 'tools/dev/merge-graph.py' output a sequence of 'svn' commands that executes the branching and merging shown in the graph (as well as writing an image file). Example (where merge-sync-1-req.txt is one of the attachments to

Re: svn commit: r1340253 - /subversion/trunk/COMMITTERS

2012-05-30 Thread Vladimir Berezniker
1. I only plan to make this change for RA API. The change to existing code is a different question and I think it should be left alone because of backwards compatibility. 2. Code can still catch the runtime exception derived from SubversionRuntimeException just like it does with the checked except

Re: Symmetric Merge -- status

2012-05-30 Thread Julian Foad
Thanks, Paul! This is great.  You're right, the main thing seems to be that find_symmetric_merge is currently only fetching and analyzing the branch-root mergeinfo.  It needs to fetch and analyze all mergeinfo on the branch, finding a merge base for each subtree, and proceed something like this

Re: svn commit: r1340253 - /subversion/trunk/COMMITTERS

2012-05-30 Thread Mark Phippard
On Tue, May 29, 2012 at 8:32 PM, Blair Zajac wrote: > On 05/21/2012 04:18 AM, Vladimir Berezniker wrote: >> >> Hyrum, >> >> 4. Use runtime rather than checked exceptions. >> >>     I strongly dislike checked exceptions in code paths where there is >> no expected recovery logic that can be applied.

Re: svn commit: r1343456 - in /subversion/branches/javahl-ra/subversion/bindings/javahl/native: RevpropTable.cpp RevpropTable.h

2012-05-30 Thread Vladimir Berezniker
I will do as @dev decides. But to give context, at the moment there are 14 patches with first two already committed to the branch (mea culpa). 3 of the patches require manual svn copy command to apply since svn patch does not support conveying copy operation in the patch. Please don't be alarmed

Re: svn commit: r1340253 - /subversion/trunk/COMMITTERS

2012-05-30 Thread Vladimir Berezniker
To be clear, for now I am only proposing this for the new RA APIs. I would keep existing SVNClient and SVNRepos as is, because of backwards compatibility. However, given large amount of shared code this might not be practical. Yes, I propose that checked exceptions would be used in cases when clie