Re: [PATCH] issue #4134 (partial): sort deleted nodes before dumping them

2012-05-29 Thread Julian Foad
Greg Stein wrote: > On Tue, May 29, 2012 at 5:01 PM, Dustin Lang > wrote: >> ... >>> You can use svn_sort_compare_items_lexically because entries are single >>> path components that do not contain slashes. In which case >>> svn_sort_compare_items_as_paths produces the same result but is less

Re: svn commit: r1343456 - in /subversion/branches/javahl-ra/subversion/bindings/javahl/native: RevpropTable.cpp RevpropTable.h

2012-05-29 Thread Daniel Shahaf
Hyrum K Wright wrote on Tue, May 29, 2012 at 20:04:24 -0500: > On Tue, May 29, 2012 at 4:11 PM, Daniel Shahaf > wrote: > > Greg Stein wrote on Tue, May 29, 2012 at 16:28:19 -0400: > >> I would suggest any logical change that can apply to trunk should be > >> submitted to dev@. If it helps trunk,

Re: svn commit: r1343456 - in /subversion/branches/javahl-ra/subversion/bindings/javahl/native: RevpropTable.cpp RevpropTable.h

2012-05-29 Thread Hyrum K Wright
On Tue, May 29, 2012 at 4:11 PM, Daniel Shahaf wrote: > Greg Stein wrote on Tue, May 29, 2012 at 16:28:19 -0400: >> I would suggest any logical change that can apply to trunk should be >> submitted to dev@. If it helps trunk, or is at least neutral, then I'd >> support it. >> >> We couldn't digest

Re: svn commit: r1340253 - /subversion/trunk/COMMITTERS

2012-05-29 Thread Blair Zajac
On 05/21/2012 04:18 AM, Vladimir Berezniker wrote: Hyrum, 4. Use runtime rather than checked exceptions. I strongly dislike checked exceptions in code paths where there is no expected recovery logic that can be applied. This just forces people to either write a lot of try catch blocks that

Re: [PATCH] issue #4134 (partial): sort deleted nodes before dumping them

2012-05-29 Thread Greg Stein
On Tue, May 29, 2012 at 5:01 PM, Dustin Lang wrote: >... >> You can use svn_sort_compare_items_lexically because entries are single >> path components that do not contain slashes. In which case >> svn_sort_compare_items_as_paths produces the same result but is less >> efficient. > > The paths are

Re: Symmetric Merge -- status

2012-05-29 Thread Paul Burba
On Fri, May 25, 2012 at 12:08 PM, Julian Foad wrote: > Hi, all. > > I want to update you all on the "symmetric merge" [1] status and my plans, > and invite your thoughts and any assistance you can give. > > I'll be presenting this subject at Elego's SvnDay [2] and at WANdisco events > in October,

Re: svn commit: r1343456 - in /subversion/branches/javahl-ra/subversion/bindings/javahl/native: RevpropTable.cpp RevpropTable.h

2012-05-29 Thread Daniel Shahaf
Greg Stein wrote on Tue, May 29, 2012 at 16:28:19 -0400: > I would suggest any logical change that can apply to trunk should be > submitted to dev@. If it helps trunk, or is at least neutral, then I'd > support it. > > We couldn't digest your initial 27 patches :-), but some minor ones showing > u

Re: [PATCH] issue #4134 (partial): sort deleted nodes before dumping them

2012-05-29 Thread Dustin Lang
Hi Stefan, Thanks for the constructive review! I accept your nits, but have one comment: You can use svn_sort_compare_items_lexically because entries are single path components that do not contain slashes. In which case svn_sort_compare_items_as_paths produces the same result but is less ef

Re: svn commit: r1343456 - in /subversion/branches/javahl-ra/subversion/bindings/javahl/native: RevpropTable.cpp RevpropTable.h

2012-05-29 Thread Greg Stein
I would suggest any logical change that can apply to trunk should be submitted to dev@. If it helps trunk, or is at least neutral, then I'd support it. We couldn't digest your initial 27 patches :-), but some minor ones showing up should be just fine. I would guess you'll be looking for a +1 from

Re: [PATCH] issue #4134 (partial): sort deleted nodes before dumping them

2012-05-29 Thread Stefan Sperling
On Tue, May 29, 2012 at 03:09:08PM -0400, Dustin Lang wrote: > > Hi, > > This is my first time working on the subversion code, so be gentle :) > > I believe the attached patch solves one component of #4134 > ("svnadmin dump files are not reproducible, due to APR 1.4.6 hash > order changes"), nam

[PATCH] issue #4134 (partial): sort deleted nodes before dumping them

2012-05-29 Thread Dustin Lang
Hi, This is my first time working on the subversion code, so be gentle :) I believe the attached patch solves one component of #4134 ("svnadmin dump files are not reproducible, due to APR 1.4.6 hash order changes"), namely that deleted nodes are stored in a hash and dumped out in (now-arbitra

Re: svn commit: r1343456 - in /subversion/branches/javahl-ra/subversion/bindings/javahl/native: RevpropTable.cpp RevpropTable.h

2012-05-29 Thread Hyrum Wright
Vladimir, I haven't forgotten your patches or the other thread about the editor, but I also haven't had a chance to review them. My connectivity will be spotty over the next few days, so it may be later this week before I have meaningful feedback. (Hopefully others can chime in before that, th