Re: Tracebacks in svnadmin tests (fs->uuid issues)

Daniel Shahaf wrote on Sat, Apr 28, 2012 at 11:27:37 +0300: > Greg Stein wrote on Fri, Apr 27, 2012 at 23:45:12 -0400: > > Hey Daniel, > > > > I had four svnadmin tests dump core due to an assertion: 8, 21, 26, > > 27. These are all marked XFail(), so my test run "passed". > > AFAIK all of those

Re: svn commit: r1328939 - /subversion/trunk/subversion/libsvn_subr/io.c

Bert Huijben wrote: -Original Message- From: stef...@apache.org [mailto:stef...@apache.org] Sent: zondag 22 april 2012 21:15 To: comm...@subversion.apache.org Subject: svn commit: r1328939 - /subversion/trunk/subversion/libsvn_subr/io.c Author: stefan2 Date: Sun Apr 22 19:14:50 2012 Ne

Re: svn commit: r1331763 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

stef...@apache.org wrote on Sat, Apr 28, 2012 at 13:48:00 -: > Author: stefan2 > Date: Sat Apr 28 13:48:00 2012 > New Revision: 1331763 > > URL: http://svn.apache.org/viewvc?rev=1331763&view=rev > Log: > The lifetime of the shared-memory based named atomics used for > revprop generation commun

Re: svn commit: r1331760 - in /subversion/trunk/subversion: include/private/svn_named_atomic.h libsvn_subr/named_atomic.c tests/libsvn_subr/named_atomic-test.c

On Apr 28, 2012 8:48 AM, wrote: > > Author: stefan2 > Date: Sat Apr 28 12:48:23 2012 > New Revision: 1331760 > > URL: http://svn.apache.org/viewvc?rev=1331760&view=rev > Log: > To the named atomics API, add a method that checks whether the full > API functionality will be available to the current

Re: svn commit: r1326688 - /subversion/trunk/subversion/tests/libsvn_subr/named_atomic-test.c

Greg Stein wrote: On Apr 22, 2012 2:09 PM, "Stefan Fuhrmann" > wrote: > > Am 16.04.2012 19:45, schrieb Greg Stein: >>... >> I also find the need for the has_sufficient_privileges() function to be problematic. It seems to indicate you have not encapsulated this stuff prop

Re: authz_tests 7 FAIL with new revprop caching

Philip Martin wrote: Philip Martin writes: On my Linux machine svnserve with threading and revprop caching causes authz_tests 7 to FAIL: $ subversion/svnserve/svnserve --cache-revprops yes -Tdr subversion/tests/cmdline and $ ./authz_tests.py --url=svn://localhost 7 Getting lots of failure

Re: Queries on two instances of __bind_int64(revnum) in WC

Daniel Shahaf wrote: > Julian Foad wrote on Fri, Apr 27, 2012 at 22:04:45 +0100: >> One point being the semantics is different: _bind_revnum sets column to >> NULL for INVALID_REVNUM. >> >> Don't know if INVALID_REVNUM ever can hit these two particular code >> paths. > > You could check that

Re: svn commit: r1330058 - in /subversion/trunk/subversion: include/svn_error_codes.h include/svn_fs.h libsvn_fs/editor.c libsvn_repos/commit.c

Greg Stein wrote on Fri, Apr 27, 2012 at 17:33:18 -0400: > I'm growing weary of this. > > Daniel and I spent a couple hours discussing calling patterns, error > states, and everything. This felt the best approach. > > If you have a concrete suggestion, and a patch, then I'll take a look. > Inde

Re: svn commit: r1330058 - in /subversion/trunk/subversion: include/svn_error_codes.h include/svn_fs.h libsvn_fs/editor.c libsvn_repos/commit.c

Greg Stein wrote on Fri, Apr 27, 2012 at 15:53:12 -0400: > On Fri, Apr 27, 2012 at 15:25, Philip Martin > wrote: > > Greg Stein writes: > > > >> The current err->message says "Conflict at '/some/path'." (no real context) > >> > >> mod_dav_svn returns a message such as: > >> > >> "A conflict occu

Re: Queries on two instances of __bind_int64(revnum) in WC

Julian Foad wrote on Fri, Apr 27, 2012 at 22:04:45 +0100: > > Can anyone advise on these? > > > One point being the semantics is different: _bind_revnum sets column to NULL > for INVALID_REVNUM. > > Don't know if INVALID_REVNUM ever can hit these two particular code paths. > You could check t

Re: Tracebacks in svnadmin tests (fs->uuid issues)

AFAIK all of those are due to the same issue: dst_fs->uuid not being initialized. Philip noted that there are probably worse problems here, since fs_fs_shared_data_t (ffd->ffsd) holds various locks and caches tat are indexed by UUID only. This is at the top of my 'svn' todo list. (but that list