Re: svn commit: r1327703 - in /subversion/trunk/subversion: include/private/svn_subr_private.h libsvn_fs_base/util/fs_skels.c libsvn_subr/checksum.c

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 19:15, Blair Zajac wrote: > On 04/18/2012 03:45 PM, Greg Stein wrote: >... >> Yup, I understood. Sorry that I wasn't clear: I meant in our >> serialization code, shouldn't we use the "proper" functions rather >> than raw sha1 digests? Is there any way to switch to them at a

Re: svn commit: r1327716 - /subversion/trunk/subversion/libsvn_subr/checksum.c

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 18:55, wrote: >... > +++ subversion/trunk/subversion/libsvn_subr/checksum.c Wed Apr 18 22:55:01 > 2012 >... > +  checksum = checksum_create(kind, digest_size, pool); > +  memcpy((unsigned char *)checksum->digest, digest, digest_size); > +  return checksum; I've seen quit

Re: svn commit: r1327703 - in /subversion/trunk/subversion: include/private/svn_subr_private.h libsvn_fs_base/util/fs_skels.c libsvn_subr/checksum.c

2012-04-18 Thread Blair Zajac
On 04/18/2012 03:45 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 18:42, Blair Zajac wrote: On 04/18/2012 03:35 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 18:11,wrote: Author: blair Date: Wed Apr 18 22:11:43 2012 New Revision: 1327703 URL: http://svn.apache.org/viewvc?rev=1327703&vie

Re: svn commit: r1327703 - in /subversion/trunk/subversion: include/private/svn_subr_private.h libsvn_fs_base/util/fs_skels.c libsvn_subr/checksum.c

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 18:42, Blair Zajac wrote: > On 04/18/2012 03:35 PM, Greg Stein wrote: >> On Wed, Apr 18, 2012 at 18:11,  wrote: >>> >>> Author: blair >>> Date: Wed Apr 18 22:11:43 2012 >>> New Revision: 1327703 >>> >>> URL: http://svn.apache.org/viewvc?rev=1327703&view=rev >>> Log: >>> Add

Re: svn commit: r1327703 - in /subversion/trunk/subversion: include/private/svn_subr_private.h libsvn_fs_base/util/fs_skels.c libsvn_subr/checksum.c

2012-04-18 Thread Blair Zajac
On 04/18/2012 03:35 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 18:11, wrote: Author: blair Date: Wed Apr 18 22:11:43 2012 New Revision: 1327703 URL: http://svn.apache.org/viewvc?rev=1327703&view=rev Log: Add and use svn_checksum__from_digest_sha1(). This replaces svn_checksum__from_digest(

Re: svn commit: r1327695 - /subversion/trunk/subversion/libsvn_subr/checksum.c

2012-04-18 Thread Blair Zajac
On 04/18/2012 02:57 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 17:52, wrote: Author: blair Date: Wed Apr 18 21:52:01 2012 New Revision: 1327695 URL: http://svn.apache.org/viewvc?rev=1327695&view=rev Log: Refactor svn_checksum_create() to avoid two switch statements. * subversion/libsvn_sub

Re: svn commit: r1327703 - in /subversion/trunk/subversion: include/private/svn_subr_private.h libsvn_fs_base/util/fs_skels.c libsvn_subr/checksum.c

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 18:11, wrote: > Author: blair > Date: Wed Apr 18 22:11:43 2012 > New Revision: 1327703 > > URL: http://svn.apache.org/viewvc?rev=1327703&view=rev > Log: > Add and use svn_checksum__from_digest_sha1(). > > This replaces svn_checksum__from_digest() taking a svn_checksum_sha1

RE: svn commit: r1327695 - /subversion/trunk/subversion/libsvn_subr/checksum.c

2012-04-18 Thread Bert Huijben
> -Original Message- > From: Greg Stein [mailto:gst...@gmail.com] > Sent: woensdag 18 april 2012 23:55 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1327695 - > /subversion/trunk/subversion/libsvn_subr/checksum.c > > On Wed, Apr 18, 2012 at 17:52, wrote: > >... > > +++ su

Re: svn commit: r1327695 - /subversion/trunk/subversion/libsvn_subr/checksum.c

2012-04-18 Thread Blair Zajac
On 04/18/2012 02:54 PM, Greg Stein wrote: On Wed, Apr 18, 2012 at 17:52, wrote: ... +++ subversion/trunk/subversion/libsvn_subr/checksum.c Wed Apr 18 21:52:01 2012 @@ -56,25 +56,43 @@ validate_kind(svn_checksum_kind_t kind) return svn_error_create(SVN_ERR_BAD_CHECKSUM_KIND, NULL, NULL);

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Blair Zajac
On 04/18/2012 12:15 AM, Julian Foad wrote: Blair Zajac wrote: In case of an illegal svn_checksum_kind_t being passed to svn_checksum__from_digest(), I want to change it from svn_checksum_t * svn_checksum__from_digest(const unsigned char *digest, svn_checksum_kind_t k

Re: svn commit: r1327695 - /subversion/trunk/subversion/libsvn_subr/checksum.c

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 17:52, wrote: > Author: blair > Date: Wed Apr 18 21:52:01 2012 > New Revision: 1327695 > > URL: http://svn.apache.org/viewvc?rev=1327695&view=rev > Log: > Refactor svn_checksum_create() to avoid two switch statements. > > * subversion/libsvn_subr/checksum.c >  (checksum_cr

Re: svn commit: r1327695 - /subversion/trunk/subversion/libsvn_subr/checksum.c

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 17:52, wrote: >... > +++ subversion/trunk/subversion/libsvn_subr/checksum.c Wed Apr 18 21:52:01 > 2012 > @@ -56,25 +56,43 @@ validate_kind(svn_checksum_kind_t kind) >     return svn_error_create(SVN_ERR_BAD_CHECKSUM_KIND, NULL, NULL); >  } > > +/* Create a svn_checksum_t

Re: svn commit: r1327477 - /subversion/trunk/subversion/libsvn_subr/

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 14:22, Stefan Sperling wrote: > On Wed, Apr 18, 2012 at 12:33:23PM -, stef...@apache.org wrote: >> Author: stefan2 >> Date: Wed Apr 18 12:33:23 2012 >> New Revision: 1327477 >> >> URL: http://svn.apache.org/viewvc?rev=1327477&view=rev >> Log: >> Naming policy: Rename al

Re: svn commit: r1327477 - /subversion/trunk/subversion/libsvn_subr/

2012-04-18 Thread Stefan Sperling
On Wed, Apr 18, 2012 at 12:33:23PM -, stef...@apache.org wrote: > Author: stefan2 > Date: Wed Apr 18 12:33:23 2012 > New Revision: 1327477 > > URL: http://svn.apache.org/viewvc?rev=1327477&view=rev > Log: > Naming policy: Rename all svn_*.c to just *.c in /subversion/libsvn_subr. Was there a

Re: svn commit: r1326696 - in /subversion/trunk/subversion/libsvn_client: add.c client.h commit.c copy.c delete.c prop_commands.c util.c

2012-04-18 Thread Hyrum K Wright
r1327597 approaches the problem from a different angle, partially inspired by Greg's comment. We just fetch the relpaths for the various commit items before doing the commit, shove them into a hash mapping that to the appropriate abspath, and then let the shim callbacks use the hash to find their

Re: svn commit: r1327490 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 08:51, wrote: >... > +++ subversion/trunk/subversion/libsvn_ra_serf/update.c Wed Apr 18 12:51:52 > 2012 >... > @@ -1572,6 +1574,10 @@ start_report(svn_ra_serf__xml_parser_t * >             _("Missing name attr in delete-entry element")); >         } > > +      rev_str = s

Re: svn commit: r1327438 - /subversion/trunk/subversion/tests/libsvn_subr/

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 06:05, wrote: > Author: stefan2 > Date: Wed Apr 18 10:05:56 2012 > New Revision: 1327438 > > URL: http://svn.apache.org/viewvc?rev=1327438&view=rev > Log: > * subversion/tests/libsvn_subr >  svn:ignore named_atomic-test-proc binary > > Modified: >    subversion/trunk/subve

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Greg Stein
On Wed, Apr 18, 2012 at 09:47, Hyrum K Wright wrote: > On Wed, Apr 18, 2012 at 8:18 AM, Julian Foad > wrote: >... >> In response to consistency: after writing the above I've just realized why >> this function really is different from the others.  Most of the checksum >> functions that take a '

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Hyrum K Wright
On Wed, Apr 18, 2012 at 8:18 AM, Julian Foad wrote: > Hyrum K Wright wrote: > >> On Wed, Apr 18, 2012 at 2:15 AM, Julian Foad wrote: >>>  Blair Zajac wrote:  In case of an illegal svn_checksum_kind_t being passed to  svn_checksum__from_digest(), I want to change it from  svn_ch

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Julian Foad
Hyrum K Wright wrote: > On Wed, Apr 18, 2012 at 2:15 AM, Julian Foad wrote: >> Blair Zajac wrote: >>> In case of an illegal svn_checksum_kind_t being passed to >>> svn_checksum__from_digest(), I want to change it from >>> >>> svn_checksum_t * >>> svn_checksum__from_digest(const unsigned char

RE: svn_client_status5: ood_changed_rev is different for "http" and "file" protocols

2012-04-18 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hyrum.wri...@wandisco.com] > Sent: woensdag 18 april 2012 2:16 > To: Dmitry Pavlenko > Cc: Subversion Development > Subject: Re: svn_client_status5: ood_changed_rev is different for "http" and > "file" protocols > > On Tue, Apr 17, 2012 a

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Hyrum K Wright
On Wed, Apr 18, 2012 at 2:15 AM, Julian Foad wrote: > Blair Zajac wrote: > >> In case of an illegal svn_checksum_kind_t being passed to >> svn_checksum__from_digest(), I want to change it from >> >> svn_checksum_t * >> svn_checksum__from_digest(const unsigned char *digest, >>                      

Re: Changing svn_checksum__from_digest()'s signature

2012-04-18 Thread Julian Foad
Blair Zajac wrote: > In case of an illegal svn_checksum_kind_t being passed to > svn_checksum__from_digest(), I want to change it from > > svn_checksum_t * > svn_checksum__from_digest(const unsigned char *digest, >                           svn_checksum_kind_t kind, >                           a

Re: 1.7.5 in one/two weeks?

2012-04-18 Thread Greg Stein
On Apr 18, 2012 1:48 AM, "Daniel Shahaf" wrote: > > Daniel Shahaf wrote on Thu, Apr 12, 2012 at 16:57:50 +0300: > > We released 1.6.18 today and 1.7.4 just over a month ago. There are > > a few useful items merged already, and STATUS has a truckload of pending > > changes. > > > > Shall we roll 1