On 05.04.2012 00:44, Philip Martin wrote:
> Philip Martin writes:
>
>> I think there is a refcount/locking bug in svn_fs_bdb__close. This code
>>
>> - if (0 == --bdb_baton->error_info->refcount && bdb->pool)
>> -{
>> - svn_error_clear(bdb_baton->error_info->pending_errors);
>> -#if APR_
On 04.04.2012 20:46, Daniel Shahaf wrote:
> But one _could_ write a filesystem that implements compression and/or
> deduplication aimed at .svn/pristine/'s workflow. Should effort be
> spent there rather than on implementing a smarter svn_wc__pristine_*()?
Now that's an interesting idea. I propos
Philip Martin writes:
> I think there is a refcount/locking bug in svn_fs_bdb__close. This code
>
> - if (0 == --bdb_baton->error_info->refcount && bdb->pool)
> -{
> - svn_error_clear(bdb_baton->error_info->pending_errors);
> -#if APR_HAS_THREADS
> - free(bdb_baton->error_info);
>
> -Original Message-
> From: Ashod Nakashian [mailto:ashodnakash...@yahoo.com]
> Sent: woensdag 4 april 2012 13:28
> To: Greg Stein
> Cc: dev@subversion.apache.org
> Subject: Re: Compressed Pristines (Summary)
>
> >
> > From: Greg Stein
> >My vote is comp
+1 to what Greg just outlined
Ashod Nakashian wrote on Wed, Apr 04, 2012 at 13:28:06 -0700:
> >
> > From: Greg Stein
> >My vote is compress for files > N bytes (and store on disk), and stick the
> >others into a new pristine.db. Maybe compress before inserting int
>
> From: Greg Stein
>My vote is compress for files > N bytes (and store on disk), and stick the
>others into a new pristine.db. Maybe compress before inserting into Sqlite.
>Not sure. Add a few heuristics for skipping compression on certain files types.
>Shouldn'
Ashod Nakashian wrote on Wed, Apr 04, 2012 at 11:57:45 -0700:
> I think we either agree that SVN should improve its footprint or we
> don't.
I agree with making svn_wc__pristine_*() smarter and I disagree with
teaching svn the proper mount(8) flags for all platforms APR supports.
Daniel
(than ks
On Apr 4, 2012 3:26 PM, "Ashod Nakashian" wrote:
>
>
>
>
> >
> > From: Daniel Shahaf
>
> >>
> >
> >But one _could_ write a filesystem that implements compression and/or
> >deduplication aimed at .svn/pristine/'s workflow. Should effort be
> >spent there rather
>
> From: Daniel Shahaf
>To: Ashod Nakashian
>Cc: Julian Foad ; Markus Schaber
>; "mtheri...@gmail.com" ;
>Subversion Development
>Sent: Wednesday, April 4, 2012 10:46 PM
>Subject: Re: Compressed Pristines (Summary)
>
>Ashod Nakashian wrote on Wed, Apr 04,
- Original Message -
> From: Daniel Shahaf
> To: Ashod Nakashian
> Cc: Markus Schaber ; "julianf...@btopenworld.com"
> ; "mtheri...@gmail.com" ;
> Subversion Development
> Sent: Wednesday, April 4, 2012 10:29 PM
> Subject: Re: Compressed Pristines (Summary)
>
> Ashod Nakashian wro
On 04/04/2012 02:46 PM, Daniel Shahaf wrote:
> But one _could_ write a filesystem that implements compression and/or
> deduplication aimed at .svn/pristine/'s workflow. Should effort be
> spent there rather than on implementing a smarter svn_wc__pristine_*()?
>
> Daniel
> (devil's advocate mode)
Ashod Nakashian wrote on Wed, Apr 04, 2012 at 11:41:43 -0700:
>
>
>
>
> - Original Message -
> > From: Julian Foad
> > To: Ashod Nakashian
> > Cc: Daniel Shahaf ; Markus Schaber
> > ; "mtheri...@gmail.com" ;
> > Subversion Development
> > Sent: Wednesday, April 4, 2012 9:45 PM
> >
- Original Message -
> From: Julian Foad
> To: Ashod Nakashian
> Cc: Daniel Shahaf ; Markus Schaber
> ; "mtheri...@gmail.com" ;
> Subversion Development
> Sent: Wednesday, April 4, 2012 9:45 PM
> Subject: Re: Compressed Pristines (Summary)
>
> Ashod Nakashian wrote:
>
>> Daniel
>
> From: Mark Phippard
>To: Ashod Nakashian
>Cc: Daniel Shahaf ; Markus Schaber
>; "julianf...@btopenworld.com"
>; "mtheri...@gmail.com" ;
>Subversion Development
>Sent: Wednesday, April 4, 2012 9:23 PM
>Subject: Re: Compressed Pristines (Summary)
>
>On We
Ashod Nakashian wrote on Wed, Apr 04, 2012 at 10:18:47 -0700:
> >
> > From: Daniel Shahaf
> >To: Ashod Nakashian
> >Cc: Markus Schaber ; "julianf...@btopenworld.com"
> >; "mtheri...@gmail.com" ;
> >Subversion Development
> >Sent: Wednesday, April 4, 2012 9:46
Julian Foad wrote on Wed, Apr 04, 2012 at 18:45:34 +0100:
> Ashod Nakashian wrote:
> > Daniel Shahaf wrote:
> >> In short: if 'mount -o compress=yes' provides 90% space savings
> >> then we would have little reason to implement space-saving
> >> solutions in svn itself. But it's the user's, not sv
On Wed, Apr 4, 2012 at 12:45 PM, Julian Foad wrote:
> Ashod Nakashian wrote:
>
>> Daniel Shahaf wrote:
>>> In short: if 'mount -o compress=yes' provides 90% space savings then
>> we
>>> would have little reason to implement space-saving solutions in svn itself.
>>> But it's the user's, not svn's,
Ashod Nakashian wrote:
> Daniel Shahaf wrote:
Would you like to assess the feasibility of compressing the pristine
>>> >store by re-mounting the "pristines" subdirectory as a compressed
>>> >subtree in the operating system's file system?
>>>
>>> No :-)
>>>
>>> There are two ways to answ
On Wed, Apr 4, 2012 at 1:18 PM, Ashod Nakashian
wrote:
> That's an easy question. The answer is that at *best* they'll do as good as
> in-place compression. However, in practice
> they'll do much worse. The reason is that the OS level compression works on
> not only the single file level, but a
>
> From: Daniel Shahaf
>To: Ashod Nakashian
>Cc: Markus Schaber ; "julianf...@btopenworld.com"
>; "mtheri...@gmail.com" ;
>Subversion Development
>Sent: Wednesday, April 4, 2012 9:46 AM
>Subject: Re: Compressed Pristines (Summary)
>
>> >1. Filesystem compre
> >1. Filesystem compression.
> >
> >Would you like to assess the feasibility of compressing the pristine
> >store by re-mounting the "pristines" subdirectory as a compressed
> >subtree in the operating system's file system?
>
> No :-)
>
> There are two ways to answer this interesting propositio
On Apr 4, 2012 9:17 AM, "Julian Foad" wrote:
>
> Greg Stein wrote:
> >> Convert svn_client__wc_node_get_origin() to use svn_client__pathrev_t
for
> >> its output.
> >>
> >> * subversion/include/private/svn_client_private.h,
> >> subversion/libsvn_client/util.c
> >> (svn_client__wc_node_get_origi
Greg Stein wrote:
>> Convert svn_client__wc_node_get_origin() to use svn_client__pathrev_t for
>> its output.
>>
>> * subversion/include/private/svn_client_private.h,
>> subversion/libsvn_client/util.c
>> (svn_client__wc_node_get_origin): Use pathrev_t for the output.
> This revision certainly s
Philip Martin writes:
> ==10434== Thread 15:
> ==10434== Invalid read of size 4
> ==10434==at 0x802D5BB: svn_fs_bdb__open_internal (env.c:660)
> ==10434==by 0x802D679: svn_fs_bdb__open (env.c:672)
> ==10434==by 0x80390D7: open_databases (fs.c:536)
> ==10434==by 0x8039C26: base_ope
On Apr 4, 2012 4:26 AM, wrote:
>
> Author: julianfoad
> Date: Wed Apr 4 08:26:15 2012
> New Revision: 1309283
>
> URL: http://svn.apache.org/viewvc?rev=1309283&view=rev
> Log:
> Convert svn_client__wc_node_get_origin() to use svn_client__pathrev_t for
> its output.
>
> * subversion/include/privat
Combined response inline...
> From: Markus Schaber
>
>First, thanks for your great summary. I'll throw in just my 2 cents below.
The pleasure is mine.
> From: Markus Schaber
>
>Was any of those tests actually executed on a file system supporting something
>like "block suballocation", "tail me
26 matches
Mail list logo
