Re: The recent svn_string_create_empty() function

2012-04-03 Thread Daniel Shahaf
Julian Foad wrote on Tue, Apr 03, 2012 at 18:09:19 +0100: > For comments, please: > [[[Tweak the recently introduced svn_stringbuf_create_empty() function. > > Unlike with svn_string_create_empty() which produces an immutable > string, the resulting string buffer is often going to have data > app

The recent svn_string_create_empty() function

2012-04-03 Thread Julian Foad
For comments, please: [[[Tweak the recently introduced svn_stringbuf_create_empty() function. Unlike with svn_string_create_empty() which produces an immutable string, the resulting string buffer is often going to have data appended to it.  The initial implementation created a non-standard buffer

Re: svn commit: r1308966 - in /subversion/trunk/subversion: include/svn_string.h libsvn_subr/svn_string.c

2012-04-03 Thread Philip Martin
julianf...@apache.org writes: > Author: julianfoad > Date: Tue Apr 3 15:03:56 2012 > New Revision: 1308966 > > URL: http://svn.apache.org/viewvc?rev=1308966&view=rev > Log: > Make svn_stringbuf_ensure() allocate an additional byte for the null > terminator, bringing it in line with svn_stringbuf_

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-03 Thread Philip Martin
Philip Martin writes: > I'm not familiar with this code. I can "fix" the problem by removing > the free() from svn_fs_bdb__close but that's not really surprising given > the warnings above, nor is it a solution. The patch below also appears > to fix the problem but I'm reluctant to commit it un

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-03 Thread Philip Martin
Philip Martin writes: > ==10434== Thread 15: > ==10434== Invalid read of size 4 > ==10434==at 0x802D5BB: svn_fs_bdb__open_internal (env.c:660) > ==10434==by 0x802D679: svn_fs_bdb__open (env.c:672) > ==10434==by 0x80390D7: open_databases (fs.c:536) > ==10434==by 0x8039C26: base_ope

Re: New struct for holding (url, rev, repo-root) coordinates in client merge code

2012-04-03 Thread Julian Foad
Greg Stein wrote: > Julian Foad wrote: >> ... >> Sometimes we have more than two variables because we also want the >> repository root URL, either to check it's the same repo as some other >> location or to derive the repo-root-relative path (or fspath).  It's reached >> the point where it's de

Re: Subversion BDB doesn't work with Apache 2.4 event MPM

2012-04-03 Thread Philip Martin
Branko Čibej writes: > On 02.04.2012 18:46, Philip Martin wrote: >> I am unable to run the Subversion regression tests for BDB and DAV with >> Apache 2.4 using the event MPM (the new default MPM in 2.4). Sometimes >> mod_dav_svn SEGVs causing tests to FAIL and sometimes the tests hang >> with mo