Re: svn commit: r1241733 - /subversion/trunk/subversion/libsvn_delta/compat.c

2012-02-07 Thread Greg Stein
That log message doesn't describe the change. You were already computing and passing a checksum. Maybe the bug was that you did not close TARGET to finalize the checksum computation? On Feb 7, 2012 8:56 PM, wrote:

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Daniel Shahaf
Daniel Shahaf wrote on Wed, Feb 08, 2012 at 02:32:01 +0200: > r1241713 --- thanks! And r1241726, since the buildslave runs Python 2.4...

Re: svn commit: r1240755 - /subversion/branches/1.7.x/STATUS

2012-02-07 Thread Daniel Shahaf
Bojan has merged this to 1.5.x/1.4.x/0.9.x and it'll be included in 1.4.6. Thanks, Daniel Daniel Shahaf wrote on Mon, Feb 06, 2012 at 21:35:34 +0200: > Bojan Smojver wrote on Mon, Feb 06, 2012 at 09:25:59 +1100: > > On Sun, 2012-02-05 at 22:44 +0200, Daniel Shahaf wrote: > > > > > It looks like

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Daniel Shahaf
r1241713 --- thanks!

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Stefan Sperling
On Tue, Feb 07, 2012 at 11:12:22PM +0100, Matthijs Kooijman wrote: > I've attached a patch which should make the unlock prompt function agian > on Linux, while not breaking on Windows. I also found a keyword in swig > that removes the need for a separate declaration and implementation of > the func

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hi Daniel, > > Index: subversion-trunk/subversion/bindings/swig/python/tests/client.py > > === > > --- subversion-trunk.orig/subversion/bindings/swig/python/tests/client.py > > 2012-02-07 20:13:48.666552472 +0100 > > +++ subversion

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hey Stefan, > Hold on there, it seems that doesn't work either. Perhaps the > SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC constant isn't defined > when swig runs or something, I'll have a closer look now. I've attached a patch which should make the unlock prompt function agian on Linux, while

Re: [RFC] Inheritable Properties

2012-02-07 Thread Stefan Fuhrmann
On 07.02.2012 00:41, Greg Stein wrote: In most data storage mechanisms for the repository, inheritable properties are a performance killer. I'm not sure that this is actually applicable to SVN for two reasons: (1) we use deltification and (2) we often handle whole file trees (1) causes us to d

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hey Stefan, > So, you'll have to drop the {% %} (which is effectively my patch again) > ;-p Hold on there, it seems that doesn't work either. Perhaps the SVN_AUTH_PARAM_GNOME_KEYRING_UNLOCK_PROMPT_FUNC constant isn't defined when swig runs or something, I'll have a closer look now. Gr. Matthijs

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hey Stefan, > Thanks. I've already committed a similar fix in r1241585. > I wasn't quite sure if it was gonna work but glad you had the same idea :) Actually, I just tried your fix and it doesn't work. It'll fix the build error on win32, but it also breaks the binding on systems that do have gnom

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Daniel Shahaf
Matthijs Kooijman wrote on Tue, Feb 07, 2012 at 20:52:08 +0100: > Hi Daniel, > > > svn_config_get_config() reads from disk. You'd do that just once (and > > stash the result in the client context, if svn_cmdline_init() or someone > > else doesn't do that for you), and then ["config"] it. (In the

Re: Error While Checking out Git Repository

2012-02-07 Thread C. Michael Pilato
On 02/07/2012 02:49 PM, TheBlueSky .Net wrote: > Hello, > > I was checking out a Git repository > (https://github.com/NuGet/PoliteCaptcha.git) when I encountered the > following error near the end of getting all the files: > > Subversion encountered a serious problem. > Please take the time to re

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Stefan Sperling
On Tue, Feb 07, 2012 at 09:06:03PM +0100, Matthijs Kooijman wrote: > Hey Stefan, > > > FYI, the latter patch fails to compile on Windows. > > See > > http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/6580/steps/Build%20Bindings/logs/stdio > Woops, i forgot to #ifdef the declaration lik

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hey Stefan, > FYI, the latter patch fails to compile on Windows. > See > http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/6580/steps/Build%20Bindings/logs/stdio Woops, i forgot to #ifdef the declaration like I did with the implmentation. I reproduced the error here by disabling gnome-

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hi Daniel, > svn_config_get_config() reads from disk. You'd do that just once (and > stash the result in the client context, if svn_cmdline_init() or someone > else doesn't do that for you), and then ["config"] it. (In the C level > that's just an apr_hash_get().) > > Have a look at what the sv

Error While Checking out Git Repository

2012-02-07 Thread TheBlueSky .Net
Hello, I was checking out a Git repository ( https://github.com/NuGet/PoliteCaptcha.git) when I encountered the following error near the end of getting all the files: Subversion encountered a serious problem. Please take the time to report this on the Subversion mailing list with as much informat

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Stefan Sperling
On Tue, Feb 07, 2012 at 08:12:55PM +0100, Stefan Sperling wrote: > Thanks. I've committed this, and your other patch (r1241553 and r1241554). FYI, the latter patch fails to compile on Windows. See http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/6580/steps/Build%20Bindings/logs/stdio

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Stefan Sperling
On Tue, Feb 07, 2012 at 07:42:15PM +0100, Matthijs Kooijman wrote: > Hi Stefan, > > > Can you please add a copyright and licence header to the new file > > subversion-trunk/tools/examples/info.rb? Thanks! > I've attached an updated version of the patch, including the same > license header as the o

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Daniel Shahaf
Matthijs Kooijman wrote on Tue, Feb 07, 2012 at 19:29:36 +0100: > Hi Daniel, > > > > + # ctx.config.config (ctx.config is opaque). > > > > What do you mean by that? > > > > % PYTHONPATH=$prefix/svn-t1/lib/svn-python/ \ > > python -c 'import svn, svn.core, svn.client; > > print s

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hi Stefan, > Can you please add a copyright and licence header to the new file > subversion-trunk/tools/examples/info.rb? Thanks! I've attached an updated version of the patch, including the same license header as the other examples. Gr. Matthijs [[[ Fix the ruby bindings for svn_auth_get_platfo

Re: Why do we check the base checksum so often?

2012-02-07 Thread Greg Stein
On Feb 7, 2012 3:49 AM, "Julian Foad" wrote: >... > So... Greg's talking about if a <= 1.7 client is re-linked against the Ev2-capable libraries, the shims would be inserted and that check would be lost. But what happens if, instead, we run that <= 1.7 client *with its old libraries* and connect

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hi Daniel, > > + # ctx.config.config (ctx.config is opaque). > > What do you mean by that? > > % PYTHONPATH=$prefix/svn-t1/lib/svn-python/ \ > python -c 'import svn, svn.core, svn.client; > print svn.core.svn_config_get_config(None, None)["config"]' > 0xb734d998> > I meant this

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Daniel Shahaf
Matthijs Kooijman wrote on Tue, Feb 07, 2012 at 17:14:32 +0100: > Hi Stefan, > > > It appears the attachment is missing. > Yeah, motoric memory took over and I sent the mail, while I intended to > actually test the patches again before resending. > > So, here's the updated _and_ tested patches, a

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Stefan Sperling
On Tue, Feb 07, 2012 at 05:14:32PM +0100, Matthijs Kooijman wrote: > Hi Stefan, > > > It appears the attachment is missing. > Yeah, motoric memory took over and I sent the mail, while I intended to > actually test the patches again before resending. > > So, here's the updated _and_ tested patches

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hi Stefan, > It appears the attachment is missing. Yeah, motoric memory took over and I sent the mail, while I intended to actually test the patches again before resending. So, here's the updated _and_ tested patches, attached this time. Gr. Matthijs [[[ Fix the python bindings for svn_auth_get

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Feb 07, 2012 at 16:37:54 +0100: > On Tue, Feb 07, 2012 at 04:31:14PM +0100, Matthijs Kooijman wrote: > > Hi folks, > > > > > over a year ago, I submitted a patch to make the > > > svn_auth_get_platform_specific_client_providers perl bindings work, to > > > allow git-s

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Stefan Sperling
On Tue, Feb 07, 2012 at 04:31:14PM +0100, Matthijs Kooijman wrote: > Hi folks, > > > over a year ago, I submitted a patch to make the > > svn_auth_get_platform_specific_client_providers perl bindings work, to > > allow git-svn to work with gnome_keyring. Since then, I've been working > > on some f

Re: [PATCH] More bindings for gnome_keyring / platform_specific_client_providers

2012-02-07 Thread Matthijs Kooijman
Hi folks, > over a year ago, I submitted a patch to make the > svn_auth_get_platform_specific_client_providers perl bindings work, to > allow git-svn to work with gnome_keyring. Since then, I've been working > on some further improvements, which I've attached as patches. has anyone got a chance to

Re: Let's discuss about unicode compositions for filenames!

2012-02-07 Thread Branko Čibej
On 07.02.2012 15:00, Stefan Sperling wrote: > On Tue, Feb 07, 2012 at 02:43:19PM +0100, Branko Čibej wrote: >> The client-side mapping table is a more general solution, if a >> lot harder to implement. >> >> But it brings additional benefits in that we could use it to, e.g., >> transliterate charac

Re: Let's discuss about unicode compositions for filenames!

2012-02-07 Thread Stefan Sperling
On Tue, Feb 07, 2012 at 02:43:19PM +0100, Branko Čibej wrote: > The client-side mapping table is a more general solution, if a > lot harder to implement. > > But it brings additional benefits in that we could use it to, e.g., > transliterate characters that are allowed by some file systems, but no

Re: 1.7.3 next week-ish?

2012-02-07 Thread Philip Martin
"roderich.sch...@googlemail.com" writes: > It's definitely an ordering problem, look at the whole series of operations: > > ... > add file trunk/D/H/omega > add file trunk/D/H/psi<--- the one with the bogus split props/text > add dir branches > add dir trunk/C > add dir trunk/B/F > ... >

Re: Let's discuss about unicode compositions for filenames!

2012-02-07 Thread Branko Čibej
On 07.02.2012 14:30, Hiroaki Nakamura wrote: > 2012/2/7 Branko Čibej : >> On 06.02.2012 22:26, Hiroaki Nakamura wrote: >>> The Unicode Standard says canonical equivalent sequences should be >>> interpreted the same way. >>> * 1.1 Canonical and Compatibility Equivalence >>> http://unicode.org/repo

Re: Let's discuss about unicode compositions for filenames!

2012-02-07 Thread Hiroaki Nakamura
2012/2/7 Branko Čibej : > On 06.02.2012 22:26, Hiroaki Nakamura wrote: >> The Unicode Standard says canonical equivalent sequences should be >> interpreted the same way. >> * 1.1 Canonical and Compatibility Equivalence >>   http://unicode.org/reports/tr15/#Canonical_Equivalence >> * 2.12 Equivalent

Re: svn commit: r1241440 - /subversion/branches/moves-scan-log/subversion/libsvn_wc/util.c

2012-02-07 Thread Stefan Sperling
On Tue, Feb 07, 2012 at 01:42:06PM +0100, Bert Huijben wrote: > > Author: stsp > > Date: Tue Feb 7 12:23:50 2012 > > New Revision: 1241440 > > > > URL: http://svn.apache.org/viewvc?rev=1241440&view=rev > > Log: > > On the moves-scan-log branch, fix svn_wc__conflict_description2_dup(). > > + if

RE: svn commit: r1241440 - /subversion/branches/moves-scan-log/subversion/libsvn_wc/util.c

2012-02-07 Thread Bert Huijben
> -Original Message- > From: s...@apache.org [mailto:s...@apache.org] > Sent: dinsdag 7 februari 2012 13:24 > To: comm...@subversion.apache.org > Subject: svn commit: r1241440 - /subversion/branches/moves-scan- > log/subversion/libsvn_wc/util.c > > Author: stsp > Date: Tue Feb 7 12:23:5

Re: 1.7.3 next week-ish?

2012-02-07 Thread Philip Martin
"roderich.sch...@googlemail.com" writes: > It's definitely an ordering problem, look at the whole series of operations: > > ... > add file trunk/D/H/omega > add file trunk/D/H/psi<--- the one with the bogus split props/text > add dir branches > add dir trunk/C > add dir trunk/B/F > ... >

Re: 1.7.3 next week-ish?

2012-02-07 Thread roderich.sch...@googlemail.com
On Monday, February 6, 2012 8:26:36 PM UTC+1, Bert Huijben wrote: > > We have similar ordering problem in some of the svn diff scenarios. It's definitely an ordering problem, look at the whole series of operations: ... add file trunk/D/H/omega add file trunk/D/H/psi<--- the one with the

Re: Why do we check the base checksum so often?

2012-02-07 Thread Julian Foad
Daniel Shahaf wrote: > [...] I think striking the word(s) "third-party" from your third > paragraph will not affect its correctness. > > Greg Stein wrote: >> IOW, when we release an Ev2-based Subversion, and third-party clients >> that were built against the 1.0 through 1.7 APIs... those clien