Re: [PATCH/RFC v3] Optionally allow binaries to run against older SQLite

2011-11-03 Thread Daniel Shahaf
On Friday, November 04, 2011 1:24 AM, "Jonathan Nieder" wrote: > Daniel Shahaf wrote: > > On Wednesday, November 02, 2011 4:25 PM, "Jonathan Nieder" > > wrote: > > >> I'm not very happy about putting -DSVN_SQLITE_COMPAT_VERSION in CFLAGS > >> --- does subversion have a config.h somewhere? > >

[PATCH/RFC v3] Optionally allow binaries to run against older SQLite

2011-11-03 Thread Jonathan Nieder
Daniel Shahaf wrote: > On Wednesday, November 02, 2011 4:25 PM, "Jonathan Nieder" > wrote: >> I'm not very happy about putting -DSVN_SQLITE_COMPAT_VERSION in CFLAGS >> --- does subversion have a config.h somewhere? > > http://s.apache.org/xy-problem --- Why do you think you need config.h? Sorry

Re: [PATCH] commit --include-externals (v2)

2011-11-03 Thread Alexey Neyman
Neels, Question from a user standpoint: would it be possible to request this behavior as default via some config file option? Regards, Alexey. On Thursday, November 03, 2011 06:33:56 am Neels J Hofmeyr wrote: > I've rinsed and improved my proposed feature dubbed > svn commit --include-externa

[RFC/PATCH] Re: auth-test fails (E200006: svn_auth_get_platform_specific_client_providers should return an array of 5 providers)

2011-11-03 Thread Jonathan Nieder
Stefan Sperling wrote: > On Thu, Nov 03, 2011 at 02:54:04AM -0500, Jonathan Nieder wrote: >> START: auth-test >> svn_tests: E26: svn_auth_get_platform_specific_client_providers >> should return an array of 5 providers >> FAIL: lt-auth-test 1: test retrieving platform-specific

Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Greg Hudson
On 11/03/2011 05:10 PM, Jonathan Nieder wrote: > Why would that be? When someone dumps in 20 bits of data from a > strong, in-hardware, random number source, even if the PRNG is utterly > stupid, it can have an unguessable 20 bits of internal state. After > reading enough random numbers, I will h

Re: [PATCH] Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Jonathan Nieder
Peter Samuelson wrote: > The problem is that svnserve is often used in 'inetd' mode, one > connection per process. I've recommended that for years, as being > easier and less hassle than managing a separate daemon. Given inetd > mode, your approach will exhaust /dev/random just as fast as the st

Re: [PATCH] Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Daniel Shahaf
On Thursday, November 03, 2011 4:26 PM, "Peter Samuelson" wrote: > > [Jonathan Nieder] > > state = apr_random_standard_new(pool); > > > > for (;;) { > > while (apr_random_secure_ready(state) == APR_ENOTENOUGHENTROPY) > > { > > apr_generate_random_bytes(b

Re: [PATCH] Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Peter Samuelson
[Jonathan Nieder] > state = apr_random_standard_new(pool); > > for (;;) { > while (apr_random_secure_ready(state) == APR_ENOTENOUGHENTROPY) > { > apr_generate_random_bytes(buf, sizeof(buf)); > apr_random_add_entropy(state, buf

Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Jonathan Nieder
Greg Hudson wrote: > As for the second threat, at least on Linux, /dev/random output still > comes from the PRNG. It just keeps an internal counter and blocks when > the PRNG has "run out of" its guess at estimated input entropy. (This > is exceedingly silly, because a PRNG doesn't "use up" inpu

[PATCH] Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Jonathan Nieder
Daniel Shahaf wrote: > On Thursday, November 03, 2011 12:44 AM, "Jonathan Nieder" > wrote: >> Another possibility would be to enhance >> apr's random number source API to allow requesting random bytes >> without so much entropy (erandom/frandom) or without blocking on lack >> of entropy (urandom

Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Peter Samuelson
[Daniel Shahaf] > Something tells me that when a cryptographic protocol calls for > random numbers then a quasiconstant or known value wouldn't do > instead. It might still provide some security guarantees but I > wouldn't assume it would provide all guarantees of the > correctly-executed protoco

Re: segfault when applying patch

2011-11-03 Thread Philip Martin
Philip Martin writes: > What you need is a patch file that has modifies two targets. One part > of the patch gets applied and deletes a file, another part of the patch > gets skipped, because the path is outside the working copy say. The > skipped target has local_abspath NULL and delete_empty_

Re: segfault when applying patch

2011-11-03 Thread Philip Martin
Stefan Küng writes: > A few crash dumps sent for TSVN 1.7 show a segfault when applying a patch. > > in libsvn_client/patch.c, line 2703: > > target_info = APR_ARRAY_IDX(targets_info, i, patch_target_info_t *); > parent = svn_dirent_dirname(target_info->local_abspath, iterpool); > > the target_in

Re: svn commit: r1197093 - /subversion/branches/showing-merge-info/subversion/svn/mergeinfo-cmd.c

2011-11-03 Thread Konstantin Kolinko
2011/11/4 Bert Huijben : > > >> -Original Message- >> From: julianf...@apache.org [mailto:julianf...@apache.org] >> Sent: donderdag 3 november 2011 14:08 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1197093 - /subversion/branches/showing-merge- >> info/subversion/svn/mergei

Re: Editor v2 - suggestions and queries

2011-11-03 Thread Greg Stein
On Thu, Nov 3, 2011 at 14:10, Julian Foad wrote: >... > @@ -177,18 +177,25 @@ >  *    \n\n >  *    Just before each callback invocation is carried out, the @a cancel_func >  *    that was passed to svn_editor_create() is invoked to poll any >  *    external reasons to cancel the sequence of operat

RE: svn commit: r1197093 - /subversion/branches/showing-merge-info/subversion/svn/mergeinfo-cmd.c

2011-11-03 Thread Bert Huijben
> -Original Message- > From: julianf...@apache.org [mailto:julianf...@apache.org] > Sent: donderdag 3 november 2011 14:08 > To: comm...@subversion.apache.org > Subject: svn commit: r1197093 - /subversion/branches/showing-merge- > info/subversion/svn/mergeinfo-cmd.c > > Author: julianfoad

segfault when applying patch

2011-11-03 Thread Stefan Küng
Hi, A few crash dumps sent for TSVN 1.7 show a segfault when applying a patch. in libsvn_client/patch.c, line 2703: target_info = APR_ARRAY_IDX(targets_info, i, patch_target_info_t *); parent = svn_dirent_dirname(target_info->local_abspath, iterpool); the target_info->local_abspath is NULL, so

Re: Patch ping, 5 years later: removing properties

2011-11-03 Thread C. Michael Pilato
The introduction of the --git option to 'svn diff' opens the door for different "flavors" for 'svn diff' output. Would you be interested in a new 'svn diff --patch' flavor, which generates only diff output that's suitable for consumption with GNU patch? Implied by --patch would be no property dif

Patch ping, 5 years later: removing properties

2011-11-03 Thread Alexey Neyman
Hi all, Sorry for a long delay :) 5 years ago, I sent a patch to the mailing list that would allow to specify what to include/exclude from the diff output: http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=742594 There were two problems this patch tried to address: 1.

Re: Editor v2 - suggestions and queries

2011-11-03 Thread Hyrum K Wright
Only a couple of nit-pick comments. Generally, since there is already discussion in the file itself, I'd support committing additional discussion directly, and then discussing it on the mailing list if needed. -Hyrum On Thu, Nov 3, 2011 at 1:10 PM, Julian Foad wrote: > Here, in the form of a pa

Editor v2 - suggestions and queries

2011-11-03 Thread Julian Foad
Here, in the form of a patch, are many suggestions and queries I've made on Ev2. I'm not intimately familiar with the design and goals of it, I'm just responding to how it's currently written up in the header file, with some memory of past discussions. Discussion welcomed. [[[ Index: subversion/i

Issue 4048 update not marking directories complete

2011-11-03 Thread Philip Martin
I'm looking at issue 4048 (with an eye on issue 3993, see end of mail) http://subversion.tigris.org/issues/show_bug.cgi?id=4048 There is code in update_editor.c:close_edit /* The editor didn't even open the root; we have to take care of some cleanup stuffs. */ if (! eb->root_opened

Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Greg Hudson
On 11/03/2011 01:44 AM, Jonathan Nieder wrote: > What do you think? Is forcing !APR_HAS_RANDOM and just using > apr_time_now() as Debian currently does safe, or does it expose users > to a security risk? I suspect it makes the server vulnerable to a replay attack. The right answer is to use /dev

[PATCH] commit --include-externals (v2)

2011-11-03 Thread Neels J Hofmeyr
I've rinsed and improved my proposed feature dubbed svn commit --include-externals (Related issues: #1167, #3563) I hope this will cut a much clearer path through the jungle that is externals behavior. Now I'm hoping for some reviews! The idea is to have file and dir externals behave the same w

Re: auth-test fails (E200006: svn_auth_get_platform_specific_client_providers should return an array of 5 providers)

2011-11-03 Thread Julian Foad
I (Julian Foad) wrote: > > Jonathan Nieder wrote: > > >     svn_tests: E26: > > > svn_auth_get_platform_specific_client_providers should > > > return an array of 5 providers > > >     FAIL:  lt-auth-test 1: test retrieving > > > platform-specific auth providers > > I get this too when I run "m

Re: 1.7.0 assert on svn_client_checkout with E235000

2011-11-03 Thread C. Michael Pilato
On 11/02/2011 05:42 PM, Barry Scott wrote: > I wish that the canonical stuff was inside the svn_client_XXX API calls and > not > a burdon on callers. To my mind the svn.exe API and the svn_client_XXX should > accept the same strings and either operate or return an error. Avoiding the > asserts fro

Re: auth-test fails (E200006: svn_auth_get_platform_specific_client_providers should return an array of 5 providers)

2011-11-03 Thread Julian Foad
Daniel Shahaf wrote: > Jonathan Nieder wrote: > >     svn_tests: E26: svn_auth_get_platform_specific_client_providers > > should return an array of 5 providers > >     FAIL:  lt-auth-test 1: test retrieving platform-specific auth providers > > > > Indeed, instrumenting the test, we learn that

Re: [Subversion Wiki] Update of "CopySvnsyncMirrorToMaster" by PhilipMartin

2011-11-03 Thread Daniel Shahaf
On Thursday, November 03, 2011 10:29 AM, "Apache Wiki" wrote: > Dear Wiki user, > > You have subscribed to a wiki page or wiki category on "Subversion Wiki" for > change notification. > > The "CopySvnsyncMirrorToMaster" page has been changed by PhilipMartin: > http://wiki.apache.org/subversi

Re: auth-test fails (E200006: svn_auth_get_platform_specific_client_providers should return an array of 5 providers)

2011-11-03 Thread Philip Martin
Jonathan Nieder writes: > The failure is described in tests.log: > > START: auth-test > svn_tests: E26: svn_auth_get_platform_specific_client_providers > should return an array of 5 providers > FAIL: lt-auth-test 1: test retrieving platform-specific auth providers >

Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Daniel Shahaf
On Thursday, November 03, 2011 11:42 AM, "Stefan Sperling" wrote: > On Thu, Nov 03, 2011 at 12:01:58PM +0200, Daniel Shahaf wrote: > > Something tells me that when a cryptographic protocol calls for random > > numbers then a quasiconstant or known value wouldn't do instead. > > Put more bluntly,

Re: [Subversion Wiki] Update of "CopySvnsyncMirrorToMaster" by JulianFoad

2011-11-03 Thread Daniel Shahaf
On Thursday, November 03, 2011 10:34 AM, "Philip Martin" wrote: > Daniel Shahaf writes: > > > Agreed that the data in the known-good copy should replace the data in > > other copies > > > > Disagreed that we should recommnd rsync'ing db/ to a portable disk over > > hotcopy to such a disk > > h

Re: Subversion 1.7.1 SRPM building tools and utilities

2011-11-03 Thread Stefan Sperling
On Thu, Nov 03, 2011 at 12:06:51PM +0200, Daniel Shahaf wrote: > On Wednesday, November 02, 2011 9:09 PM, "Nico Kadel-Garcia" > wrote: > > As it stands, simply deleting the existing rhel-3, rhel-4, and rlel-5 > > legacy building bundles and leaving a pointer to the archive patch > > would probabl

Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Stefan Sperling
On Thu, Nov 03, 2011 at 12:01:58PM +0200, Daniel Shahaf wrote: > > As a result, since November, 2005, svnserve on Debian has been patched > > to avoid calling apr_generate_random_bytes() and just use the current > > time as a nonce. That's ugly. So I'd like your advice. > > > > The random number

Re: [Subversion Wiki] Update of "CopySvnsyncMirrorToMaster" by JulianFoad

2011-11-03 Thread Philip Martin
Daniel Shahaf writes: > Agreed that the data in the known-good copy should replace the data in > other copies > > Disagreed that we should recommnd rsync'ing db/ to a portable disk over > hotcopy to such a disk hotcopy to a portable disk would be one way, but the admin may want to rsync over the

Re: auth-test fails (E200006: svn_auth_get_platform_specific_client_providers should return an array of 5 providers)

2011-11-03 Thread Stefan Sperling
On Thu, Nov 03, 2011 at 02:54:04AM -0500, Jonathan Nieder wrote: > The failure is described in tests.log: > > START: auth-test > svn_tests: E26: svn_auth_get_platform_specific_client_providers > should return an array of 5 providers > FAIL: lt-auth-test 1: test retrieving p

Re: Subversion 1.7.1 SRPM building tools and utilities

2011-11-03 Thread Daniel Shahaf
On Wednesday, November 02, 2011 9:09 PM, "Nico Kadel-Garcia" wrote: > On Wed, Nov 2, 2011 at 7:05 AM, Stefan Sperling wrote: > > On Sun, Oct 30, 2011 at 04:45:51PM -0400, Nico Kadel-Garcia wrote: > >> [ Accidentally sent this to old dev address, resending ] > >> > >> The attached patch is a pret

Re: [RFC] ra_svn::make_nonce: how to cope with entropy shortages?

2011-11-03 Thread Daniel Shahaf
On Thursday, November 03, 2011 12:44 AM, "Jonathan Nieder" wrote: > Hi, > > In December, 2004, Alex Jacques reported[1]: > > > If there is little entropy available then svnserve can hang for up to > > several minutes waiting on /dev/random. This is similiar to the problem > > listed here: >

Re: auth-test fails (E200006: svn_auth_get_platform_specific_client_providers should return an array of 5 providers)

2011-11-03 Thread Daniel Shahaf
On Thursday, November 03, 2011 2:54 AM, "Jonathan Nieder" wrote: > Hi, > > Building r1196980: > > svn export ~/src/subversion svn-test > cd svn-test > ./autogen.sh > mkdir BUILD > cd BUILD > PYTHON=python RUBY=ruby \ > ../configure --prefix=$HOM

Re: [PATCH/RFC v2] Optionally allow binaries to run against older SQLite

2011-11-03 Thread Daniel Shahaf
On Wednesday, November 02, 2011 4:25 PM, "Jonathan Nieder" wrote: > Hi again, > > Here's a hopefully saner patch. Thanks much for the quick feedback on > the previous incarnation. > > I'm not very happy about putting -DSVN_SQLITE_COMPAT_VERSION in CFLAGS > --- does subversion have a config.h s

auth-test fails (E200006: svn_auth_get_platform_specific_client_providers should return an array of 5 providers)

2011-11-03 Thread Jonathan Nieder
Hi, Building r1196980: svn export ~/src/subversion svn-test cd svn-test ./autogen.sh mkdir BUILD cd BUILD PYTHON=python RUBY=ruby \ ../configure --prefix=$HOME/opt/subversion \ --mandir=\$${prefix}/share/man \