Re: svn commit: r1182566 - /subversion/branches/tree-read-api/subversion/libsvn_client/tree.c

2011-10-12 Thread Hyrum K Wright
On Wed, Oct 12, 2011 at 3:39 PM, Julian Foad wrote: > Hyrum K Wright wrote: >> > Log: >> > On the 'tree-read-api' branch: >> >> I would very much appreciate a BRANCH-README on this branch. > > Done just now, and on the 'showing-merge-info' branch also.  Thanks for > the prod. Thanks! (And I hope

Re: svn commit: r1182566 - /subversion/branches/tree-read-api/subversion/libsvn_client/tree.c

2011-10-12 Thread Julian Foad
Hyrum K Wright wrote: > > Log: > > On the 'tree-read-api' branch: > > I would very much appreciate a BRANCH-README on this branch. Done just now, and on the 'showing-merge-info' branch also. Thanks for the prod. - Julian

Re: svn commit: r1182566 - /subversion/branches/tree-read-api/subversion/libsvn_client/tree.c

2011-10-12 Thread Hyrum K Wright
On Wed, Oct 12, 2011 at 3:11 PM, wrote: > Author: julianfoad > Date: Wed Oct 12 20:11:28 2011 > New Revision: 1182566 > > URL: http://svn.apache.org/viewvc?rev=1182566&view=rev > Log: > On the 'tree-read-api' branch: I would very much appreciate a BRANCH-README on this branch. Thanks, -Hyrum >

Re: svn commit: r1182248 - in /subversion/branches/tree-read-api/subversion/libsvn_client: tree.c tree.h

2011-10-12 Thread Julian Foad
Greg Stein wrote: > On Oct 12, 2011 4:02 AM, wrote: > >... > > const char *name = svn_dirent_basename(child_abspath, > scratch_pool); > > > > - apr_hash_set(*dirents, name, APR_HASH_KEY_STRING, (void > *)1); > > + apr_hash_set(*dirents, name, APR_HASH_KEY_STRING, name);

Re: svn_mutex causing deadlock in the ruby bindings?

2011-10-12 Thread Hyrum K Wright
On Wed, Oct 12, 2011 at 1:26 PM, Stefan Fuhrmann wrote: > On 12.10.2011 16:34, Hyrum K Wright wrote: >> >> This is just an observation; I've not investigated it at all. >> >> It appears that the ruby bindings tests are currently hanging on one >> of the buildslaves: >> >> http://ci.apache.org/buil

Re: cppcheck results

2011-10-12 Thread Philipp Kloke
Hi, I attached some patches to this mail which fix some of the issues (the easy ones to fix). Because I am not familiar with the code of svn I am unable to work on the other issues. Furthermore I can not say, that the attached fixes will work. Please have a look on them and the remaining cpp

Re: svn_mutex causing deadlock in the ruby bindings?

2011-10-12 Thread Stefan Fuhrmann
On 12.10.2011 16:34, Hyrum K Wright wrote: This is just an observation; I've not investigated it at all. It appears that the ruby bindings tests are currently hanging on one of the buildslaves: http://ci.apache.org/builders/svn-x64-ubuntu-gcc/builds/3636/steps/Test%20bindings/logs/stdio After a

Re: cppcheck results

2011-10-12 Thread Stefan Sperling
On Wed, Oct 12, 2011 at 07:53:14PM +0200, Philipp Kloke wrote: > I checked the subversion source code (r1182475) with cppcheck 1.51 (Windows > x64 configuration). I attached the results to this email. Please have a look > on the results. Hi, do you have time to send patches to fix some of thes

cppcheck results

2011-10-12 Thread Philipp Kloke
I checked the subversion source code (r1182475) with cppcheck 1.51 (Windows x64 configuration). I attached the results to this email. Please have a look on the results.[\bindings\javahl\native\JNIThreadData.cpp:40]: (warning) Member variable 'JNIThreadData::m_formatBuffer' is not initialized in

svn.apache.org has been upgraded to 1.7.0

2011-10-12 Thread Daniel Shahaf
Both EU and US mirrors now run 1.7.0. Previously EU ran 1.6.17 and US ran 1.7.0-rc4. (Plans to install an rc on the EU mirror were cancelled for reasons not related to the 1.7.x releases.)

Re: svn commit: r1182248 - in /subversion/branches/tree-read-api/subversion/libsvn_client: tree.c tree.h

2011-10-12 Thread Greg Stein
On Oct 12, 2011 4:02 AM, wrote: >... > +++ subversion/branches/tree-read-api/subversion/libsvn_client/tree.c Wed Oct 12 08:01:39 2011 > @@ -334,7 +334,7 @@ wc_tree_get_dir(svn_client_tree_t *tree, > const char *child_abspath = APR_ARRAY_IDX(children, i, const char *); > const c

svn_mutex causing deadlock in the ruby bindings?

2011-10-12 Thread Hyrum K Wright
This is just an observation; I've not investigated it at all. It appears that the ruby bindings tests are currently hanging on one of the buildslaves: http://ci.apache.org/builders/svn-x64-ubuntu-gcc/builds/3636/steps/Test%20bindings/logs/stdio After an hour, the buildslave senses that nothing ha

1.7.1 coming end of month?

2011-10-12 Thread Hyrum K Wright
I know that 1.7.0 is less than 24 hours old at this point, but it's been a couple of week since the magic revision, and we've already started to collect various merged items in CHANGES. Given what I expect to be rapid feedback from our early adopters, I'd like to propose that we shoot for a 1.7.1

Re: Exception

2011-10-12 Thread Hyrum K Wright
On Wed, Oct 12, 2011 at 5:17 AM, Stefan Sperling wrote: > On Wed, Oct 12, 2011 at 12:05:20PM +0200, Daniel Shahaf wrote: >> Stefan --- could you make the error below clarify in bold red capital >> letters the part that says "with as much information as possible about >> what you were trying to do"

Re: EXTERNALS table -- good or bad?

2011-10-12 Thread Johan Corveleyn
On Wed, Oct 12, 2011 at 3:38 AM, Neels J Hofmeyr wrote: > On 10/11/2011 01:29 PM, Johan Corveleyn wrote: AFAIUI, the EXTERNALS table is indeed not a cache, but it notes the externals "as rolled out by the last svn update", i.e. the externals "as currently expanded in the WC" (at lea

Re: svn commit: r1182130 - in /subversion/trunk/subversion: libsvn_delta/compat.c libsvn_subr/svn_mutex.c

2011-10-12 Thread Hyrum K Wright
On Tue, Oct 11, 2011 at 6:13 PM, Stefan Sperling wrote: > On Tue, Oct 11, 2011 at 06:03:23PM -0500, Hyrum K Wright wrote: >> > * subversion/libsvn_delta/compat.c >> >  (ev2_close_directory, ev2_absent_directory, ev2_apply_textdelta, >> >   ev2_close_file, ev2_absent_file, complete_cb): Remove a bu

Re: Install and INSTALL issues

2011-10-12 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Oct 12, 2011 at 11:12:28 +0200: > Also note that there is a fairly comprehensive regression test suite > you can use to verify the compiled binaries. 'make check' invokes this > testsuite. See here for more information: > https://svn.apache.org/repos/asf/subversion/tru

Re: Exception

2011-10-12 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Oct 12, 2011 at 12:17:04 +0200: > On Wed, Oct 12, 2011 at 12:05:20PM +0200, Daniel Shahaf wrote: > > Stefan --- could you make the error below clarify in bold red capital > > letters the part that says "with as much information as possible about > > what you were tryin

Re: O(n**3) behaviour in reintegrate merge

2011-10-12 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Oct 12, 2011 at 11:54:44 +0200: > On Tue, Oct 11, 2011 at 11:21:16AM -0700, Paul Burba wrote: > > On Tue, Oct 11, 2011 at 6:36 AM, Stefan Sperling wrote: > > > On Tue, Oct 11, 2011 at 03:05:11PM +0200, Stefan Sperling wrote: > > >> So while I think your fixes should b

Re: Exception

2011-10-12 Thread Stefan Sperling
On Wed, Oct 12, 2011 at 12:05:20PM +0200, Daniel Shahaf wrote: > Stefan --- could you make the error below clarify in bold red capital > letters the part that says "with as much information as possible about > what you were trying to do"? > > There's no reason our users@ volunteers should be answe

Re: Exception

2011-10-12 Thread Daniel Shahaf
Stefan --- could you make the error below clarify in bold red capital letters the part that says "with as much information as possible about what you were trying to do"? There's no reason our users@ volunteers should be answering five times a month "Read the error message" to random people who ins

Re: O(n**3) behaviour in reintegrate merge

2011-10-12 Thread Stefan Sperling
On Tue, Oct 11, 2011 at 11:21:16AM -0700, Paul Burba wrote: > On Tue, Oct 11, 2011 at 6:36 AM, Stefan Sperling wrote: > > On Tue, Oct 11, 2011 at 03:05:11PM +0200, Stefan Sperling wrote: > >> So while I think your fixes should be backported to 1.7.1 ASAP, > >> I don't think the status quo is accep

Re: Install and INSTALL issues

2011-10-12 Thread Philip Martin
Stefan Sperling writes: > On Wed, Oct 12, 2011 at 10:25:19AM +0100, Philip Martin wrote: >> Stefan Sperling writes: >> >> > That idea won't fly. Because --prefix is also used by distribution >> > packagers >> > to install svn into a fake prefix to prepare for packaging. >> > In which case they

Re: Install and INSTALL issues

2011-10-12 Thread Stefan Sperling
On Wed, Oct 12, 2011 at 10:25:19AM +0100, Philip Martin wrote: > Stefan Sperling writes: > > > That idea won't fly. Because --prefix is also used by distribution packagers > > to install svn into a fake prefix to prepare for packaging. > > In which case they do want the apache modules. > > I'd e

Re: Install and INSTALL issues

2011-10-12 Thread Philip Martin
Stefan Sperling writes: > That idea won't fly. Because --prefix is also used by distribution packagers > to install svn into a fake prefix to prepare for packaging. > In which case they do want the apache modules. I'd expect packagers to use the true, final destination in --prefix and then to se

Re: Install and INSTALL issues

2011-10-12 Thread Stefan Sperling
On Tue, Oct 11, 2011 at 04:03:21PM -0700, Andrew McClure wrote: > Anyway this is a problem as I see it in that the .zip and the .tar.gz > contain in fact different files, but are presented on > http://subversion.apache.org/download/ as if they are identical. At a > minimum if you don't want to chan