Re: svn commit: r1157416 - in /subversion/trunk/subversion/bindings/javahl: src/org/apache/subversion/javahl/JNIError.java src/org/tigris/subversion/javahl/JNIError.java tests/org/apache/subversion/ja

2011-08-13 Thread Mark Phippard
We could probably leave it behind for compile purposes but the native code would not throw the old class so I assume user would have a runtime error regardless. Sent from my iPhone On Aug 13, 2011, at 9:24 PM, Hyrum K Wright wrote: > Are there backward compat concerns here? > > IOW, if this

Re: svn commit: r1157416 - in /subversion/trunk/subversion/bindings/javahl: src/org/apache/subversion/javahl/JNIError.java src/org/tigris/subversion/javahl/JNIError.java tests/org/apache/subversion/ja

2011-08-13 Thread Hyrum K Wright
Are there backward compat concerns here? IOW, if this is a public class in the tigris package and folks could conceivably be catching it, such catches would now fail, yes? (I'm not familiar enough with the code or its use cases to know if this is a valid concern or not.) -Hyrum On Sat, Aug 13,

Re: JavaHL Bug in SVN 1.7

2011-08-13 Thread Mark Phippard
On Sat, Aug 13, 2011 at 3:57 PM, Mark Phippard wrote: > On Sat, Aug 13, 2011 at 6:59 AM, Patrick Mayweg wrote: > >> Hello Mark, >> you should definitely move the class. As the name suggests, I used the >> class to throw error from the native code. >> > > Thanks for the confirmation. Will commit

Re: JavaHL Bug in SVN 1.7

2011-08-13 Thread Mark Phippard
On Sat, Aug 13, 2011 at 6:59 AM, Patrick Mayweg wrote: > Hello Mark, > you should definitely move the class. As the name suggests, I used the > class to throw error from the native code. > Thanks for the confirmation. Will commit and nominate fix shortly. -- Thanks Mark Phippard http://mark

[svnbench] Revision: 1157383 compiled Aug 13 2011, 15:26:59

2011-08-13 Thread neels
/home/neels/svnbench/20110813-152859 Started at Sat Aug 13 15:28:59 UTC 2011 - Results for dir levels: 5 spread: 5 Hi, going to run a Subversion benchmark series of 6 runs... Going to write results to new file 5x5_1.7.x

Re: moved-to and moved-from in status output

2011-08-13 Thread Neels J Hofmeyr
On 08/13/2011 05:22 PM, Stefan Sperling wrote: > On Sat, Aug 13, 2011 at 04:45:18PM +0200, Neels J Hofmeyr wrote: >> I very much agree that saying "moved from revision 42" is straight nonsense. >> Saying "Copied From" and "Moved From" in the same info output, while it may >> be correct and sensible

Re: moved-to and moved-from in status output

2011-08-13 Thread Stefan Sperling
On Sat, Aug 13, 2011 at 04:45:18PM +0200, Neels J Hofmeyr wrote: > I very much agree that saying "moved from revision 42" is straight nonsense. > Saying "Copied From" and "Moved From" in the same info output, while it may > be correct and sensible to us devs, is nevertheless ambiguous. > > Can you

Re: svn commit: r1157292 - in /subversion/trunk/subversion: include/svn_client.h include/svn_wc.h libsvn_client/status.c libsvn_wc/status.c svn/status.c

2011-08-13 Thread Stefan Sperling
On Sat, Aug 13, 2011 at 04:50:03PM +0200, Neels J Hofmeyr wrote: > (II) > > D foo > > moved to bar > A +bar > > moved from foo > > > Hmm, (II) kinda looks nice to me. Me too!

Re: svn commit: r1157292 - in /subversion/trunk/subversion: include/svn_client.h include/svn_wc.h libsvn_client/status.c libsvn_wc/status.c svn/status.c

2011-08-13 Thread Neels J Hofmeyr
Argh, forgot about the reply markers. For you folks with graphical mail clients, the first diagram should have looked like this: [ [ D foo [ > moved to bar [ A +bar [ > moved from foo [ People mailing status output -- another argument against '>' in the first column

Re: svn commit: r1157292 - in /subversion/trunk/subversion: include/svn_client.h include/svn_wc.h libsvn_client/status.c libsvn_wc/status.c svn/status.c

2011-08-13 Thread Neels J Hofmeyr
On 08/13/2011 01:56 AM, Stefan Sperling wrote: > On Fri, Aug 12, 2011 at 11:28:01PM -, ne...@apache.org wrote: >> Author: neels >> Date: Fri Aug 12 23:28:00 2011 >> New Revision: 1157292 >> >> URL: http://svn.apache.org/viewvc?rev=1157292&view=rev >> Log: >> Show moved-to and moved-from infor

Re: moved-to and moved-from in status output

2011-08-13 Thread Neels J Hofmeyr
On 08/13/2011 12:31 PM, Stefan Sperling wrote: > Maybe this is a more convincing argument: > > If the client printed 'Moved from URL@REV' it would be printing nonsense. > It is a nonsense thing to say "I moved the node foo as found in revision 42 > to the local node bar". Revisions are immutable s

Re: JavaHL Bug in SVN 1.7

2011-08-13 Thread Patrick Mayweg
Hello Mark, you should definitely move the class. As the name suggests, I used the class to throw error from the native code. Regards, Patrick Am 12.08.2011 17:10, schrieb Mark Phippard: Just ran into this bug in Subclipse. In the JavaHL native code in JNIUtil.h there is this code: static

Re: moved-to and moved-from in status output

2011-08-13 Thread Stefan Sperling
On Sat, Aug 13, 2011 at 03:01:02AM +0200, Neels J Hofmeyr wrote: > stsp, you are whipping out fancy words, issue numbers and mail threads mixed > with trivial info, about things entirely unrelated to *just* printing > "Moved" instead of "Copied" in 'svn' command line client output. > > You said it

Re: svn commit: r1157246 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

2011-08-13 Thread Stefan Sperling
On Sat, Aug 13, 2011 at 10:41:11AM +0400, Ivan Zhakov wrote: > On Sat, Aug 13, 2011 at 00:49, wrote: > > Author: stsp > > Date: Fri Aug 12 20:49:09 2011 > > New Revision: 1157246 > > > > URL: http://svn.apache.org/viewvc?rev=1157246&view=rev > > Log: > > When reverting one half of a move, transfo