Re: Fwd: Build problems in Subversion (in Chinese)

2011-06-29 Thread vijay
On Thursday 30 June 2011 07:04 AM, Daniel Shahaf wrote: The problem is that the prototype of ap_log_rerror() in httpd-2.3.12-beta, [[[ AP_DECLARE(void) ap_log_rerror(const char *file, int line, int module_index, int level, apr_status_t status,

Re: Fwd: Build problems in Subversion (in Chinese)

2011-06-29 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Jun 30, 2011 at 04:34:10 +0300: > Jack Repenning wrote on Wed, Jun 29, 2011 at 17:49:21 -0700: > > > subversion 编译后出现如下错误 > > > subversion/mod_authz_svn/mod_authz_svn.c: In function > > > ‘log_access_verdict’: > > > subversion/mod_authz_svn/mod_authz_svn.c:450: 警告:传递参

Re: Fwd: Build problems in Subversion (in Chinese)

2011-06-29 Thread Daniel Shahaf
Thanks, Jack. Our lists run in English, but in this case I see the problem and I'm moving the conversation to dev@: Jack Repenning wrote on Wed, Jun 29, 2011 at 17:49:21 -0700: > I received this message for moderation to feedb...@tigris.org. My reflex was > to spam-bin it, but then I realized th

Recursive deletion of property throws unnecessary warning

2011-06-29 Thread Vincent Lefevre
I got the following warning with: svn pdel -R svn:eol-style . svn: Attempting to delete nonexistent property 'svn:eol-style' using svn 1.6.17, and exit status 1. I think this should be regarded as a bug. I've searched with Google and found that this problem is not new: http://svn.haxx.se/dev/a

Re: [PATCH] Re: Implement support for 'make check' variants

2011-06-29 Thread Daniel Shahaf
r1141292. (See also r1141291.) Thanks! Noorul Islam K M wrote on Wed, Jun 29, 2011 at 15:58:04 +0530: > Noorul Islam K M writes: > > > Daniel Shahaf writes: > > > >> Reads fine. > >> > >> I'd like to test this patch (perhaps later this week?). > >> > > > > I tested with short_circuit configur

Re: svn commit: r1141133 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2011-06-29 Thread Greg Stein
On Wed, Jun 29, 2011 at 15:03, Daniel Shahaf wrote: > Blair Zajac wrote on Wed, Jun 29, 2011 at 10:11:21 -0700: >> On 06/29/2011 08:22 AM, danie...@apache.org wrote: >> >Author: danielsh >> >Date: Wed Jun 29 15:22:38 2011 >> >New Revision: 1141133 >> > >> >URL: http://svn.apache.org/viewvc?rev=114

Re: svn commit: r1141133 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2011-06-29 Thread Daniel Shahaf
Blair Zajac wrote on Wed, Jun 29, 2011 at 10:11:21 -0700: > On 06/29/2011 08:22 AM, danie...@apache.org wrote: > >Author: danielsh > >Date: Wed Jun 29 15:22:38 2011 > >New Revision: 1141133 > > > >URL: http://svn.apache.org/viewvc?rev=1141133&view=rev > >Log: > >* subversion/libsvn_subr/sqlite.c >

Re: svn commit: r1141133 - /subversion/trunk/subversion/libsvn_subr/sqlite.c

2011-06-29 Thread Blair Zajac
On 06/29/2011 08:22 AM, danie...@apache.org wrote: Author: danielsh Date: Wed Jun 29 15:22:38 2011 New Revision: 1141133 URL: http://svn.apache.org/viewvc?rev=1141133&view=rev Log: * subversion/libsvn_subr/sqlite.c (svn_sqlite__open): Only enable the workaround when we are compiled again

Re: Static code analysis (cppcheck)

2011-06-29 Thread Philip Martin
Julian Foad writes: >> [SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:203]: (style) Variable 'app' >> is assigned a value that is never used >> [SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:273]: (style) Variable 'app' >> is assigned a value that is never used > > I don't really understand the

Re: Static code analysis (cppcheck)

2011-06-29 Thread Julian Foad
Philipp Kloke wrote: > [SVN\subversion\bindings\javahl\native\JNIUtil.h:40] -> > [SVN\subversion\include\svn_types.h:132]: (style) Struct 'svn_error_t' > forward declaration unnecessary, already declared [...] > [SVN\subversion\include\private\svn_temp_serializer.h:42] -> > [SVN\subversion\includ

Re: API review - svn_ra_get_mergeinfo2()

2011-06-29 Thread Paul Burba
On Wed, Jun 29, 2011 at 4:48 AM, Julian Foad wrote: > On Tue, 2011-06-28, C. Michael Pilato wrote: >> On 06/28/2011 01:37 PM, Paul Burba wrote: >> > Hi Julian, >> > >> > I hadn't realized using in-out parameters was considered such bad >> > form. >> >> At a minimum, they force an API divergence in

Re: svn commit: r1140861 - /subversion/trunk/subversion/svnadmin/main.c

2011-06-29 Thread Hyrum K Wright
On Wed, Jun 29, 2011 at 3:26 AM, Julian Foad wrote: > On Wed, 2011-06-29 at 02:16 +0300, Daniel Shahaf wrote: >> hwri...@apache.org wrote on Tue, Jun 28, 2011 at 21:47:06 -: >> > Author: hwright >> > Date: Tue Jun 28 21:47:06 2011 >> > New Revision: 1140861 >> > >> > URL: http://svn.apache.org

Re: Static code analysis (cppcheck)

2011-06-29 Thread Philipp Kloke
Hi Hyrum, I have run the tool again, and the result file is much smaller now. Good work! I attached the remaining issues to this mail. -Ursprüngliche Nachricht- From: Hyrum K Wright Sent: Tuesday, June 28, 2011 9:38 PM To: Philipp Kloke Cc: dev@subversion.apache.org Subject: Re: Sta

Re: [PATCH] 'svn' should not silently ignore a peg revision

2011-06-29 Thread C. Michael Pilato
On 06/29/2011 08:07 AM, Julian Foad wrote: > My question is about this case: > > $ svn copy SOURCE TARGET@HEAD > > This case falls under the last sentence of point (C) above. Issue #3651 > [3] claims that the 'HEAD' peg should be ignored in this case, and that > claim is explicitly tested by c

Re: [Issue 3941] svn:ignore on an svn:externals directory

2011-06-29 Thread Daniel Shahaf
Chris A Mattmann wrote on Tue, Jun 28, 2011 at 20:54:13 -0700: > Hi Daniel, > > On Jun 28, 2011, at 4:45 PM, Daniel Shahaf wrote: > > >> > >> Yeah something like this is what I was thinking about with Greg. Like > >> wouldn't > >> it be nice if I could define something like: > >> > >> property

Re: [PATCH] 'svn' should not silently ignore a peg revision

2011-06-29 Thread Daniel Shahaf
Julian Foad wrote on Wed, Jun 29, 2011 at 13:07:01 +0100: > My question is about this case: > > $ svn copy SOURCE TARGET@HEAD > > This case falls under the last sentence of point (C) above. Issue #3651 > [3] claims that the 'HEAD' peg should be ignored in this case, and that > claim is explici

Re: svn commit: r1140861 - /subversion/trunk/subversion/svnadmin/main.c

2011-06-29 Thread Daniel Shahaf
Thanks for the correction. (I missed the "return the array to caller" bit.)

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Daniel Shahaf
FWIW, my assumption has been that translation from one programming language to another might not suffice to disconnect the link to the original (GPL'd) work. But we're off-topic (and hypothetical) by now. Greg Stein wrote on Wed, Jun 29, 2011 at 06:31:36 -0400: > On Tue, Jun 28, 2011 at 11:24, Hy

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Daniel Shahaf
Arwin Arni wrote on Wed, Jun 29, 2011 at 15:49:10 +0530: > On Tuesday 28 June 2011 09:30 PM, Daniel Shahaf wrote: > >Arwin Arni wrote on Tue, Jun 28, 2011 at 15:45:04 +0530: > >>On Tuesday 28 June 2011 03:36 PM, Noorul Islam K M wrote: > >>>Stefan Sperling writes: > >>> > On Tue, Jun 28, 2011

Re: [PATCH] Re: Implement support for 'make check' variants

2011-06-29 Thread Daniel Shahaf
Noorul Islam K M wrote on Wed, Jun 29, 2011 at 15:43:04 +0530: > Daniel Shahaf writes: > > > Reads fine. > > > > I'd like to test this patch (perhaps later this week?). > > > > I tested with short_circuit configuration. I did not see any errors. > In these kind of patches when I say "test" I m

[PATCH] 'svn' should not silently ignore a peg revision

2011-06-29 Thread Julian Foad
I believe we should make 'svn' reject any peg revision specifier on an argument where it doesn't use one. This is a rather long email to record some of the details behind my reasoning, and a question mainly for Stefan Sperling about issue #3651 [3]. First some context. $ svn cat ^/trunk/readme@1

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Greg Stein
On Tue, Jun 28, 2011 at 08:37, Arwin Arni wrote: >... > check for mixed rev, switched subtrees and local mods and error out if it > is. > Initialize the bisect env. This should be pretty simple. If I recall correctly, there is a wc_db API that queries this information for the 'svnversion' program

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Greg Stein
On Tue, Jun 28, 2011 at 11:24, Hyrum K Wright wrote: > On Tue, Jun 28, 2011 at 10:16 AM, Daniel Shahaf > wrote: >> [ Haven't read the whole thread yet, quick response only to this sentence ] >> >> Peter Samuelson wrote on Tue, Jun 28, 2011 at 10:11:45 -0500: >>> This is why you should read the e

Re: [PATCH] Re: Implement support for 'make check' variants

2011-06-29 Thread Noorul Islam K M
Noorul Islam K M writes: > Daniel Shahaf writes: > >> Reads fine. >> >> I'd like to test this patch (perhaps later this week?). >> > > I tested with short_circuit configuration. I did not see any errors. > >> Would >> make davautocheck ENVVAR=short_circuit >> be a better interface? >> > > I

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Arwin Arni
On Tuesday 28 June 2011 09:30 PM, Daniel Shahaf wrote: Arwin Arni wrote on Tue, Jun 28, 2011 at 15:45:04 +0530: On Tuesday 28 June 2011 03:36 PM, Noorul Islam K M wrote: Stefan Sperling writes: On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: On Tuesday 28 June 2011 03:01 PM, N

Re: [PATCH] Re: Implement support for 'make check' variants

2011-06-29 Thread Noorul Islam K M
Daniel Shahaf writes: > Reads fine. > > I'd like to test this patch (perhaps later this week?). > I tested with short_circuit configuration. I did not see any errors. > Would > make davautocheck ENVVAR=short_circuit > be a better interface? > I made it this way. make davautocheck SVN_PATH

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-06-29 Thread Philip Martin
Justin Erenkrantz writes: > On Wed, Jun 29, 2011 at 7:36 AM, Philip Martin > wrote: >> The code in question is present on the 1.6 branch and we have been >> releasing it periodically without much problem.  The most recent change >> I can identify appears to be r870104 dated 2008-03-24. > > At th

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-06-29 Thread Justin Erenkrantz
On Wed, Jun 29, 2011 at 7:36 AM, Philip Martin wrote: > The code in question is present on the 1.6 branch and we have been > releasing it periodically without much problem.  The most recent change > I can identify appears to be r870104 dated 2008-03-24. At the time (not verified on subsequent rel

Re: API review - svn_ra_get_mergeinfo2()

2011-06-29 Thread Julian Foad
On Tue, 2011-06-28, C. Michael Pilato wrote: > On 06/28/2011 01:37 PM, Paul Burba wrote: > > Hi Julian, > > > > I hadn't realized using in-out parameters was considered such bad > > form. > > At a minimum, they force an API divergence in our bindings layers. +1 to > separate and explicit in and

Re: svn commit: r1140861 - /subversion/trunk/subversion/svnadmin/main.c

2011-06-29 Thread Julian Foad
On Wed, 2011-06-29 at 02:16 +0300, Daniel Shahaf wrote: > hwri...@apache.org wrote on Tue, Jun 28, 2011 at 21:47:06 -: > > Author: hwright > > Date: Tue Jun 28 21:47:06 2011 > > New Revision: 1140861 > > > > URL: http://svn.apache.org/viewvc?rev=1140861&view=rev > > Log: > > * subversion/svnad

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-06-29 Thread Philip Martin
Justin Erenkrantz writes: > I don't expect that the situation has improved since I tossed > it...but, if others want to maintain it, go for it. But, expect that > you're going to be spending lots of time (as I did) trying to get > every edge case of a platform to work. The code in question is p