Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-04 Thread Greg Stein
On Thu, May 5, 2011 at 02:00, Hyrum K Wright wrote: > On Wed, May 4, 2011 at 8:46 PM,   wrote: >> Author: gstein >> Date: Thu May  5 01:46:31 2011 >> New Revision: 1099657 >> >> URL: http://svn.apache.org/viewvc?rev=1099657&view=rev >> Log: >> Combine the changelist modification notification into

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-04 Thread Hyrum K Wright
On Wed, May 4, 2011 at 8:46 PM, wrote: > Author: gstein > Date: Thu May  5 01:46:31 2011 > New Revision: 1099657 > > URL: http://svn.apache.org/viewvc?rev=1099657&view=rev > Log: > Combine the changelist modification notification into the operation > itself, so that (in the future) we can make gu

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-04 Thread Greg Stein
On Wed, May 4, 2011 at 21:46, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Thu May  5 01:46:31 2011 >... > @@ -3594,32 +3601,31 @@ svn_wc__db_op_set_changelist(svn_wc__db_ >... > +  /* ### why we do filter SOME of the changelist notifications? if a row > +     ### is inserted,

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-04 Thread Hyrum K Wright
On Thu, May 5, 2011 at 12:35 AM, Greg Stein wrote: > On Wed, May 4, 2011 at 22:49, Hyrum K Wright wrote: >> On Wed, May 4, 2011 at 8:46 PM,   wrote: >>> Author: gstein >>> Date: Thu May  5 01:46:31 2011 >>> New Revision: 1099657 >>> >>> URL: http://svn.apache.org/viewvc?rev=1099657&view=rev >>> L

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-04 Thread Greg Stein
On Wed, May 4, 2011 at 22:49, Hyrum K Wright wrote: > On Wed, May 4, 2011 at 8:46 PM,   wrote: >> Author: gstein >> Date: Thu May  5 01:46:31 2011 >> New Revision: 1099657 >> >> URL: http://svn.apache.org/viewvc?rev=1099657&view=rev >> Log: >> Combine the changelist modification notification into

Re: svn commit: r1099657 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c wc_db.c wc_db.h

2011-05-04 Thread Hyrum K Wright
On Wed, May 4, 2011 at 8:46 PM, wrote: > Author: gstein > Date: Thu May  5 01:46:31 2011 > New Revision: 1099657 > > URL: http://svn.apache.org/viewvc?rev=1099657&view=rev > Log: > Combine the changelist modification notification into the operation > itself, so that (in the future) we can make gu

Re: Making delete resolve tree conflicts

2011-05-04 Thread Philip Martin
Julian Foad writes: >> > It also solves one of the orphaned ACTUAL_NODE problems: if the >> > conflicted node is within an added tree then deleting the tree and >> > leaving the ACTUAL_NODE row could result in an ACTUAL_NODE that has no >> > parents. >> >> That would still be a "local delete, in

Re: Making delete resolve tree conflicts

2011-05-04 Thread Julian Foad
On Wed, 2011-05-04 at 12:42 -0400, Greg Stein wrote: > On Wed, May 4, 2011 at 12:37, Philip Martin > wrote: > > To make the new single-txn delete pass the regression tests I had to > > make it leave ACTUAL_NODE rows with tree conflicts. This preserved the > > behaviour of the old per-node delete

Re: Making delete resolve tree conflicts

2011-05-04 Thread Philip Martin
Greg Stein writes: > On Wed, May 4, 2011 at 12:37, Philip Martin > wrote: >> To make the new single-txn delete pass the regression tests I had to >> make it leave ACTUAL_NODE rows with tree conflicts.  This preserved the >> behaviour of the old per-node delete code, but I'm wondering if that is

Re: [PATCH] Add a test for issue#3870

2011-05-04 Thread Philip Martin
Philip Martin writes: >> +@Issue(3870) >> +@SkipUnless(svntest.main.is_posix_os) >> +@XFail() And that should be: @XFail(svntest.main.is_ra_type_dav_serf) >> +def fd_leak_sync_from_serf_to_local(sbox): >> + "FD leak during sync over serf to local" -- Philip

Re: [PATCH] Add a test for issue#3870

2011-05-04 Thread Philip Martin
Arwin Arni writes: > Index: subversion/tests/cmdline/svnsync_tests.py > === > --- subversion/tests/cmdline/svnsync_tests.py (revision 1099373) > +++ subversion/tests/cmdline/svnsync_tests.py (working copy) > @@ -155,7 +155,8 @@ > >

Re: svn commit: r1099436 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c update_editor.c wc_db.c wc_db.h

2011-05-04 Thread Greg Stein
On Wed, May 4, 2011 at 12:34, Hyrum K Wright wrote: > On Wed, May 4, 2011 at 11:31 AM, Greg Stein wrote: >> On Wed, May 4, 2011 at 08:55,   wrote: >>>... >>> +++ subversion/trunk/subversion/libsvn_wc/wc_db.h Wed May  4 12:55:03 2011 >>> @@ -1215,7 +1215,10 @@ svn_wc__db_op_delete(svn_wc__db_t *db

Re: Making delete resolve tree conflicts

2011-05-04 Thread Greg Stein
On Wed, May 4, 2011 at 12:37, Philip Martin wrote: > To make the new single-txn delete pass the regression tests I had to > make it leave ACTUAL_NODE rows with tree conflicts.  This preserved the > behaviour of the old per-node delete code, but I'm wondering if that is > the correct thing to do.  

Making delete resolve tree conflicts

2011-05-04 Thread Philip Martin
To make the new single-txn delete pass the regression tests I had to make it leave ACTUAL_NODE rows with tree conflicts. This preserved the behaviour of the old per-node delete code, but I'm wondering if that is the correct thing to do. I suspect that the current behaviour is, in part at least, a

Re: svn commit: r1099436 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c update_editor.c wc_db.c wc_db.h

2011-05-04 Thread Hyrum K Wright
On Wed, May 4, 2011 at 11:31 AM, Greg Stein wrote: > On Wed, May 4, 2011 at 08:55,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/wc_db.h Wed May  4 12:55:03 2011 >> @@ -1215,7 +1215,10 @@ svn_wc__db_op_delete(svn_wc__db_t *db, >>  /* Make delete notifications for all paths in the del

Re: svn commit: r1099436 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c update_editor.c wc_db.c wc_db.h

2011-05-04 Thread Greg Stein
On Wed, May 4, 2011 at 08:55, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/wc_db.h Wed May  4 12:55:03 2011 > @@ -1215,7 +1215,10 @@ svn_wc__db_op_delete(svn_wc__db_t *db, >  /* Make delete notifications for all paths in the delete list created >  * by deleting LOCAL_ABSPATH. >  * > -

[PATCH] Add a test for issue#3870

2011-05-04 Thread Arwin Arni
Hi All, This patch adds a test to svnsync_tests.py, to showcase issue #3870: (http://subversion.tigris.org/issues/show_bug.cgi?id=3870) "File descriptor leaks during svnsync" Regards, Arwin Arni Index: subversion/tests/cmdline/svnsync_tests.py ==

Results from count-progress.py and WC-NG

2011-05-04 Thread Mark Phippard
Does this tool still have any meaning for us? Do the results indicate any specific remaining work that must be done for 1.7? $ svn up Updated to revision 1099439. $ ./tools/dev/wc-ng/count-progress.py | libsvn_client | libsvn_wc | Total ---+

AW: Reversion of copied directories with depth != infinity

2011-05-04 Thread Markus Schaber
Hi, Philip, > Von: Philip Martin [mailto:philip.mar...@wandisco.com] > "Markus Schaber" writes: > 1.7 changes the behaviour so that depth more accurately describes the > nodes to be affected; issue 3851 describes some corner cases in 1.7. OK, I see. So maybe some of the workaround code I just

RE: svn commit: r1099298 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c

2011-05-04 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > Sent: woensdag 4 mei 2011 11:33 > To: dev@subversion.apache.org > Cc: comm...@subversion.apache.org > Subject: Re: svn commit: r1099298 - > /subversion/trunk/subversion/libsvn_ra_serf/serf.c > > I assume the se

Re: svn commit: r1099298 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c

2011-05-04 Thread Daniel Shahaf
I assume the server would error if someone removed this check on the client side? rhuij...@apache.org wrote on Wed, May 04, 2011 at 00:04:29 -: > Author: rhuijben > Date: Wed May 4 00:04:29 2011 > New Revision: 1099298 > > URL: http://svn.apache.org/viewvc?rev=1099298&view=rev > Log: > In li

Re: svn commit: r1095914 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/merge.c libsvn_wc/deprecated.c libsvn_wc/props.c libsvn_wc/props.h libsvn_wc/update_editor.c

2011-05-04 Thread Philip Martin
Greg Stein writes: > How about after r1099145? Yes, that fixes the valgrind warnings. -- Philip