the retry loop in svn_io_file_lock2()

2011-03-29 Thread Daniel Shahaf
Why does svn_io_file_lock2() have a retry loop? The reason given in the code is that some consumer of libsvn_fs wants to run a critical section while holding a lock in each of two FSFS filesystems. In that case, why isn't the fix just to tell the consumer to, when wanting to lock N filesystems, t

Re: Bug in svnrdump (trunk@1085375) -- malformed dump file with multiple properties

2011-03-29 Thread C. Michael Pilato
On 03/28/2011 08:26 AM, neil.win...@bt.com wrote: > Sorry, but no cigar :( This probably fixes the assertion found by Hyrum, > but doesn't address the original issue. To simplify things, I've repurposed issue #3844[1] to track the problem that Hyrum was solving, and opened a new issue #3847[2] for

Re: svn commit: r1085464 - /subversion/trunk/subversion/svnrdump/load_editor.c

2011-03-29 Thread C. Michael Pilato
On 03/29/2011 04:50 AM, Bert Huijben wrote: > This patch needs a second ra session to work properly. (ra_local, ra_neon > and ra_serf happen to work ok, but the session is busy with a different > operation here). > > See the svnserve failures. FIXED: Sendingtrunk/subversion/svnrdump/lo

Re: Performance benchmarks

2011-03-29 Thread Mark Phippard
I thought I did. Sorry will do so now. You can also click button and request to join the project and edit the wiki yourself (applies to anyone). On Tue, Mar 29, 2011 at 3:40 PM, Johan Corveleyn wrote: > On Tue, Mar 29, 2011 at 6:08 PM, Mark Phippard wrote: >> Thanks!  All results have been ad

Re: Performance benchmarks

2011-03-29 Thread Johan Corveleyn
On Tue, Mar 29, 2011 at 6:08 PM, Mark Phippard wrote: > Thanks!  All results have been added to the wiki. Hi Mark, Can you add my WinXP results as well? (sent 21 hours ago, according to gmail :-)). Or do you have enough benchmark data from Windowses for now (I think they are all 64 bit)? Cheer

Re: Performance benchmarks

2011-03-29 Thread Mark Phippard
Thanks! All results have been added to the wiki. On Tue, Mar 29, 2011 at 11:36 AM, vijay wrote: > On Sunday 27 March 2011 12:21 AM, Mark Phippard wrote: >> >> I would love to see someone do some tests with the WC on local disk vs >> network mount (1.6 and 1.7).  I tried to do it using some vir

Re: Performance benchmarks

2011-03-29 Thread vijay
On Sunday 27 March 2011 12:21 AM, Mark Phippard wrote: I would love to see someone do some tests with the WC on local disk vs network mount (1.6 and 1.7). I tried to do it using some virtual machines I have access to at CollabNet. The problem is that the connection of these boxes to the NetApp

Re: [PATCH] issue #3014 "svn log | head" should not print "Write error: Broken pipe"

2011-03-29 Thread Stefan Sperling
On Mon, Mar 28, 2011 at 04:03:10PM +0200, Stefan Sperling wrote: > Here is a patch that attempts to fix issue #3014. > > In the issue, Julian suggests that there should be a policy as to when > svn should and should not report errors on broken pipes. > I think that would complicate things too much

ApacheCon NA 2011 Call For Participation and Early Registration are OPEN!

2011-03-29 Thread C. Michael Pilato
As you might have seen, the Apache Conference Committee is now accepting presentation proposals for ApacheCon North America 2011. This year's conference is being held November 7-11 in Vancouver, Canada. You can read the official Call for Participation at the Apache blog: https://blogs.apache.org

Re: Serf failures with trunk

2011-03-29 Thread Mark Phippard
On Tue, Mar 29, 2011 at 6:02 AM, Philip Martin wrote: > Can anyone reproduce this? I ran the test results I posted using Serf trunk on a Windows box. Paul Burba did as well. -- Thanks Mark Phippard http://markphip.blogspot.com/

Re: Performance benchmarks

2011-03-29 Thread Mark Phippard
On Mon, Mar 28, 2011 at 6:45 PM, Greg Stein wrote: > I think your benchmarks are going to be more helpful for us to locate > hotspots and get them fixed. Mark's seem more high-level, for > policy-making rather than coding. >From what I can see both are just driving the command line. Main differ

Re: Performance benchmarks

2011-03-29 Thread John Beranek
On 29/03/11 01:33, Greg Stein wrote: > On Mon, Mar 28, 2011 at 18:51, John Beranek wrote: >> On 28/03/2011 23:45, Greg Stein wrote: >>> On Mon, Mar 28, 2011 at 17:42, John Beranek wrote: On 25/03/2011 17:33, Mark Phippard wrote: > Hi, > > I have been working on a framework for wr

RE: Bug in svnrdump (trunk@1085375) -- malformed dump file with multiple properties

2011-03-29 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:danie...@elego.de] > Sent: dinsdag 29 maart 2011 12:13 > To: neil.win...@bt.com > Cc: Hyrum K Wright; C. Michael Pilato; dev@subversion.apache.org > Subject: Re: Bug in svnrdump (trunk@1085375) -- malformed dump file with > multiple prope

Re: Performance benchmarks

2011-03-29 Thread vijay
Hi, I have run these tests on ubuntu 10.10 with svn 1.6.12 and svn 1.7.0-dev(r1086476). Repository access: file:// Attached the results. Thanks & Regards, Vijayaguru On Friday 25 March 2011 11:03 PM, Mark Phippard wrote: Hi, I have been working on a framework for writing tests to record

Re: [PATCH] Bump serf version in get-deps.sh

2011-03-29 Thread Daniel Shahaf
Thanks, r1086537. Arwin Arni wrote on Tue, Mar 29, 2011 at 14:53:00 +0530: > Hi All, > > The minimal serf version that our trunk requires is 0.7.1. However, the > get-deps.sh script still fetches 0.7.0. Here's a patch to bump this > version. This makes it easier for first-timers to compile and

Re: Bug in svnrdump (trunk@1085375) -- malformed dump file with multiple properties

2011-03-29 Thread Daniel Shahaf
I've taken a shot at a regression test in r1086497. However, I think we may have a larger problem here: The svn_delta_editor_t API allows change_dir_prop() calls to be transmitted only after all directory-children of a directory have been transmitted [1]. How can we generate a dumpfile given th

Serf failures with trunk

2011-03-29 Thread Philip Martin
I'm getting assert failures while testing serf performance. Typically ../src/subversion/libsvn_ra_serf/update.c:622: (apr_err=235000) svn: E235000: In file '../src/subversion/libsvn_ra_serf/update.c' line 622: assertion failed (! dir->ref_count) Aborted or: svn: E200014: Checksum mismatch for

Re: Performance benchmarks

2011-03-29 Thread Daniel Becroft
On Sun, Mar 27, 2011 at 4:51 AM, Mark Phippard wrote: > On Fri, Mar 25, 2011 at 1:33 PM, Mark Phippard wrote: > > > I have been working on a framework for writing tests to record > > performance. I have something good enough to share: > > > > https://ctf.open.collab.net/sf/projects/csvn > > > >

Re: Performance benchmarks

2011-03-29 Thread Johan Corveleyn
Forgot to add: this was with the repository via svnserve on localhost. Johan On Tue, Mar 29, 2011 at 12:16 AM, Johan Corveleyn wrote: > Hi Mark, > > Here is another data point, for my old (t)rusty Windows XP (32-bit) > this time, on a system with a pretty slow hard disk (5.4k rpm), 1.83 > GHz In

[PATCH] Bump serf version in get-deps.sh

2011-03-29 Thread Arwin Arni
Hi All, The minimal serf version that our trunk requires is 0.7.1. However, the get-deps.sh script still fetches 0.7.0. Here's a patch to bump this version. This makes it easier for first-timers to compile and build subversion. Regards, Arwin Arni Index: get-deps.sh ===

RE: svn commit: r1085464 - /subversion/trunk/subversion/svnrdump/load_editor.c

2011-03-29 Thread Bert Huijben
> -Original Message- > From: hwri...@apache.org [mailto:hwri...@apache.org] > Sent: vrijdag 25 maart 2011 17:52 > To: comm...@subversion.apache.org > Subject: svn commit: r1085464 - > /subversion/trunk/subversion/svnrdump/load_editor.c > > Author: hwright > Date: Fri Mar 25 16:52:10 2011