Re: [PATCH] Remove redundant url-encoding added in r917523

2011-03-24 Thread vijay
On Thursday 24 March 2011 10:09 PM, Peter Samuelson wrote: DAV svn SVNParentPath /repositories DAV svn SVNParentPath /repositories-slave SVNMasterURI "http://localhost/svn 1" That seems like an incorrect configuration. The SVNMasterURI, like any other URI, should not have an

Re: Case-only renames on Windows (issue #3702)

2011-03-24 Thread Johan Corveleyn
2011/3/24 Branko Čibej : > On 24.03.2011 15:22, Philip Martin wrote: >> Johan Corveleyn writes: >> >>> I'm looking at issue #3702 ("svn ren TODO todo" not work on windows). >> It's a bit tricky :)  Consider a mixed-case node "Foo".  It's seems >> obvious that >> >>    svn mv Foo foo >> >> is a cas

RE: svn commit: r1084971 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2011-03-24 Thread Bert Huijben
> -Original Message- > From: Greg Stein [mailto:gst...@gmail.com] > Sent: donderdag 24 maart 2011 18:37 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1084971 - > /subversion/trunk/subversion/libsvn_wc/update_editor.c > > On Thu, Mar 24, 2011 at 13:33, Greg Stein wrote: > >

Re: svn commit: r1084971 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2011-03-24 Thread Greg Stein
On Thu, Mar 24, 2011 at 13:33, Greg Stein wrote: > On Thu, Mar 24, 2011 at 10:39,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/update_editor.c Thu Mar 24 >> 14:39:55 2011 >>... >> @@ -3615,10 +3609,10 @@ merge_file(svn_skel_t **work_items, >>   *install_pristine = FALSE; >>   *inst

Re: svn commit: r1084971 - /subversion/trunk/subversion/libsvn_wc/update_editor.c

2011-03-24 Thread Greg Stein
On Thu, Mar 24, 2011 at 10:39, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/update_editor.c Thu Mar 24 14:39:55 > 2011 >... > @@ -3615,10 +3609,10 @@ merge_file(svn_skel_t **work_items, >   *install_pristine = FALSE; >   *install_from = NULL; > > -  if (new_text_base_sha1_checksum !=

Re: [PATCH] Remove redundant url-encoding added in r917523

2011-03-24 Thread Peter Samuelson
> > DAV svn > SVNParentPath /repositories > > > DAV svn > SVNParentPath /repositories-slave > SVNMasterURI "http://localhost/svn 1" > That seems like an incorrect configuration. The SVNMasterURI, like any other URI, should not have an unescaped space in it. I don't know if that ch

Re: Case-only renames on Windows (issue #3702)

2011-03-24 Thread Branko Čibej
On 24.03.2011 15:22, Philip Martin wrote: > Johan Corveleyn writes: > >> I'm looking at issue #3702 ("svn ren TODO todo" not work on windows). > It's a bit tricky :) Consider a mixed-case node "Foo". It's seems > obvious that > >svn mv Foo foo > > is a case-only rename. But what about > >

Re: Case-only renames on Windows (issue #3702)

2011-03-24 Thread Philip Martin
Johan Corveleyn writes: > I'm looking at issue #3702 ("svn ren TODO todo" not work on windows). It's a bit tricky :) Consider a mixed-case node "Foo". It's seems obvious that svn mv Foo foo is a case-only rename. But what about svn mv FOO foo or svn mv foo foo It's possible to d

Re: [PATCH] Remove redundant url-encoding added in r917523

2011-03-24 Thread Kamesh Jayachandran
On 03/24/2011 05:54 PM, vijay wrote: Just now I came to know that it fails in neon only. I configured neon as a default ra_layer in my runtime configuration area. When I use serf as ra_layer, the commit succeeds. Yes that answers the failure I observed. Please provide a testcase that exhibit

Re: [PATCH] Remove redundant url-encoding added in r917523

2011-03-24 Thread vijay
Just now I came to know that it fails in neon only. I configured neon as a default ra_layer in my runtime configuration area. When I use serf as ra_layer, the commit succeeds. Thanks & Regards, vijayaguru On Thursday 24 March 2011 05:12 PM, Kamesh Jayachandran wrote: Thanks for the Patch Vija

Re: [PATCH] Remove redundant url-encoding added in r917523

2011-03-24 Thread Kamesh Jayachandran
Thanks for the Patch Vijay. In my FC14 your testcase passes both with and without patch. I am investigating Will get back. With regards Kamesh Jayachandran On 03/24/2011 04:11 PM, vijay wrote: Hi, This patch adds a testcase for the regression triggered by r917523 and fixes it. The rev

[PATCH] Remove redundant url-encoding added in r917523

2011-03-24 Thread vijay
Hi, This patch adds a testcase for the regression triggered by r917523 and fixes it. The revision r917523 do some url-encodings to the paths and uris in subversion/mod_dav_svn/mirror.c. $svn log -r917523 r917523 | kam