Re: [PATCH] Fix for issue 3826

2011-03-02 Thread Noorul Islam K M
Daniel Becroft writes: > On Thu, Mar 3, 2011 at 3:34 AM, Noorul Islam K M wrote: > >> >> Please find attached patch for issue 3826. All tests pass using 'make >> check' >> > > Hey Noorul, > > I had a quick look at this issue last night. It appears a similar issue > exists for almost every comman

Re: [PATCH] Fix for issue 3826

2011-03-02 Thread Noorul Islam K M
Daniel Becroft writes: > On Thu, Mar 3, 2011 at 3:34 AM, Noorul Islam K M wrote: > >> >> Please find attached patch for issue 3826. All tests pass using 'make >> check' >> > > Hey Noorul, > > I had a quick look at this issue last night. It appears a similar issue > exists for almost every comman

Re: Subversion hackathon at Knockree Retreat (13-16 May)

2011-03-02 Thread Greg Stein
On Wed, Mar 2, 2011 at 15:37, Hyrum K Wright wrote: > On Tue, Mar 1, 2011 at 4:08 PM, Nick Burch wrote: >> Hi All >> >> The Apache Conferences Committee (ConCom) are pleased to announce the 2nd >> Apache Retreat at Knockree in Ireland, from Friday 13th to Monday 16th May. >> As some of you may al

Re: Subversion hackathon at Knockree Retreat (13-16 May)

2011-03-02 Thread Hyrum K Wright
On Tue, Mar 1, 2011 at 4:08 PM, Nick Burch wrote: > Hi All > > The Apache Conferences Committee (ConCom) are pleased to announce the 2nd > Apache Retreat at Knockree in Ireland, from Friday 13th to Monday 16th May. > As some of you may already known, your project is taking part in the > retreat, a

Re: [PATCH] Fix for issue 3826

2011-03-02 Thread Daniel Becroft
On Thu, Mar 3, 2011 at 3:34 AM, Noorul Islam K M wrote: > > Please find attached patch for issue 3826. All tests pass using 'make > check' > Hey Noorul, I had a quick look at this issue last night. It appears a similar issue exists for almost every command (I checked 'info', 'status' and 'updat

[PATCH] Fix for issue 3826

2011-03-02 Thread Noorul Islam K M
Please find attached patch for issue 3826. All tests pass using 'make check' Log [[[ Fix for issue 3826. Make svn diff respect absolute paths. Also fix corresponding test. * subversion/svn/diff-cmd.c (svn_cl__diff): Do not convert absolute path into relative one. * subversion/tests/cmdline

Re: [PATCH] fix for issue #3789 log -g regression in r1028108

2011-03-02 Thread kmradke
Paul Burba wrote on 03/02/2011 10:10:40 AM: > On Wed, Mar 2, 2011 at 10:44 AM, C. Michael Pilato > wrote: > > On 03/02/2011 10:40 AM, kmra...@rockwellcollins.com wrote: > >> "C. Michael Pilato" wrote on 01/28/2011 01:44:26 PM: > >>> Subject: Re: [PATCH] fix for issue #3789 log -g regression in

Re: [PATCH] fix for issue #3789 log -g regression in r1028108

2011-03-02 Thread Paul Burba
On Wed, Mar 2, 2011 at 10:44 AM, C. Michael Pilato wrote: > On 03/02/2011 10:40 AM, kmra...@rockwellcollins.com wrote: >> "C. Michael Pilato" wrote on 01/28/2011 01:44:26 PM: >>> Subject: Re: [PATCH] fix for issue #3789 log -g regression in r1028108 >>> >>> On 01/26/2011 05:59 PM, Kevin Radke wro

Re: [PATCH] fix for issue #3789 log -g regression in r1028108

2011-03-02 Thread C. Michael Pilato
On 03/02/2011 10:40 AM, kmra...@rockwellcollins.com wrote: > "C. Michael Pilato" wrote on 01/28/2011 01:44:26 PM: >> Subject: Re: [PATCH] fix for issue #3789 log -g regression in r1028108 >> >> On 01/26/2011 05:59 PM, Kevin Radke wrote: >> > This also needs a back-port to the 1.6.x branch. >> > >>

Re: [PATCH] fix for issue #3789 log -g regression in r1028108

2011-03-02 Thread kmradke
"C. Michael Pilato" wrote on 01/28/2011 01:44:26 PM: > Subject: Re: [PATCH] fix for issue #3789 log -g regression in r1028108 > > On 01/26/2011 05:59 PM, Kevin Radke wrote: > > This also needs a back-port to the 1.6.x branch. > > > > [[[ > >Fix issue #3789: Correctly ignore missing locations

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Arwin Arni
Hi All, Thanks for all the feedback. As Stefan said, yes, this patch was an immense learning experience for me and I wouldn't trade it for anything else. All said and done, I hope this is not the end of this patch. It implements exactly what the issue tracker describes and I think it would

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Mark Phippard
On Wed, Mar 2, 2011 at 9:14 AM, Daniel Shahaf wrote: > Mark Phippard wrote on Wed, Mar 02, 2011 at 08:50:31 -0500: >> I also do not see why clients could not use this.  Presumably it sends >> notifications just like merge --dry-run. >> > > svn up -q -r BASE && svn merge --dry-run -r BASE:HEAD ./ .

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-02 Thread Kamesh Jayachandran
Thanks Vijay. Committed your in r1076234. With regards Kamesh Jayachandran On 03/02/2011 03:18 PM, vijay wrote: Attached the patch that uses macro based solution. APLOG_USE_MODULE is used only in case of HTTPD 2.3. Thanks & Regards, Vijayaguru On Wednesday 02 March 2011 12:20 AM, Stefan Spe

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Kamesh Jayachandran
On 03/02/2011 07:47 PM, Daniel Shahaf wrote: Bert Huijben wrote on Wed, Mar 02, 2011 at 11:14:24 +0100: -Original Message- From: Arwin Arni [mailto:ar...@collab.net] Please review this and share your thoughts. I don't think this is the way we should implement this. Which is precisely w

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Stefan Sperling
On Wed, Mar 02, 2011 at 04:17:33PM +0200, Daniel Shahaf wrote: > Bert Huijben wrote on Wed, Mar 02, 2011 at 11:14:24 +0100: > > > -Original Message- > > > From: Arwin Arni [mailto:ar...@collab.net] > > > Please review this and share your thoughts. > > > > I don't think this is the way we s

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Daniel Shahaf
Bert Huijben wrote on Wed, Mar 02, 2011 at 11:14:24 +0100: > > -Original Message- > > From: Arwin Arni [mailto:ar...@collab.net] > > Please review this and share your thoughts. > > I don't think this is the way we should implement this. Which is precisely why one should contact the mailin

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Travis
On Mar 2, 2011, at 7:50 AM, Mark Phippard wrote: > On Wed, Mar 2, 2011 at 8:42 AM, Hyrum K Wright wrote: >> On Wed, Mar 2, 2011 at 4:14 AM, Bert Huijben wrote: >> >> Agreed. I'm not a fan of duplicating this functionality (and >> maintaining them in parallel when they inevitably drift) as pa

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Daniel Shahaf
Mark Phippard wrote on Wed, Mar 02, 2011 at 08:50:31 -0500: > I also do not see why clients could not use this. Presumably it sends > notifications just like merge --dry-run. > svn up -q -r BASE && svn merge --dry-run -r BASE:HEAD ./ ./

Re: svn commit: r1072519 - in /subversion/trunk: ./ subversion/include/svn_io.h subversion/libsvn_subr/stream.c subversion/libsvn_subr/subst.c subversion/tests/libsvn_subr/stream-test.c

2011-03-02 Thread Greg Stein
On Sun, Feb 20, 2011 at 02:05, wrote: > Author: stefan2 > Date: Sun Feb 20 07:05:56 2011 > New Revision: 1072519 > > URL: http://svn.apache.org/viewvc?rev=1072519&view=rev > Log: > Merge all changes (r1068695 - r1072516) from the > integrate-stream-api-extensions. > > These patches add svn_stream

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Mark Phippard
On Wed, Mar 2, 2011 at 8:42 AM, Hyrum K Wright wrote: > On Wed, Mar 2, 2011 at 4:14 AM, Bert Huijben wrote: >> >> >>> -Original Message- >>> From: Arwin Arni [mailto:ar...@collab.net] >>> Sent: woensdag 2 maart 2011 10:49 >>> To: dev@subversion.apache.org >>> Subject: [PATCH] Add --dry-ru

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Hyrum K Wright
On Wed, Mar 2, 2011 at 4:14 AM, Bert Huijben wrote: > > >> -Original Message- >> From: Arwin Arni [mailto:ar...@collab.net] >> Sent: woensdag 2 maart 2011 10:49 >> To: dev@subversion.apache.org >> Subject: [PATCH] Add --dry-run flag to "svn update" client command >> >> Hi All, >> >> In my

Re: svn commit: r1076098 - /subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c

2011-03-02 Thread Hyrum K Wright
Thanks. On Wed, Mar 2, 2011 at 4:09 AM, Greg Stein wrote: > fixed in r1076161 > > On Wed, Mar 2, 2011 at 05:04, Greg Stein wrote: >> Line 564 of wc_db_pdh.c is the culprit. >> >> Figuring out a fix... >> >> >> On Wed, Mar 2, 2011 at 05:03, Greg Stein wrote: >>> Somehow, this broke the build. >>

Re: strange caracteres

2011-03-02 Thread C. Michael Pilato
The encoding is more likely to be a file-wide attribute, therefore it makes more sense to carry that information in a file property. In the past, I've been in favor of adding an svn:encoding or svn:charset property; others have suggested simply using the "; charset=latin1" bit that can be tagged o

Re: [PATCH] issue #3719 fix slow large checkouts on Windows

2011-03-02 Thread Stefan Sperling
On Wed, Mar 02, 2011 at 08:31:01AM +, Neil Bird wrote: > Around about 01/03/11 17:13, Stefan Sperling typed ... > >Great! Here's a new version that includes a fix for the lock_tests > >failures. I'll propose this for backport now. Thanks for providing > >the initial patch submission for this an

Re: What is the most simple way to use svn_stream_t?

2011-03-02 Thread Greg Stein
Use svn_stream_from_stringbuf(). That will put the contents of the file into the stringbuf, which you can access after the cat2() call is done. NOTE: be very careful of reading file contents into memory. You really don't want to try and read a 16 gigabyte file this way. Cheers, -g On Wed, Mar 2,

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Arwin Arni
Hi Bert, I don't think this is the way we should implement this. This patch adds an if before every operation in the update editor that changes the working copy. This makes the update editor harder to maintain, while you really only need a simple editor implementation that notifies its output

RE: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Bert Huijben
> -Original Message- > From: Arwin Arni [mailto:ar...@collab.net] > Sent: woensdag 2 maart 2011 10:49 > To: dev@subversion.apache.org > Subject: [PATCH] Add --dry-run flag to "svn update" client command > > Hi All, > > In my effort to understand the delta editor API, I took it upon myse

Re: svn commit: r1076098 - /subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c

2011-03-02 Thread Greg Stein
fixed in r1076161 On Wed, Mar 2, 2011 at 05:04, Greg Stein wrote: > Line 564 of wc_db_pdh.c is the culprit. > > Figuring out a fix... > > > On Wed, Mar 2, 2011 at 05:03, Greg Stein wrote: >> Somehow, this broke the build. >> >> Investigating... >> >> >> On Tue, Mar 1, 2011 at 22:07,   wrote: >>>

Re: svn commit: r1076098 - /subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c

2011-03-02 Thread Greg Stein
Line 564 of wc_db_pdh.c is the culprit. Figuring out a fix... On Wed, Mar 2, 2011 at 05:03, Greg Stein wrote: > Somehow, this broke the build. > > Investigating... > > > On Tue, Mar 1, 2011 at 22:07,   wrote: >> Author: hwright >> Date: Wed Mar  2 03:07:04 2011 >> New Revision: 1076098 >> >> UR

RE: svn commit: r1075984 - /subversion/branches/1.6.x/STATUS

2011-03-02 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > Sent: woensdag 2 maart 2011 4:13 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1075984 - /subversion/branches/1.6.x/STATUS > > Bert Huijben wrote on Tue, Mar 01, 2011 at 23:06:3

Re: svn commit: r1076098 - /subversion/trunk/subversion/libsvn_wc/wc_db_pdh.c

2011-03-02 Thread Greg Stein
Somehow, this broke the build. Investigating... On Tue, Mar 1, 2011 at 22:07, wrote: > Author: hwright > Date: Wed Mar  2 03:07:04 2011 > New Revision: 1076098 > > URL: http://svn.apache.org/viewvc?rev=1076098&view=rev > Log: > * subversion/libsvn_wc/wc_db_pdh.c >  (pdh_parse_local_abspath): F

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-02 Thread vijay
Attached the patch that uses macro based solution. APLOG_USE_MODULE is used only in case of HTTPD 2.3. Thanks & Regards, Vijayaguru On Wednesday 02 March 2011 12:20 AM, Stefan Sperling wrote: On Tue, Mar 01, 2011 at 11:08:22PM +0530, Kamesh Jayachandran wrote: On the whole I preferred the mac

Re: [PATCH] issue #3719 fix slow large checkouts on Windows

2011-03-02 Thread Neil Bird
Around about 01/03/11 17:13, Stefan Sperling typed ... Great! Here's a new version that includes a fix for the lock_tests failures. I'll propose this for backport now. Thanks for providing the initial patch submission for this and for helping with testing! Yep, that's the kiddie! Thanks for

What is the most simple way to use svn_stream_t?

2011-03-02 Thread Grigory Petrov
Hello. I need to programmatically get content of a specified revision of versioned file. I think svn_client_cat2() will do a good job, but the first parameter, "svn_stream_t* out" puzzles me a bit. I have read about "streams" in corresponding header file (not a very long reading) and it seems to b